----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121466/#review72111 -----------------------------------------------------------
First this should be up to Nuno: he has always been advocating to add contrast pixels everywhere Second: do we really want to still make design changes to oxygen now that KF5 and breeze is out ? (leaving asside the fact that the option should also be ported to oxygen@gtk and gtk3, for consistency) IMHO: oxygen is done and in maintainance/debug mode only. Adding more options, design changes etc will just make it harder to maintain. In the end unless there is some real use case and/or bug to be fixed I would rather not commit the change ... Hugo - Hugo Pereira Da Costa On Dec. 12, 2014, 3:03 p.m., David Edmundson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/121466/ > ----------------------------------------------------------- > > (Updated Dec. 12, 2014, 3:03 p.m.) > > > Review request for Plasma and Hugo Pereira Da Costa. > > > Repository: oxygen > > > Description > ------- > > Add an option to enable/disable drawing darker frames round the selection > highlight > > default is left unchanged and the option is hidden away in the advanced view > settings. > > > Diffs > ----- > > kstyle/config/oxygenstyleconfig.cpp db0dac6 > kstyle/config/ui/oxygenstyleconfig.ui 8a7c937 > kstyle/oxygen.kcfg afbd7c0 > kstyle/oxygenstylehelper.cpp 500a52f > > Diff: https://git.reviewboard.kde.org/r/121466/diff/ > > > Testing > ------- > > > File Attachments > ---------------- > > frame disabled > > https://git.reviewboard.kde.org/media/uploaded/files/2014/12/12/d72eac7c-d2c2-4eac-9b1c-8c6e7164a799__contactlist1.png > enabled (default and as before) > > https://git.reviewboard.kde.org/media/uploaded/files/2014/12/12/8a0f6337-bafe-40f7-a25d-6946b2b1af0b__contactlist1.png > > > Thanks, > > David Edmundson > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
