Re: Review Request 121429: Use out-of-band communication between ksld and greeter

> On Dec. 15, 2014, 11:45 p.m., Àlex Fiestas wrote: > > Code looks good. > > > > Could you perhaps add an integration test for this? Since we are > > "abstracted" by the socket it should be possible. If it is too much work > > feel free to push it. what do you want the integration test to te

Re: Review Request 121429: Use out-of-band communication between ksld and greeter

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121429/#review72103 --- Ship it! Code looks good. Could you perhaps add an integrat

Re: Review Request 121219: Load IconItem immediately upon componentComplete()

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121219/ --- (Updated Dec. 15, 2014, 7:21 p.m.) Status -- This change has been ma

Re: Review Request 121219: Load IconItem immediately upon componentComplete()

> On Dez. 15, 2014, 5:49 nachm., David Edmundson wrote: > > So is everything fixed now? > > Kai Uwe Broulik wrote: > Looks that way. > > Eike Hein wrote: > https://www.youtube.com/watch?v=k4onJ7Z2MLI GEMA … but I get what you mean xd - Kai Uwe --

Re: Review Request 121219: Load IconItem immediately upon componentComplete()

> On Dec. 15, 2014, 5:49 p.m., David Edmundson wrote: > > So is everything fixed now? > > Kai Uwe Broulik wrote: > Looks that way. https://www.youtube.com/watch?v=k4onJ7Z2MLI - Eike --- This is an automatically generated e-mail. To

Re: Review Request 121219: Load IconItem immediately upon componentComplete()

> On Dez. 15, 2014, 5:49 nachm., David Edmundson wrote: > > So is everything fixed now? Looks that way. - Kai Uwe --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121219/#review72079

Re: Review Request 121219: Load IconItem immediately upon componentComplete()

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121219/#review72079 --- Ship it! So is everything fixed now? - David Edmundson On

Jenkins build is back to normal : plasma-workspace_master_qt5 #1146

See ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Build failed in Jenkins: plasma-workspace_master_qt5 #1145

See Changes: [bhush94] Register shortcuts for activities management -- [...truncated 1712 lines...] ^ [ 28%] Building CXX object appmenu/CMakeFiles/kded_a

Re: Review Request 121533: Register actions for activities management

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121533/ --- (Updated Dec. 15, 2014, 4:15 p.m.) Status -- This change has been ma

Re: Review Request 121533: Register actions for activities management

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121533/#review72070 --- Ship it! Ship It! - Martin Gräßlin On Dec. 15, 2014, 4:41

Re: Review Request 121533: Register actions for activities management

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121533/#review72069 --- shell/shellcorona.cpp

Re: Review Request 121533: Register actions for activities management

> On Dec. 15, 2014, 8:57 p.m., Lukáš Tinkl wrote: > > shell/shellcorona.cpp, line 1491 > > > > > > Ha? :) nah > On Dec. 15, 2014, 8:57 p.m., Lukáš Tinkl wrote: > > shell/shellcorona.cpp, line 170 > >

Re: Review Request 121533: Register actions for activities management

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121533/ --- (Updated Dec. 15, 2014, 9:11 p.m.) Review request for Plasma. Changes -

Re: Review Request 121533: Register actions for activities management

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121533/#review72064 --- shell/shellcorona.cpp

Re: Review Request 121533: Register actions for activities management

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121533/#review72063 --- shell/shellcorona.cpp

Re: Review Request 121533: Register actions for activities management

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121533/ --- (Updated Dec. 15, 2014, 8:53 p.m.) Review request for Plasma. Changes -

Review Request 121533: Register actions for activities management

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121533/ --- Review request for Plasma. Bugs: 341856 https://bugs.kde.org/show_bug

Re: Review Request 121429: Use out-of-band communication between ksld and greeter

> On Dec. 15, 2014, 1:39 p.m., David Edmundson wrote: > > ksmserver/screenlocker/greeter/greeterapp.cpp, line 428 > > > > > > AFAIK you don't need to pass "this" in the [] when you have "this" as > > the receive

Re: Review Request 121429: Use out-of-band communication between ksld and greeter

> On Dec. 15, 2014, 2:39 p.m., David Edmundson wrote: > > ksmserver/screenlocker/greeter/greeterapp.cpp, line 428 > > > > > > AFAIK you don't need to pass "this" in the [] when you have "this" as > > the receive

Re: Review Request 121429: Use out-of-band communication between ksld and greeter

> On Dec. 15, 2014, 2:39 p.m., David Edmundson wrote: > > So basically we have a named pipe and we we pass back the wID of the lock > > screen to ksld? > > > > I'm not sure what benefit we have from using Wayland as the protocol as > > opposed to a private p2p DBus session or just writing it o

Re: Review Request 121429: Use out-of-band communication between ksld and greeter

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121429/#review72044 --- So basically we have a named pipe and we we pass back the wID

Re: Review Request 121472: Override plasmoid size to zero rather than one

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121472/ --- (Updated Dec. 15, 2014, 1:36 p.m.) Status -- This change has been ma

Re: Review Request 121294: Improve wallpaper sourceSize handling

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121294/ --- (Updated Dec. 15, 2014, 1:36 p.m.) Status -- This change has been ma

Feedback on xdg-shell from Plasma crew

Hi all, I had a look at the xdg-shell proposal in weston (see [1]) and want to provide some feedback from a Plasma/KWin point of view. First of all: thanks for the work so far on the xdg-shell. The work looks quite good and promising. If you reply to the thread, please keep both the plasma and

Re: Review Request 119814: [ksld] ScreenLocker inhibits sleep on logind

> On Dec. 15, 2014, 2:01 p.m., Lukáš Tinkl wrote: > > Solid:Powermanagement has a signal resumingfromSuspend(), conversely, we > > could add a backend-independent signal goingToSleep() which ScreenLocker > > could connect to. so we could connent to the resumingFromSuspend for the non-logind ba

Re: Review Request 119814: [ksld] ScreenLocker inhibits sleep on logind

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119814/#review72049 --- Solid:Powermanagement has a signal resumingfromSuspend(), conv

Re: Review Request 121360: Rework Plasma's notification positioning code

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121360/#review72042 --- Maybe a QReadWriteLock instead of a QMutex to make the locking

Re: Review Request 121294: Improve wallpaper sourceSize handling

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121294/#review72046 --- Ship it! Ship It! - Marco Martin On Dec. 4, 2014, 9:16 p.m

Re: Review Request 121472: Override plasmoid size to zero rather than one

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121472/#review72045 --- Ship it! Ship It! - Sebastian Kügler On Dec. 13, 2014, 12:

Minutes Monday Plasma hangout

15th December, 2014 We'll skip the Monday hangout on the 29th. Present: David, Jens, Aleix, Kai Uwe, Marco, Martin G., Martin K., Vishesh, Sebastian David: - Resizing issue in IconItem - Performance issue in date/time engine fixed - Performance improved in Plasma::Svg Jens: - Working on appl

Re: Review Request 121529: Let others know that we support persistent notifications

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121529/ --- (Updated Pro. 15, 2014, 12:02 odp.) Status -- This change has been d

Re: Review Request 121360: Rework Plasma's notification positioning code

> On Dec. 5, 2014, 8:19 p.m., Martin Gräßlin wrote: > > I'm a little bit concerned about the mutex usage. I somehow don't see where > > this could be threaded. If it's using threads due to the rendering, then > > it's important that you create it as a QMutex::Recursive mutex as otherwise > > o

Re: Review Request 121530: Remove lock screen on suspend

> On Dec. 15, 2014, 11:55 a.m., Kai Uwe Broulik wrote: > > daemon/actions/bundled/suspendsession.cpp, line 112 > > > > > > It is not guaranteed that the backend actually uses logind. > > > > Backend coul

Re: Review Request 121530: Remove lock screen on suspend

> On Dec. 15, 2014, 11:55 a.m., Kai Uwe Broulik wrote: > > daemon/actions/bundled/suspendsession.cpp, line 112 > > > > > > It is not guaranteed that the backend actually uses logind. > > > > Backend coul

Re: Review Request 121530: Remove lock screen on suspend

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121530/#review72036 --- daemon/actions/bundled/suspendsession.cpp

Re: Review Request 119814: [ksld] ScreenLocker inhibits sleep on logind

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119814/#review72034 --- https://git.reviewboard.kde.org/r/121530/ handles removal of t

Review Request 121530: Remove lock screen on suspend

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121530/ --- Review request for Plasma and Solid. Repository: powerdevil Description

Re: Review Request 121529: Let others know that we support persistent notifications

> On Dec. 15, 2014, 10:59 a.m., Martin Klapetek wrote: > > This spec is however gnome's own extension of the original spec, which has > > no such stuff. Is there an actual use case why this would be needed? > > > > More general question - should we be implementing their extensions? > > Jan Gru

Re: Review Request 119814: [ksld] ScreenLocker inhibits sleep on logind

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119814/ --- (Updated Dec. 15, 2014, 11:18 a.m.) Review request for Plasma and Àlex Fi

Re: Review Request 121529: Let others know that we support persistent notifications

> On Pro. 15, 2014, 9:59 dop., Martin Klapetek wrote: > > This spec is however gnome's own extension of the original spec, which has > > no such stuff. Is there an actual use case why this would be needed? > > > > More general question - should we be implementing their extensions? A guy from R

Re: Review Request 121529: Let others know that we support persistent notifications

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121529/#review72029 --- This spec is however gnome's own extension of the original spe

Review Request 121529: Let others know that we support persistent notifications

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121529/ --- Review request for Plasma and Martin Klapetek. Repository: plasma-workspa

Re: Review Request 121429: Use out-of-band communication between ksld and greeter

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121429/ --- (Updated Dec. 15, 2014, 10:29 a.m.) Review request for Plasma, Àlex Fiest

Re: Review Request 119814: [ksld] ScreenLocker inhibits sleep on logind

> On Dec. 14, 2014, 8:57 p.m., Kai Uwe Broulik wrote: > > Ping? > > > > PowerDevil already uses the Logind1 interfaces for suspending in case it > > finds a systemd version >= 195 Thanks for that info. This removes a road blocker. So all that's left is moving the config option to screen locke