Re: Jenkins build is back to stable : plasma-desktop_master_qt5 #737

2014-10-16 Thread Martin Gräßlin
On Thursday 16 October 2014 16:00:52 KDE CI System wrote: > See thanks Marco *hugs* Cheers Martin signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mail

Jenkins build is back to normal : plasma-workspace_master_qt5 #981

2014-10-16 Thread KDE CI System
See ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Re: Should touch events update the cursor position?

2014-10-16 Thread Martin Gräßlin
On Thursday 16 October 2014 16:32:02 Weng Xuetian wrote: > If we're talking about the cursor image moving or not, the cursor will hide > on other platform if touch event comes int. The cursor position doesn't > matter if there's no visual feedback (hover event). consider that the mouse could be mo

Re: Baloo - Not Indexing everything by default

2014-10-16 Thread Ömer Fadıl USTA
Couldnt we add a .baloo file to specify for attributes for current directory, file or subdirectories about not indexing ? For example of a .baloo file skip_all skip_if_greater 1m skip_if_smaller 50k skip_ext txt jpg With --subdirs flag like Skip_ext --subdirs txt jpg Skip_all --subdirs On Oct 16,

Re: Review Request 120276: Initial port to frameworks for the comic dataengine.

2014-10-16 Thread Andrei Amuraritei
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120276/ --- (Updated Oct. 17, 2014, 3:08 a.m.) Review request for Plasma, David Edmun

Re: Review Request 120276: Initial port to frameworks for the comic dataengine.

2014-10-16 Thread Andrei Amuraritei
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120276/ --- (Updated Oct. 17, 2014, 3:08 a.m.) Review request for Plasma, David Edmun

Re: Review Request 120276: Initial port to frameworks for the comic dataengine.

2014-10-16 Thread Andrei Amuraritei
> On Oct. 13, 2014, 3:02 p.m., Martin Klapetek wrote: > > dataengines/comic/CMakeLists.txt, line 12 > > > > > > Is the KDELibs4Support needed only because of the KStandardDirs? If > > yes, then let's port away fr

Re: Review Request 120276: Initial port to frameworks for the comic dataengine.

2014-10-16 Thread Andrei Amuraritei
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120276/ --- (Updated Oct. 17, 2014, 2:59 a.m.) Review request for Plasma, David Edmun

Re: Baloo - Not Indexing everything by default

2014-10-16 Thread Weng Xuetian
As for text file, in linux world people don't usually use .txt extension, especially when writing something like vimwiki or something similar. I guess cap the size is some what better solution ( 1-5MB is good enough). And as for folder limitation, that doesn't sound good, people usually organze f

Re: Review Request 120526: Strip PowerDevilCore, PowerDevilUI and PowerDevil's kded from kdelibs4support

2014-10-16 Thread Hrvoje Senjan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120526/ --- (Updated Oct. 16, 2014, 8:43 p.m.) Status -- This change has been ma

Re: Should touch events update the cursor position?

2014-10-16 Thread Weng Xuetian
If we're talking about the cursor image moving or not, the cursor will hide on other platform if touch event comes int. The cursor position doesn't matter if there's no visual feedback (hover event). As for mouse.pos(), this should always be updated, for example there are application use mouse pos

Jenkins build is back to stable : plasma-desktop_master_qt5 #737

2014-10-16 Thread KDE CI System
See ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Broken plasma-deskop build on CI

2014-10-16 Thread Marco Martin
hmm, that test was fixed last week and nothing there was touched since.. On Thursday 16 October 2014, Kai Uwe Broulik wrote: > I'm afraid the lookandfeel kcm test fails here with and without this > change. > > Am Donnerstag, 16. Oktober 2014, 17:28:42 schrieb Martin Gräßlin: > > Hi all, > > > >

Re: Broken plasma-deskop build on CI

2014-10-16 Thread Kai Uwe Broulik
I'm afraid the lookandfeel kcm test fails here with and without this change. Am Donnerstag, 16. Oktober 2014, 17:28:42 schrieb Martin Gräßlin: > Hi all, > > is anyone going into fixing the broken plasma-desktop build on the CI > system? > > Apparently it broke with > http://projects.kde.org/proj

Re: Should touch events update the cursor position?

2014-10-16 Thread Marco Martin
On Thursday 16 October 2014, Martin Gräßlin wrote: > > > What do the people with a touch screen think about it? How do you > > > expect it > > > to behave in a perfect world? > > > > kinda used to touch events moving the cursor, so maybe is just habit.. > > also, iirc in qt touchevents also genera

Broken plasma-deskop build on CI

2014-10-16 Thread Martin Gräßlin
Hi all, is anyone going into fixing the broken plasma-desktop build on the CI system? Apparently it broke with http://projects.kde.org/projects/kde/workspace/plasma-desktop/repository/diff?rev=cef4d1f44b37e7f57bfd1fa12c15df7b40e8a892 this also means: please run the unit tests before pushing. CI

Re: Re: Should touch events update the cursor position?

2014-10-16 Thread Martin Gräßlin
On Thursday 16 October 2014 16:57:24 Marco Martin wrote: > On Thursday 16 October 2014, Martin Gräßlin wrote: > > Hi touch screen users, > > > > I'm currently wondering how our cursor should behave when there are touch > > events. Under X11 I expect that it moves the cursor, but is that really > >

Jenkins build is still unstable: plasma-desktop_master_qt5 #736

2014-10-16 Thread KDE CI System
See ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Should touch events update the cursor position?

2014-10-16 Thread Marco Martin
On Thursday 16 October 2014, Kai Uwe Broulik wrote: > Hi, > > I find it distracting to have the highly-visible cursor follow my finger > all the time. > > What Windows 8 does - and I have to admit, that thing might suck on a > Desktop but the touch hybrid stuff is quite well thought out - it hide

Re: Should touch events update the cursor position?

2014-10-16 Thread Kai Uwe Broulik
Hi, I find it distracting to have the highly-visible cursor follow my finger all the time. What Windows 8 does - and I have to admit, that thing might suck on a Desktop but the touch hybrid stuff is quite well thought out - it hides the mouse cursor when touch interaction happens and shows a s

Re: Should touch events update the cursor position?

2014-10-16 Thread Marco Martin
On Thursday 16 October 2014, Martin Gräßlin wrote: > Hi touch screen users, > > I'm currently wondering how our cursor should behave when there are touch > events. Under X11 I expect that it moves the cursor, but is that really the > expected behavior? Should it affect the cursor position at all?

Should touch events update the cursor position?

2014-10-16 Thread Martin Gräßlin
Hi touch screen users, I'm currently wondering how our cursor should behave when there are touch events. Under X11 I expect that it moves the cursor, but is that really the expected behavior? Should it affect the cursor position at all? In my thought it's the cursor image should only be moved b

Jenkins build became unstable: plasma-desktop_master_qt5 #735

2014-10-16 Thread KDE CI System
See ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 120604: Cleanup applet configuration scrollbar handling

2014-10-16 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120604/ --- (Updated Oct. 16, 2014, 2:38 p.m.) Status -- This change has been ma

Re: Review Request 120604: Cleanup applet configuration scrollbar handling

2014-10-16 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120604/#review68558 --- Ship it! Inviala! - Marco Martin On Ott. 16, 2014, 1:14 p.

Re: Review Request 120604: Cleanup applet configuration scrollbar handling

2014-10-16 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120604/#review68554 --- Ship it! Ship It! - Aleix Pol Gonzalez On Oct. 16, 2014, 1

Review Request 120604: Cleanup applet configuration scrollbar handling

2014-10-16 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120604/ --- Review request for Plasma. Bugs: 336533 and 337298 https://bugs.kde.o

Re: Baloo - Not Indexing everything by default

2014-10-16 Thread Martin Steigerwald
Am Donnerstag, 16. Oktober 2014, 14:20:06 schrieb Luca Beltrame: > In data giovedì 16 ottobre 2014 14:15:15, Martin Gräßlin ha scritto: > > genome data is really huge wouldn't it make sense to go rather for file > > size or abort the indexing if it's obvious random gibberish? > > As the person who

Re: Baloo - Not Indexing everything by default

2014-10-16 Thread Luca Beltrame
In data giovedì 16 ottobre 2014 14:15:15, Martin Gräßlin ha scritto: > genome data is really huge wouldn't it make sense to go rather for file > size or abort the indexing if it's obvious random gibberish? As the person who mentioned this first (hey, I'm famous ;), I'm guessing that limiting on

Re: Baloo - Not Indexing everything by default

2014-10-16 Thread Martin Gräßlin
On Thursday 16 October 2014 13:20:57 Vishesh Handa wrote: > Hey guys > > While Baloo performs better than Nepomuk. It does have its share of > problems - mostly large text files, and high IO usage. Additionally, users > on linux often seem to have the craziest files. Currently, we do not index > p

Re: Baloo - Not Indexing everything by default

2014-10-16 Thread Eike Hein
On 16.10.2014 13:20, Vishesh Handa wrote: Comments? I understand the pragmatic motivation behind it, but it seems like a strange step to me. The idea behind indexing is that you can find things regardless of location, so you don't need to be aware of where things are. By making the index sele

Re: Baloo - Not Indexing everything by default

2014-10-16 Thread Kai Uwe Broulik
Hi, > * Desktop, Documents, Videos, Pictures and Music. All of these are xdg user > directories. The only reason I actually index my kf5 folder with all the git clones in it, is because Dolphin doesn't properly fallback when searching non-indexed locations and then it won't find anything (in fa

Re: Baloo - Not Indexing everything by default

2014-10-16 Thread Martin Steigerwald
Am Donnerstag, 16. Oktober 2014, 13:27:02 schrieb Marco Martin: > On Thursday 16 October 2014, Vishesh Handa wrote: > > * $HOME - Not including any subfolders. > > * Desktop, Documents, Videos, Pictures and Music. All of these are xdg > > user > > directories. > > > > Gnome Tracker actually does s

Re: Baloo - Not Indexing everything by default

2014-10-16 Thread Martin Steigerwald
Am Donnerstag, 16. Oktober 2014, 13:20:57 schrieb Vishesh Handa: > Hey guys Hi Vishesh, > While Baloo performs better than Nepomuk. It does have its share of > problems - mostly large text files, and high IO usage. Additionally, users > on linux often seem to have the craziest files. Currently, w

Re: Baloo - Not Indexing everything by default

2014-10-16 Thread David Edmundson
Seems a shame to do this now that things are working so well. Since the .txt only change Baloo hasn't bothered me at all. David ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Baloo - Not Indexing everything by default

2014-10-16 Thread Marco Martin
On Thursday 16 October 2014, Vishesh Handa wrote: > * $HOME - Not including any subfolders. > * Desktop, Documents, Videos, Pictures and Music. All of these are xdg user > directories. > > Gnome Tracker actually does something quite similar. > > Comments? +1 i tend to prefer a whitelist on what

Baloo - Not Indexing everything by default

2014-10-16 Thread Vishesh Handa
Hey guys While Baloo performs better than Nepomuk. It does have its share of problems - mostly large text files, and high IO usage. Additionally, users on linux often seem to have the craziest files. Currently, we do not index plain text files which do not have a `.txt` extension, because otherwis