----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120276/ -----------------------------------------------------------
(Updated Oct. 17, 2014, 2:59 a.m.) Review request for Plasma, David Edmundson, Marco Martin, and Sebastian Kügler. Changes ------- Fix Martin Klapetek reported issues. Repository: kdeplasma-addons Description ------- comic DataEngine initial port to frameworks. Diffs (updated) ----- dataengines/CMakeLists.txt 04c7985 dataengines/comic/CMakeLists.txt 8e382e6 dataengines/comic/cachedprovider.h baac8a9 dataengines/comic/cachedprovider.cpp caca25e dataengines/comic/comic.h 8cc3969 dataengines/comic/comic.cpp 7130f44 dataengines/comic/comic_package.h 32be381 dataengines/comic/comic_package.cpp 6d2ff0b dataengines/comic/comic_package_plugin.cpp d997947 dataengines/comic/comicprovider.h 630ee8d dataengines/comic/comicprovider.cpp ab248a5 dataengines/comic/comicproviderkross.h 46a9072 dataengines/comic/comicproviderkross.cpp 9820f05 dataengines/comic/comicproviderwrapper.h 81eee68 dataengines/comic/comicproviderwrapper.cpp 48ced42 Diff: https://git.reviewboard.kde.org/r/120276/diff/ Testing ------- Building from source, compiles 100%, some deprecated warnings. DataEngine shows up in plasmaengineexplorer and detects installed .comic packages. This is the initial port, still need to review code to fix issues like whitespaces around ( or the deprecated parts. Thanks notmart, d_ed, sebas, bshas etc for helping. Thanks, Andrei Amuraritei
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
