Re: Review Request 120416: [dataengines/share] Get rid of KDELibs4Support

2014-09-28 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120416/#review67601 --- Ship it! Ship It! - Aleix Pol Gonzalez On Sept. 28, 2014,

Review Request 120417: [dataengines/weather/ions] Get rid of KDELibs4Support

2014-09-28 Thread Hrvoje Senjan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120417/ --- Review request for Plasma. Repository: plasma-workspace Description ---

Review Request 120416: [dataengines/share] Get rid of KDELibs4Support

2014-09-28 Thread Hrvoje Senjan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120416/ --- Review request for Plasma. Repository: plasma-workspace Description ---

Re: Review Request 120415: [dataengines/systemmonitor] Get rid of KDELibs4Support

2014-09-28 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120415/#review67598 --- Ship it! Ship It! - Martin Klapetek On Sept. 29, 2014, 12:

Review Request 120415: [dataengines/systemmonitor] Get rid of KDELibs4Support

2014-09-28 Thread Hrvoje Senjan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120415/ --- Review request for Plasma. Repository: plasma-workspace Description ---

Re: Review Request 120414: [statusnotifierwatcher] Get rid of KDELibs4Support

2014-09-28 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120414/#review67597 --- Ship it! Ship It! - David Edmundson On Sept. 28, 2014, 10:

Review Request 120414: [statusnotifierwatcher] Get rid of KDELibs4Support

2014-09-28 Thread Hrvoje Senjan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120414/ --- Review request for Plasma. Repository: plasma-workspace Description ---

Build failed in Jenkins: plasma-workspace_master_qt5 #926

2014-09-28 Thread KDE CI System
See Changes: [jpwhiting] Fix style. -- Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit Building remotely on LinuxSlave - 3 (PACKAGER LINBUILDER) in workspace

Re: Review Request 120413: [systemmonitor] Get rid of KDELibs4Support

2014-09-28 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120413/#review67596 --- Ship it! Ship It! - David Edmundson On Sept. 28, 2014, 10:

Review Request 120413: [systemmonitor] Get rid of KDELibs4Support

2014-09-28 Thread Hrvoje Senjan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120413/ --- Review request for Plasma and Vishesh Handa. Repository: plasma-workspace

Re: Review Request 120411: Set title on wallpaper kns dialog. BUG:336737

2014-09-28 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120411/ --- (Updated Sept. 28, 2014, 10:03 p.m.) Status -- This change has been

Re: Review Request 120411: Set title on wallpaper kns dialog. BUG:336737

2014-09-28 Thread Martin Klapetek
> On Sept. 28, 2014, 11:23 p.m., David Edmundson wrote: > > wallpapers/image/image.cpp, line 563 > > > > > > we don't really need the if() > > we know it's a valid pointer as we set it only 2 lines ago. (plu

Re: Review Request 120411: Set title on wallpaper kns dialog. BUG:336737

2014-09-28 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120411/#review67591 --- Ship it! wallpapers/image/image.cpp

Review Request 120411: Set title on wallpaper kns dialog. BUG:336737

2014-09-28 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120411/ --- Review request for Plasma. Bugs: 336737 https://bugs.kde.org/show_bug

Re: Review Request 120409: [KF5XmlRpcClientPrivate] Keep it private

2014-09-28 Thread Hrvoje Senjan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120409/ --- (Updated Sept. 28, 2014, 6:18 p.m.) Status -- This change has been m

Re: Review Request 120409: [KF5XmlRpcClientPrivate] Keep it private

2014-09-28 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120409/#review67582 --- Ship it! Ship It! - David Edmundson On Sept. 28, 2014, 6:0

Review Request 120409: [KF5XmlRpcClientPrivate] Keep it private

2014-09-28 Thread Hrvoje Senjan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120409/ --- Review request for Plasma, Aleix Pol Gonzalez, Rohan Garg, and Harald Sitte

Re: Review Request 120407: Show application title if SNI does not provide a tooltip

2014-09-28 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120407/ --- (Updated Sept. 28, 2014, 5:43 p.m.) Status -- This change has been m

Re: Review Request 120396: Port the PowerDevil runner

2014-09-28 Thread Hrvoje Senjan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120396/ --- (Updated Sept. 28, 2014, 5:40 p.m.) Status -- This change has been m

Re: Review Request 120397: Port the Kill (Terminate applications) runner

2014-09-28 Thread Hrvoje Senjan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120397/ --- (Updated Sept. 28, 2014, 5:40 p.m.) Status -- This change has been m

Re: Review Request 120407: Show application title if SNI does not provide a tooltip

2014-09-28 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120407/#review67576 --- Ship it! Ship It! - David Edmundson On Sept. 28, 2014, 4:0

Jenkins build is back to normal : plasma-workspace_master_qt5 #921

2014-09-28 Thread KDE CI System
See ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 120407: Show application title if SNI does not provide a tooltip

2014-09-28 Thread Kai Uwe Broulik
> On Sept. 28, 2014, 4:24 nachm., David Edmundson wrote: > > applets/systemtray/plugin/protocols/dbussystemtray/dbussystemtraytask.cpp, > > line 423 > > > > > > In the case that we set a blank title but a valid

Re: Review Request 120407: Show application title if SNI does not provide a tooltip

2014-09-28 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120407/#review67571 --- I'll try again at making a sensible review. applets/systemtr

Re: Review Request 120407: Show application title if SNI does not provide a tooltip

2014-09-28 Thread David Edmundson
> On Sept. 28, 2014, 4:13 p.m., David Edmundson wrote: > > applets/systemtray/plugin/protocols/dbussystemtray/dbussystemtraytask.cpp, > > line 439 > > > > > > this looks wrong. > > otherwise if you have a ti

Re: Review Request 120407: Show application title if SNI does not provide a tooltip

2014-09-28 Thread Kai Uwe Broulik
> On Sept. 28, 2014, 4:13 nachm., David Edmundson wrote: > > applets/systemtray/plugin/protocols/dbussystemtray/dbussystemtraytask.cpp, > > line 439 > > > > > > this looks wrong. > > otherwise if you have a

Re: Review Request 120407: Show application title if SNI does not provide a tooltip

2014-09-28 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120407/#review67566 --- applets/systemtray/plugin/protocols/dbussystemtray/dbussystem

Re: Review Request 120407: Show application title if SNI does not provide a tooltip

2014-09-28 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120407/ --- (Updated Sept. 28, 2014, 4:06 nachm.) Review request for Plasma. Change

Review Request 120407: Show application title if SNI does not provide a tooltip

2014-09-28 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120407/ --- Review request for Plasma. Bugs: 337710 https://bugs.kde.org/show_bug

[kio-extras] [Bug 339456] Thumbnailers in kio-extras needs porting to KF5

2014-09-28 Thread Maarten De Meyer
https://bugs.kde.org/show_bug.cgi?id=339456 --- Comment #3 from Maarten De Meyer --- Git commit 72d25f79050f8cf249b0a640a2be8764c59eca91 by Maarten De Meyer. Committed on 28/09/2014 at 15:35. Pushed by demeyer into branch 'master'. Port comicbook thumbnailer to KF5 Mostly standard porting stuff

Build failed in Jenkins: plasma-workspace_master_qt5 #920

2014-09-28 Thread KDE CI System
See Changes: [scripty] SVN_SILENT made messages (.desktop file) [montel] remove not necessary include moc -- [...truncated 2135 lines...] [ 40%] Building CXX object klipper/CMakeFiles/pla

Re: Review Request 120397: Port the Kill (Terminate applications) runner

2014-09-28 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120397/#review67555 --- Ship it! Ship It! - David Edmundson On Sept. 27, 2014, 8:4

Re: Review Request 120396: Port the PowerDevil runner

2014-09-28 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120396/#review67554 --- Ship it! Ship It! - David Edmundson On Sept. 27, 2014, 7:3

Re: Review Request 120352: Remove keyboard click volume setting

2014-09-28 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120352/ --- (Updated Sept. 28, 2014, 1:33 p.m.) Review request for Plasma and Frederi

Re: [kde-doc-english] Two new files in stable-kf5?

2014-09-28 Thread Albert Astals Cid
El Diumenge, 28 de setembre de 2014, a les 15:15:20, Luigi Toscano va escriure: > Antoni Bella Pérez ha scritto: > > Hi > > > > I not found these two translations in the trunk-kf5 branch. > > > > kde-workspace/desktop_kdelibs_kfilemetadata.po > > kde-workspace/libkonq.po > > > > As a tr

Re: [kde-doc-english] Two new files in stable-kf5?

2014-09-28 Thread Luigi Toscano
Antoni Bella Pérez ha scritto: > > Hi > > I not found these two translations in the trunk-kf5 branch. > > kde-workspace/desktop_kdelibs_kfilemetadata.po > kde-workspace/libkonq.po > > As a translator, this seems strange. Redirecting to the appropriate lists... Ciao -- Luigi __

Extension to standalone mode of plasma shell

2014-09-28 Thread Bhushan Shah
Hello folks, Since standalone mode for Plasma shell is merged [1] I wanted to add one more extension to it, my idea is shell packages announce that they can be used as standalone applications in their metadata.desktop, like plasma-mediacenter shell package will define this in its metadata.desktop

Re: Review Request 119764: Fix BUG#105797: inappropriate fontconfig settings are saved when kcontrol/fonts is shown and no way to revert them

2014-09-28 Thread Fuminobu TAKEYAMA
> On 9月 19, 2014, 11 p.m., Eike Hein wrote: > > Makes sense to me and seems to work well in testing. > > Eike Hein wrote: > Fuminobu, do you need someone to commit this for you? Yes, I don't have any commit rights for KDE repositories. (This is the first change) - Fuminobu

Re: Review Request 119764: Fix BUG#105797: inappropriate fontconfig settings are saved when kcontrol/fonts is shown and no way to revert them

2014-09-28 Thread Eike Hein
> On Sept. 19, 2014, 2 p.m., Eike Hein wrote: > > Makes sense to me and seems to work well in testing. Fuminobu, do you need someone to commit this for you? - Eike --- This is an automatically generated e-mail. To reply, visit: https://