> On Sept. 28, 2014, 4:24 nachm., David Edmundson wrote: > > applets/systemtray/plugin/protocols/dbussystemtray/dbussystemtraytask.cpp, > > line 423 > > <https://git.reviewboard.kde.org/r/120407/diff/1/?file=315614#file315614line423> > > > > In the case that we set a blank title but a valid title with this patch > > we end up not setting the subtitle. > > > > Is that deliberate?
If both title and subtitle are empty, the tooltip would look broken (just an empty window, maybe with an icon) and then we fall back to just showing the app name as title. If either of title and subtitle is not empty, then we show it as intended (even if title is empty and subtitle is not) - Kai Uwe ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120407/#review67571 ----------------------------------------------------------- On Sept. 28, 2014, 4:06 nachm., Kai Uwe Broulik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/120407/ > ----------------------------------------------------------- > > (Updated Sept. 28, 2014, 4:06 nachm.) > > > Review request for Plasma. > > > Bugs: 337710 > https://bugs.kde.org/show_bug.cgi?id=337710 > > > Repository: plasma-workspace > > > Description > ------- > > Since the SNI spec does not requires you to provide a tooltip, this patch > makes the tooltip show the application icon and name in case no tooltip is > provided. This also restores Plasma 4.x behavior afaict. > > > Diffs > ----- > > applets/systemtray/plugin/protocols/dbussystemtray/dbussystemtraytask.cpp > 14458e9 > > Diff: https://git.reviewboard.kde.org/r/120407/diff/ > > > Testing > ------- > > - Plugged in and out SD card, devicenotifier updated its icon accordingly > - Mousewheel'd kmix, tooltip text was updated properly > - Steam tooltip now has icon and text > > > File Attachments > ---------------- > > Steam tooltip > > https://git.reviewboard.kde.org/media/uploaded/files/2014/09/28/ebd6683d-b47b-4c06-9cc2-afbbfd8da57a__steamtooltip.png > > > Thanks, > > Kai Uwe Broulik > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
