Re: Review Request 118914: [klipper] Fix memory leaks

2014-08-26 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118914/ --- (Updated Aug. 27, 2014, 8:56 a.m.) Status -- This change has been di

Re: Re: VDG suggestions and wishes about the system tray

2014-08-26 Thread Martin Gräßlin
On Wednesday 27 August 2014 06:02:11 Philipp Stefan wrote: > >> If the status notifiers are used like we intend them to, then the > >> "passive" status really does not provide any benefit for the user any > >> more. For example, if a music player idles, because the playlist has > >> ended, then th

Re: Review Request 119943: plasma windowed and associated runner back

2014-08-26 Thread Bhushan Shah
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119943/#review65328 --- plasma-windowed/main.cpp

Re: VDG suggestions and wishes about the system tray

2014-08-26 Thread Philipp Stefan
On 27.08.2014 03:24, Eike Hein wrote: On August 26, 2014 10:58:39 PM CEST, Eike Hein wrote: Except sometimes you *want* to hide things and remove them >from your immediate attention. It's a "I know where I put it" kind of thing. As a side note: Many use cases of virtual desktops and activit

Re: VDG suggestions and wishes about the system tray

2014-08-26 Thread Philipp Stefan
On 26.08.2014 22:58, Eike Hein wrote: On 26.08.2014 22:35, Philipp Stefan wrote: Hmm, we felt that these applications should not be hidden from the user. When a user e.g. uses KTorrent and closes the window while it is only seeding, there's no telling that the application is still running, unle

Re: VDG suggestions and wishes about the system tray

2014-08-26 Thread Eike Hein
On August 26, 2014 10:58:39 PM CEST, Eike Hein wrote: >Except sometimes you *want* to hide things and remove them >from your immediate attention. It's a "I know where I put >it" kind of thing. As a side note: Many use cases of virtual desktops and activities come down to this as well, as do Yak

Re: Review Request 119927: Port systemloadviewer plasmoid

2014-08-26 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119927/#review65326 --- Ship it! applets/systemloadviewer/package/contents/ui/Condit

Re: Review Request 119927: Port systemloadviewer plasmoid

2014-08-26 Thread Martin Yrjölä
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119927/ --- (Updated Aug. 26, 2014, 9:43 p.m.) Review request for Plasma and David Ed

Re: Request: better override functionality in locale settings

2014-08-26 Thread Martin Klapetek
Hey, thanks for getting in touch. Let me give you a little back story. In KDE4 we used to have our own "layer" of formatting. It was called KLocale and was part of kdelibs, aka the KDE Platform. This was very powerful and allowed doing exactly the thing you describe. Now with the KDE Frameworks

Re: Review Request 118406: Notify the user if the location containing the media is inaccessible.

2014-08-26 Thread R.Harish Navnit
> On Aug. 26, 2014, 5:35 p.m., Sinny Kumari wrote: > > I am assunimg that you will do remaining error handling fix in next patch > > like codec missing, inaccessible media played from media browser Yes, next patch should fix all those. Can this change be comitted on my behalf ? Thanks. - R.

Re: VDG suggestions and wishes about the system tray

2014-08-26 Thread Eike Hein
On 26.08.2014 22:35, Philipp Stefan wrote: Hmm, we felt that these applications should not be hidden from the user. When a user e.g. uses KTorrent and closes the window while it is only seeding, there's no telling that the application is still running, unless of course you check the popup. Ex

Re: VDG suggestions and wishes about the system tray

2014-08-26 Thread Philipp Stefan
On 26.08.2014 22:00, Eike Hein wrote: On 26.08.2014 21:26, Philipp Stefan wrote: This would, of course, break some applications like KTorrent. How would it behave ideally? When you open KTorren and there are no torrents configured there should not be an indicator as the applications simply doe

Re: VDG suggestions and wishes about the system tray

2014-08-26 Thread Marco Martin
On Tuesday 26 August 2014, Eike Hein wrote: > On 26.08.2014 21:26, Philipp Stefan wrote: > > This would, of course, break some applications like KTorrent. How would > > it behave ideally? When you open KTorren and there are no torrents > > configured there should not be an indicator as the applicat

Re: VDG suggestions and wishes about the system tray

2014-08-26 Thread Eike Hein
On 26.08.2014 21:26, Philipp Stefan wrote: This would, of course, break some applications like KTorrent. How would it behave ideally? When you open KTorren and there are no torrents configured there should not be an indicator as the applications simply does nothing for now (passive). As soon as

Re: Request: better override functionality in locale settings

2014-08-26 Thread Christoph Feck
On Tuesday 26 August 2014 19:04:10 Matthew Ruffalo wrote: > I searched the bug tracker for anything related to this and only > found https://bugs.kde.org/show_bug.cgi?id=337563 It is already reported as bug 337573. But even if you did not find it, in the future please do not report it here but on

Jenkins build became unstable: plasma-workspace_master_qt5 #783

2014-08-26 Thread KDE CI System
See ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 119946: Wrap the desktop alternatives UI in a dialog

2014-08-26 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119946/ --- (Updated Aug. 26, 2014, 7:46 p.m.) Status -- This change has been ma

Re: Review Request 119944: Remove UI assumptions about the alternatives dialog

2014-08-26 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119944/ --- (Updated Aug. 26, 2014, 7:45 p.m.) Status -- This change has been ma

Re: Review Request 119942: give the applet alternatives QML file an entry

2014-08-26 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119942/ --- (Updated Aug. 26, 2014, 7:44 p.m.) Status -- This change has been ma

Re: Review Request 119942: give the applet alternatives QML file an entry

2014-08-26 Thread Aaron J. Seigo
> On Aug. 26, 2014, 5:40 p.m., Marco Martin wrote: > > src/plasma/private/packages.cpp, line 278 > > > > > > maybe going even more explicit and giving its own subdicrectory too? > > (i'm fine with either) A sub

Re: Review Request 119946: Wrap the desktop alternatives UI in a dialog

2014-08-26 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119946/#review65314 --- Ship it! Ship It! - Marco Martin On Aug. 26, 2014, 7:39 p.

Re: Review Request 119946: Wrap the desktop alternatives UI in a dialog

2014-08-26 Thread Aaron J. Seigo
> On Aug. 26, 2014, 5:53 p.m., Marco Martin wrote: > > desktoppackage/contents/explorer/AppletAlternatives.qml, line 41 > > > > > > omg, tabs? :p I'm not seeing any tabs there in the diff. The arrows just mean th

Re: Review Request 119946: Wrap the desktop alternatives UI in a dialog

2014-08-26 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119946/ --- (Updated Aug. 26, 2014, 7:39 p.m.) Review request for Plasma. Repositor

Re: Review Request 119946: Wrap the desktop alternatives UI in a dialog

2014-08-26 Thread Aaron J. Seigo
> On Aug. 26, 2014, 5:49 p.m., David Edmundson wrote: > > desktoppackage/contents/explorer/AppletAlternatives.qml, line 34 > > > > > > Why redeclare the property? > > Marco Martin wrote: > ah, yes, didn't see

VDG suggestions and wishes about the system tray

2014-08-26 Thread Philipp Stefan
Hello everyone, the VDG told me to take a look at the system tray after the 5.0 releases, because even though it's a huge step forward, we felt that there are some inconsistencies in how it behaves. My task was to identify these issues and come up with possible solutions. We talked about them

Re: Review Request 119947: Re-enable build of SVG thumbnailer

2014-08-26 Thread Hrvoje Senjan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119947/ --- (Updated Aug. 26, 2014, 7:20 p.m.) Status -- This change has been ma

Re: Review Request 119947: Re-enable build of SVG thumbnailer

2014-08-26 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119947/#review65309 --- Ship it! Ship It! - David Edmundson On Aug. 26, 2014, 6:40

Re: Review Request 119945: Dialog: Simplify handling of min/max width/height changed

2014-08-26 Thread Marco Martin
> On Aug. 26, 2014, 6:43 p.m., Marco Martin wrote: > > src/plasmaquick/dialog.cpp, line 311 > > > > > > instead of disconnecting and reconnecting, you can also just block and > > reenable signals on the object >

Re: Review Request 119945: Dialog: Simplify handling of min/max width/height changed

2014-08-26 Thread David Edmundson
> On Aug. 26, 2014, 6:43 p.m., Marco Martin wrote: > > src/plasmaquick/dialog.cpp, line 311 > > > > > > instead of disconnecting and reconnecting, you can also just block and > > reenable signals on the object

Re: Review Request 119946: Wrap the desktop alternatives UI in a dialog

2014-08-26 Thread David Edmundson
> On Aug. 26, 2014, 5:49 p.m., David Edmundson wrote: > > desktoppackage/contents/explorer/AppletAlternatives.qml, line 131 > > > > > > Why do we need this? > > (and if we do need it, it should go on the Swit

Re: Review Request 119945: Dialog: Simplify handling of min/max width/height changed

2014-08-26 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119945/#review65304 --- didn't make more tests, but what i think it's happening is La

Review Request 119947: Re-enable build of SVG thumbnailer

2014-08-26 Thread Hrvoje Senjan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119947/ --- Review request for KDE Frameworks and Plasma. Repository: kio-extras De

Re: Review Request 119946: Wrap the desktop alternatives UI in a dialog

2014-08-26 Thread Marco Martin
> On Aug. 26, 2014, 5:49 p.m., David Edmundson wrote: > > desktoppackage/contents/explorer/AppletAlternatives.qml, line 131 > > > > > > Why do we need this? > > (and if we do need it, it should go on the Swit

Re: Review Request 119946: Wrap the desktop alternatives UI in a dialog

2014-08-26 Thread Marco Martin
> On Aug. 26, 2014, 5:49 p.m., David Edmundson wrote: > > desktoppackage/contents/explorer/AppletAlternatives.qml, line 131 > > > > > > Why do we need this? > > (and if we do need it, it should go on the Swit

Re: Review Request 119946: Wrap the desktop alternatives UI in a dialog

2014-08-26 Thread David Edmundson
> On Aug. 26, 2014, 5:49 p.m., David Edmundson wrote: > > desktoppackage/contents/explorer/AppletAlternatives.qml, line 131 > > > > > > Why do we need this? > > (and if we do need it, it should go on the Swit

Re: Review Request 119945: Dialog: Simplify handling of min/max width/height changed

2014-08-26 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119945/#review65300 --- here seems to break the default size of the calendar and systr

Re: Review Request 119946: Wrap the desktop alternatives UI in a dialog

2014-08-26 Thread Marco Martin
> On Aug. 26, 2014, 5:49 p.m., David Edmundson wrote: > > desktoppackage/contents/explorer/AppletAlternatives.qml, line 131 > > > > > > Why do we need this? > > (and if we do need it, it should go on the Swit

Re: Review Request 119946: Wrap the desktop alternatives UI in a dialog

2014-08-26 Thread Marco Martin
> On Aug. 26, 2014, 5:49 p.m., David Edmundson wrote: > > desktoppackage/contents/explorer/AppletAlternatives.qml, line 34 > > > > > > Why redeclare the property? ah, yes, didn't see it, it shouldn't redefine it

Re: Review Request 119946: Wrap the desktop alternatives UI in a dialog

2014-08-26 Thread David Edmundson
> On Aug. 26, 2014, 5:49 p.m., David Edmundson wrote: > > desktoppackage/contents/explorer/AppletAlternatives.qml, line 131 > > > > > > Why do we need this? > > (and if we do need it, it should go on the Swit

Re: Review Request 119944: Remove UI assumptions about the alternatives dialog

2014-08-26 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119944/#review65296 --- Ship it! instancing the Dialog from QML rather than having it

Re: Review Request 119946: Wrap the desktop alternatives UI in a dialog

2014-08-26 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119946/#review65295 --- Ship it! (as an extra note for other reading it: this depends

Re: Review Request 119946: Wrap the desktop alternatives UI in a dialog

2014-08-26 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119946/#review65293 --- desktoppackage/contents/explorer/AppletAlternatives.qml

Re: Review Request 119942: give the applet alternatives QML file an entry

2014-08-26 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119942/#review65294 --- Ship it! src/plasma/private/packages.cpp

Review Request 119946: Wrap the desktop alternatives UI in a dialog

2014-08-26 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119946/ --- Review request for Plasma. Repository: plasma-desktop Description -

Review Request 119944: Remove UI assumptions about the alternatives dialog

2014-08-26 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119944/ --- Review request for Plasma. Repository: plasma-workspace Description ---

Re: Review Request 118406: Notify the user if the location containing the media is inaccessible.

2014-08-26 Thread Sinny Kumari
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118406/#review65292 --- Ship it! I am assunimg that you will do remaining error handl

Review Request 119945: Dialog: Simplify handling of min/max width/height changed

2014-08-26 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119945/ --- Review request for Plasma. Repository: plasma-framework Description ---

Review Request 119943: plasma windowed and associated runner back

2014-08-26 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119943/ --- Review request for Plasma. Repository: plasma-workspace Description ---

Review Request 119942: give the applet alternatives QML file an entry

2014-08-26 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119942/ --- Review request for KDE Frameworks and Plasma. Repository: plasma-framewor

Re: Request: better override functionality in locale settings

2014-08-26 Thread Matthew Ruffalo
Clarification: On 08/26/2014 01:04 PM, Matthew Ruffalo wrote: > would stop me from using Plasma 5. Are there any plans to change the > behavior/appearance of this settings applet? This functionality would *not* stop me from using Plasma 5 -- it's a fantastic piece of work. It would only be a minor

Request: better override functionality in locale settings

2014-08-26 Thread Matthew Ruffalo
Hello- I've been a long-time KDE user, and I must say that Plasma 5 looks *great*. Everything looks very polished and I'm looking forward to using it on a stable Linux distribution. In all of my usage of KDE, I've always greatly appreciated how customizable the locale settings are. I live in the

Merging bug fixes back into master

2014-08-26 Thread David Edmundson
If you make a change in Plasma/5.0 that should also be in master, could you merge the branches soon after committing. It's a lot harder if someone has to deal with 10 changes and conflicts at once and has to look up what each change is. Thanks David ___

Re: Review Request 119794: Add button to change keyboard layout in the lockscreen

2014-08-26 Thread Dan Vrátil
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119794/ --- (Updated Aug. 26, 2014, 2:44 p.m.) Status -- This change has been ma

Re: Review Request 119794: Add button to change keyboard layout in the lockscreen

2014-08-26 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119794/#review65281 --- Ship it! Close 338518 when you submit this. - David Edmundso

Jenkins build is back to stable : plasma-workspace_master_qt5 #778

2014-08-26 Thread KDE CI System
See ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 119866: Thumbnails in Klipper

2014-08-26 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119866/#review65271 --- applets/clipboard/contents/ui/ClipboardItemDelegate.qml

Jenkins build became unstable: plasma-workspace_master_qt5 #777

2014-08-26 Thread KDE CI System
See ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Jenkins build is back to normal : plasma-desktop_master_qt5 #587

2014-08-26 Thread KDE CI System
See ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel