> On Aug. 26, 2014, 5:49 p.m., David Edmundson wrote: > > desktoppackage/contents/explorer/AppletAlternatives.qml, line 131 > > <https://git.reviewboard.kde.org/r/119946/diff/1/?file=307712#file307712line131> > > > > Why do we need this? > > (and if we do need it, it should go on the Switch button too)
Edit: I see why we're using it now. Should have read the other patch first. It does need adding to the other button, but this whole thing isn't ideal. It means we have to rely on the Alternatives.qml having magic undocumented properties. - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119946/#review65293 ----------------------------------------------------------- On Aug. 26, 2014, 5:37 p.m., Aaron J. Seigo wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119946/ > ----------------------------------------------------------- > > (Updated Aug. 26, 2014, 5:37 p.m.) > > > Review request for Plasma. > > > Repository: plasma-desktop > > > Description > ------- > > Following up on the changes to plasmashell, the dialog needs to used from the > QML in the shell package. > > > Diffs > ----- > > desktoppackage/contents/explorer/AppletAlternatives.qml > de99b1ca370c819687230c1bcd54d2839b08dab9 > > Diff: https://git.reviewboard.kde.org/r/119946/diff/ > > > Testing > ------- > > Used Plasma Desktop with this shell package. > > > Thanks, > > Aaron J. Seigo > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
