Re: Review Request 119916: Make the notification popup higher when 3 actions are present

2014-08-23 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119916/#review65108 --- Ship it! One monsterous bug below. Make sure to fix it. app

Re: Review Request 119916: Make the notification popup higher when 3 actions are present

2014-08-23 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119916/ --- (Updated Aug. 24, 2014, 1:19 a.m.) Review request for Plasma. Repositor

Review Request 119916: Make the notification popup higher when 3 actions are present

2014-08-23 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119916/ --- Review request for Plasma. Repository: plasma-workspace Description ---

Re: Review Request 119716: Handle the Return key on logout screen

2014-08-23 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119716/ --- (Updated Aug. 23, 2014, 10:33 p.m.) Status -- This change has been m

Re: Review Request 119721: Don't explicitly set a height on button in notification delegate.

2014-08-23 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119721/#review65106 --- Ship it! Ship It! - Martin Klapetek On Aug. 11, 2014, 9:46

Re: Review Request 112208: KMix qml applet

2014-08-23 Thread Christian Esken
> On Aug. 23, 2014, 5:58 p.m., Mark Gaiser wrote: > > My suggestion: just push this if there are no major objections since doing > > that now will have some benefits: > > - It is in time for plasma 5.1 > > - You get some more exposure of users/devs testing it besides just you and > > the few th

Re: Review Request 112208: KMix qml applet

2014-08-23 Thread Marco Martin
> On Ago. 23, 2014, 5:58 p.m., Mark Gaiser wrote: > > My suggestion: just push this if there are no major objections since doing > > that now will have some benefits: > > - It is in time for plasma 5.1 > > - You get some more exposure of users/devs testing it besides just you and > > the few th

Re: Review Request 112208: KMix qml applet

2014-08-23 Thread Mark Gaiser
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/112208/#review65100 --- My suggestion: just push this if there are no major objections

Re: Review Request 119721: Don't explicitly set a height on button in notification delegate.

2014-08-23 Thread David Edmundson
> On Aug. 11, 2014, 9:35 p.m., Martin Klapetek wrote: > > Can you post a screenshot of a notification with three actions? > > Martin Klapetek wrote: > Note that the button still /has/ enough space for the text to fit in, it > is just ridiculously padded from top. > > David Edmundson wrote:

Re: Review Request 119524: Force OpenGLES if on Qt 5.4

2014-08-23 Thread David Edmundson
> On Aug. 11, 2014, 6:35 a.m., Martin Gräßlin wrote: > > I highly suggest to revert this change. Enforcing GLES means limiting to > > GLES (it's a subset after all) and also not all drivers do support GLES - > > that's still the smaller part. We are calling for lots of trouble if we go > > thi

Re: Review Request 119524: Force OpenGLES if on Qt 5.4

2014-08-23 Thread Alexander Richardson
> On Aug. 11, 2014, 8:35 vorm., Martin Gräßlin wrote: > > I highly suggest to revert this change. Enforcing GLES means limiting to > > GLES (it's a subset after all) and also not all drivers do support GLES - > > that's still the smaller part. We are calling for lots of trouble if we go > > th

Review Request 119913: Force creation of a OpenGL core context

2014-08-23 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119913/ --- Review request for Plasma. Repository: plasma-workspace Description ---