> On Aug. 11, 2014, 9:35 p.m., Martin Klapetek wrote: > > Can you post a screenshot of a notification with three actions? > > Martin Klapetek wrote: > Note that the button still /has/ enough space for the text to fit in, it > is just ridiculously padded from top. > > David Edmundson wrote: > Bah. It doesn't fit. > > >Note that the button still /has/ enough space for the text to fit in > > On breeze, maybe. But that's not reliable; and it's ignoring theme hints.
This is still a trillion times better than the current state. Can I ship it please. - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119721/#review64329 ----------------------------------------------------------- On Aug. 11, 2014, 7:46 p.m., David Edmundson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119721/ > ----------------------------------------------------------- > > (Updated Aug. 11, 2014, 7:46 p.m.) > > > Review request for Plasma. > > > Repository: plasma-workspace > > > Description > ------- > > Don't explicitly set a height on button in notification delegate. > > Setting a random value on a button means that it's smaller than the button > wants to be and text falls out. The default is set by the button and is > correct. > > It's not up to the controls to handle being resized; it'd be like complaining > at LineEdit if you set the height to 2px tall and you can't read the text. > > > Diffs > ----- > > applets/notifications/package/contents/ui/NotificationPopup.qml 489fbd1 > > Diff: https://git.reviewboard.kde.org/r/119721/diff/ > > > Testing > ------- > > > Thanks, > > David Edmundson > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
