Re: Wayland protocols

2014-08-19 Thread Ivan Čukić
> > I'm not familiar with kactivities but a grep for winId reveals that it > > is used by ResourceInstancePrivate::registerResourceEvent, but I don't > > understand what does it need to communicate to the compositor. I don't know whether this should be communicated to the compositor or what, jus

Re: Re: Wayland protocols

2014-08-19 Thread Martin Gräßlin
On Tuesday 19 August 2014 17:00:48 you wrote: > 2014-08-18 9:37 GMT+02:00 Ivan Čukić : > > On Monday 18 August 2014 09:22:03 Martin Gräßlin wrote: > >> On Monday 18 August 2014 09:02:07 Pier Luigi wrote: > >> > > Activities should probably be also exposed to the kf5_window > >> > > interface? > >>

Re: Review Request 112208: KMix qml applet

2014-08-19 Thread Christian Esken
> On Aug. 12, 2014, 11:19 a.m., Christian Esken wrote: > > For me it looks fine, with some questions: > > 1) Is this completely decoupled from KMix? I do not see a "open mixer" to > > open the main application. > > 2) Is it supposed to be integrated in KMix > > 3) In general, the question is how

Re: Review Request 119846: qtcontrols port for checkbox and radiobutton

2014-08-19 Thread Marco Martin
> On Aug. 19, 2014, 7:43 p.m., David Edmundson wrote: > > src/declarativeimports/plasmacomponents/qml/styles/CheckBoxStyle.qml, line > > 51 > > > > > > checked isn't a boolean, it's an enum of the checked, partia

Re: Kioslave repos

2014-08-19 Thread David Faure
On Tuesday 01 July 2014 22:25:15 Jonathan Riddell wrote: > On Tue, Jul 01, 2014 at 11:25:11PM +0200, David Faure wrote: > > On Sunday 27 April 2014 19:35:37 I wrote: > > > > * place that repo in kde/ or kde/ in the projects.kde.org > > > > hierarchy, so that it gets released with the KDE Applicatio

Re: Review Request 119846: qtcontrols port for checkbox and radiobutton

2014-08-19 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119846/#review64882 --- src/declarativeimports/plasmacomponents/qml/styles/CheckBoxSt

Review Request 119846: qtcontrols port for checkbox and radiobutton

2014-08-19 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119846/ --- Review request for KDE Frameworks and Plasma. Repository: plasma-framewor

Re: Wayland protocols

2014-08-19 Thread Pier Luigi Fiorini
2014-08-18 9:37 GMT+02:00 Ivan Čukić : > On Monday 18 August 2014 09:22:03 Martin Gräßlin wrote: >> On Monday 18 August 2014 09:02:07 Pier Luigi wrote: >> > > Activities should probably be also exposed to the kf5_window interface? >> > >> > What do you need for activities? >> >> @Ivan: that falls i

Re: Review Request 119842: use standard way to set plasma version data

2014-08-19 Thread Jonathan Riddell
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119842/ --- (Updated Aug. 19, 2014, 1:54 p.m.) Status -- This change has been ma

Re: Wayland protocols

2014-08-19 Thread Pier Luigi Fiorini
2014-08-15 10:45 GMT+02:00 Marco Martin : > On Friday 15 August 2014, Martin Gräßlin wrote: > >> > [1] https://github.com/plfiorini/protocols >> > [2] >> > http://lists.freedesktop.org/archives/wayland-devel/2014-July/016056.html >> >> after going through all interfaces I think we can kill the wind

Re: Review Request 119842: use standard way to set plasma version data

2014-08-19 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119842/#review64851 --- Ship it! Ship It! - Aleix Pol Gonzalez On Aug. 19, 2014, 1

Re: Review Request 119842: use standard way to set plasma version data

2014-08-19 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119842/#review64850 --- Ship it! Ship It! - David Edmundson On Aug. 19, 2014, 1:41

Re: Review Request 119841: standardise the way version numbers are set in plasma

2014-08-19 Thread Jonathan Riddell
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119841/ --- (Updated Aug. 19, 2014, 1:48 p.m.) Status -- This change has been ma

Review Request 119842: use standard way to set plasma version data

2014-08-19 Thread Jonathan Riddell
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119842/ --- Review request for Plasma. Repository: kinfocenter Description ---

Re: Review Request 119841: standardise the way version numbers are set in plasma

2014-08-19 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119841/#review64846 --- Ship it! Ship It! - Aleix Pol Gonzalez On Aug. 19, 2014, 1

Re: Review Request 119604: Fix build of KDELibs4Support, qMessageFormatString

2014-08-19 Thread Aleix Pol Gonzalez
> On Aug. 19, 2014, 9:46 a.m., Hrvoje Senjan wrote: > > i don't know is there maybe a 'better' solution; i know Qt changes internal > > API, but we still have a BC breakage: > > undefined symbol: > > _Z20qMessageFormatString9QtMsgTypeRK18QMessageLogContextRK7QString > > Aleix Pol Gonzalez wro

Re: Review Request 119841: standardise the way version numbers are set in plasma

2014-08-19 Thread Jonathan Riddell
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119841/ --- (Updated Aug. 19, 2014, 1:07 p.m.) Review request for Plasma. Repositor

Re: Review Request 119841: standardise the way version numbers are set in plasma

2014-08-19 Thread Jonathan Riddell
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119841/ --- (Updated Aug. 19, 2014, 1:01 p.m.) Review request for Plasma. Changes -

Re: Review Request 119604: Fix build of KDELibs4Support, qMessageFormatString

2014-08-19 Thread Hrvoje Senjan
> On Aug. 19, 2014, 11:46 a.m., Hrvoje Senjan wrote: > > i don't know is there maybe a 'better' solution; i know Qt changes internal > > API, but we still have a BC breakage: > > undefined symbol: > > _Z20qMessageFormatString9QtMsgTypeRK18QMessageLogContextRK7QString > > Aleix Pol Gonzalez wr

Re: Review Request 119837: Fix keyboard navigation in lockscreen

2014-08-19 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119837/ --- (Updated Aug. 19, 2014, 11:49 a.m.) Status -- This change has been m

Re: Review Request 119837: Fix keyboard navigation in lockscreen

2014-08-19 Thread Eike Hein
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119837/#review64839 --- Ship it! Ship It! - Eike Hein On Aug. 18, 2014, 11:08 p.m.

Re: Review Request 119813: Show activity-linked files in folder view option

2014-08-19 Thread Sebastian Kügler
On Monday, August 18, 2014 18:21:39 Eike Hein wrote: > ^ That seems better to me. I mean it still means having a known list > somewhere (the hints) but the process for extending/maintaining that list > seems reasonable (-> community discourse). I imagine if we had something > like Python's PEP proc

Re: Review Request 119841: standardise the way version numbers are set in plasma

2014-08-19 Thread Jonathan Riddell
> On Aug. 19, 2014, 11:10 a.m., Aleix Pol Gonzalez wrote: > > CMakeLists.txt, line 5 > > > > > > Why do you need to have major, minor and patch separately? > > > > Also we can probably use the project(VERS

Re: Review Request 119841: standardise the way version numbers are set in plasma

2014-08-19 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119841/#review64833 --- CMakeLists.txt

Re: Wayland protocols

2014-08-19 Thread Pier Luigi Fiorini
On Tuesday 19 August 2014 11:05:58 Martin Gräßlin wrote: > On Tuesday 19 August 2014 10:59:09 Pier Luigi Fiorini wrote: > > On Friday 15 August 2014 10:42:28 Marco Martin wrote: > > > On Friday 15 August 2014, Martin Gräßlin wrote: > > > > another general note: I'm not sure about exposing "kf5" in

Review Request 119841: standardise the way version numbers are set in plasma

2014-08-19 Thread Jonathan Riddell
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119841/ --- Review request for Plasma. Repository: systemsettings Description -

Re: Review Request 119604: Fix build of KDELibs4Support, qMessageFormatString

2014-08-19 Thread Aleix Pol Gonzalez
> On Aug. 19, 2014, 9:46 a.m., Hrvoje Senjan wrote: > > i don't know is there maybe a 'better' solution; i know Qt changes internal > > API, but we still have a BC breakage: > > undefined symbol: > > _Z20qMessageFormatString9QtMsgTypeRK18QMessageLogContextRK7QString Well, you shouldn't be get

[kdeplasma-addons] /: Merge branch 'frameworks'

2014-08-19 Thread David Edmundson
Git commit 70a5a2bef954a86c52c6fbaa54433d1f0453c42e by David Edmundson. Committed on 19/08/2014 at 09:55. Pushed by davidedmundson into branch 'master'. Merge branch 'frameworks' All new commits in plasma-addons should happen on the master branch now please. CC: plasma-devel@kde.org M +0-1

Re: Review Request 119604: Fix build of KDELibs4Support, qMessageFormatString

2014-08-19 Thread Hrvoje Senjan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119604/#review64829 --- i don't know is there maybe a 'better' solution; i know Qt cha

Re: Re: Wayland protocols

2014-08-19 Thread Martin Gräßlin
On Tuesday 19 August 2014 11:23:11 you wrote: > On Tuesday 19 August 2014 11:03:48 Martin Gräßlin wrote: > > On Tuesday 19 August 2014 10:51:43 Pier Luigi Fiorini wrote: > > > *) ksmserver is a Wayland client that binds kf5_shell > > > *) ksmserver is asked to lock (via loginctl, plasmoid or contex

Re: Wayland protocols

2014-08-19 Thread Pier Luigi Fiorini
On Tuesday 19 August 2014 11:03:48 Martin Gräßlin wrote: > On Tuesday 19 August 2014 10:51:43 Pier Luigi Fiorini wrote: > > > > *) ksmserver is a Wayland client that binds kf5_shell > > *) ksmserver is asked to lock (via loginctl, plasmoid or context menu) > > *) ksmserver calls the kf5_shell.lock

Re: Wayland protocols

2014-08-19 Thread Pier Luigi Fiorini
On Friday 15 August 2014 07:51:09 Martin Gräßlin wrote: > dashboard_surface is something I would move from the windoweffects.xml to > the shell.xml. It's more a side-effect that it ended in window effects. Done ___ Plasma-devel mailing list Plasma-devel

Re: Re: Wayland protocols

2014-08-19 Thread Martin Gräßlin
On Tuesday 19 August 2014 10:59:09 Pier Luigi Fiorini wrote: > On Friday 15 August 2014 10:42:28 Marco Martin wrote: > > On Friday 15 August 2014, Martin Gräßlin wrote: > > > another general note: I'm not sure about exposing "kf5" in the interface > > > names. It has nothing to do with frameworks a

Re: Re: Wayland protocols

2014-08-19 Thread Martin Gräßlin
On Tuesday 19 August 2014 10:51:43 Pier Luigi Fiorini wrote: > On Monday 18 August 2014 18:22:42 Martin Gräßlin wrote: > > On Monday 18 August 2014 17:48:03 Pier Luigi wrote: > > > 2014-08-15 7:35 GMT+02:00 Martin Gräßlin : > > > > * concerning the lock/unlock: I would like to have the lock way bet

Re: Wayland protocols

2014-08-19 Thread Pier Luigi Fiorini
On Friday 15 August 2014 10:42:28 Marco Martin wrote: > On Friday 15 August 2014, Martin Gräßlin wrote: > > another general note: I'm not sure about exposing "kf5" in the interface > > names. It has nothing to do with frameworks and I don't expect the > > interface name to change once we introduce

Re: Wayland protocols

2014-08-19 Thread Pier Luigi Fiorini
On Monday 18 August 2014 18:22:42 Martin Gräßlin wrote: > On Monday 18 August 2014 17:48:03 Pier Luigi wrote: > > 2014-08-15 7:35 GMT+02:00 Martin Gräßlin : > > > * concerning the lock/unlock: I would like to have the lock way better > > > integrated in KWin. That is KWin should be responsible for

Re: Review Request 112208: KMix qml applet

2014-08-19 Thread Marco Martin
> On Ago. 12, 2014, 11:19 a.m., Christian Esken wrote: > > For me it looks fine, with some questions: > > 1) Is this completely decoupled from KMix? I do not see a "open mixer" to > > open the main application. > > 2) Is it supposed to be integrated in KMix > > 3) In general, the question is how

Re: Review Request 112208: KMix qml applet

2014-08-19 Thread Diego Casella
> On Aug. 12, 2014, 11:19 a.m., Christian Esken wrote: > > For me it looks fine, with some questions: > > 1) Is this completely decoupled from KMix? I do not see a "open mixer" to > > open the main application. > > 2) Is it supposed to be integrated in KMix > > 3) In general, the question is how

Re: Review Request 112208: KMix qml applet

2014-08-19 Thread Aaron J. Seigo
> On Aug. 12, 2014, 11:19 a.m., Christian Esken wrote: > > For me it looks fine, with some questions: > > 1) Is this completely decoupled from KMix? I do not see a "open mixer" to > > open the main application. > > 2) Is it supposed to be integrated in KMix > > 3) In general, the question is how

Re: Review Request 119822: QScreen backend for libkscreen

2014-08-19 Thread Martin Gräßlin
> On Aug. 18, 2014, 1:55 p.m., Àlex Fiestas wrote: > > autotests/testqscreenbackend.cpp, line 90 > > > > > > Q_FOREACH or instead of using Qt macros one could use what the language provides: for (const KScreen::

Re: Review Request 119822: QScreen backend for libkscreen

2014-08-19 Thread Ben Cooksley
> On Aug. 18, 2014, 11:55 a.m., Àlex Fiestas wrote: > > autotests/testqscreenbackend.cpp, line 66 > > > > > > If we don't have a config even though we correctly configured the > > backend, should not we fail? a Q

Re: Autostart scripts (ksmserver problem)

2014-08-19 Thread Martin Yrjölä
On Wed, Aug 13, 2014 at 11:01 PM, Martin Yrjölä wrote: > >> hmm, so it seems the best option is to Add support for scripts in kinit? >> >> > I submitted a patch to kinit in https://git.reviewboard.kde.org/r/119773/ > . > > David Faure commented that this issue should be solved in the workspace. A