> On Aug. 19, 2014, 9:46 a.m., Hrvoje Senjan wrote: > > i don't know is there maybe a 'better' solution; i know Qt changes internal > > API, but we still have a BC breakage: > > undefined symbol: > > _Z20qMessageFormatString9QtMsgTypeRK18QMessageLogContextRK7QString > > Aleix Pol Gonzalez wrote: > Well, you shouldn't be getting this if you have my patch in. > > Hrvoje Senjan wrote: > the lib is borked with: kdelibs4support HEAD built against Qt 5.3 and > used with Qt 5.4 at runtime
Well there isn't much we can do about that. We shouldn't have used a private symbol. *spank* - Aleix ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119604/#review64829 ----------------------------------------------------------- On Aug. 5, 2014, 10:37 p.m., Aleix Pol Gonzalez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119604/ > ----------------------------------------------------------- > > (Updated Aug. 5, 2014, 10:37 p.m.) > > > Review request for Plasma. > > > Repository: kdelibs4support > > > Description > ------- > > We were using some private API that now it's public, but it got renamed in > the process. > > With this patch, we only fetch the old function name if we're on 5.3, and we > create dummy function with the new name, otherwise. > > > Diffs > ----- > > src/kdecore/kdebug.cpp 1713cad > > Diff: https://git.reviewboard.kde.org/r/119604/diff/ > > > Testing > ------- > > I get to build kdelibs4support. > > > Thanks, > > Aleix Pol Gonzalez > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
