Re: Review Request 119557: use kpluginselector for enabling runners

2014-07-31 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119557/ --- (Updated July 31, 2014, 9:50 p.m.) Review request for Plasma. Changes -

Re: Review Request 119557: use kpluginselector for enabling runners

2014-07-31 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119557/ --- (Updated July 31, 2014, 9:48 p.m.) Review request for Plasma. Repositor

Review Request 119557: use kpluginselector for enabling runners

2014-07-31 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119557/ --- Review request for Plasma. Repository: plasma-desktop Description -

Re: Review Request 119554: Plasmoid initialization, screenForContainment

2014-07-31 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119554/#review63593 --- Ship it! bah, let's try to go for it - Marco Martin On Jul

Re: Review Request 119554: Plasmoid initialization, screenForContainment

2014-07-31 Thread Aleix Pol Gonzalez
> On July 31, 2014, 5:01 p.m., Marco Martin wrote: > > doesn't overlap a bit with Corona::startupCompleted()? No, we need to create the panels before the corona is ready. - Aleix --- This is an automatically generated e-mail. To reply,

Re: Review Request 119554: Plasmoid initialization, screenForContainment

2014-07-31 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119554/#review63579 --- doesn't overlap a bit with Corona::startupCompleted()? - Marc

Re: Review Request 119552: Kdeclarative: Introduce org.kde.kio component

2014-07-31 Thread Marco Martin
> On July 31, 2014, 2:21 p.m., Aleix Pol Gonzalez wrote: > > src/qmlcontrols/kioplugin/kio.cpp, line 33 > > > > > > What about creating a url handler for krun things? > > http://qt-project.org/doc/qt-4.8/qdesk

Review Request 119554: Plasmoid initialization, screenForContainment

2014-07-31 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119554/ --- Review request for Plasma. Bugs: 335710 https://bugs.kde.org/show_bug

Re: Review Request 119552: Kdeclarative: Introduce org.kde.kio component

2014-07-31 Thread Aleix Pol Gonzalez
> On July 31, 2014, 2:21 p.m., Aleix Pol Gonzalez wrote: > > src/qmlcontrols/kioplugin/kio.cpp, line 33 > > > > > > What about creating a url handler for krun things? > > http://qt-project.org/doc/qt-4.8/qdesk

Jenkins build is back to stable : plasma-workspace_master_qt5 #684

2014-07-31 Thread KDE CI System
See ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Jenkins build became unstable: plasma-workspace_master_qt5 #683

2014-07-31 Thread KDE CI System
See ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 119552: Kdeclarative: Introduce org.kde.kio component

2014-07-31 Thread Marco Martin
> On July 31, 2014, 2:21 p.m., Aleix Pol Gonzalez wrote: > > src/qmlcontrols/kioplugin/kio.cpp, line 33 > > > > > > What about creating a url handler for krun things? > > http://qt-project.org/doc/qt-4.8/qdesk

Re: Review Request 119552: Kdeclarative: Introduce org.kde.kio component

2014-07-31 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119552/#review63571 --- src/qmlcontrols/kioplugin/kio.cpp

Re: Review Request 119552: Kdeclarative: Introduce org.kde.kio component

2014-07-31 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119552/#review63570 --- src/qmlcontrols/kioplugin/kio.h

Re: Review Request 119552: Kdeclarative: Introduce org.kde.kio component

2014-07-31 Thread Antonis Tsiapaliokas
> On July 31, 2014, 11:10 a.m., Aleix Pol Gonzalez wrote: > > src/qmlcontrols/kioplugin/kio.cpp, line 33 > > > > > > Why is it better than Qt.openUrl? > > > > And what does this have to do with KIO? > >

Re: Review Request 119451: some machinery for look and feel package

2014-07-31 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119451/ --- (Updated July 31, 2014, 1:53 p.m.) Review request for Plasma. Changes -

Re: Review Request 119535: Move QML bindings for KUser to kdeclarative

2014-07-31 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119535/ --- (Updated July 31, 2014, 1:15 p.m.) Status -- This change has been ma

Re: Review Request 119535: Move QML bindings for KUser to kdeclarative

2014-07-31 Thread Sebastian Kügler
> On July 31, 2014, 12:56 p.m., David Edmundson wrote: > > src/qmlcontrols/kcoreaddons/kuserproxy.cpp, line 128 > > > > > > This is a static method. You don't need to call QHostInfo ctor. Hah, thanks for catchin

Re: Review Request 119535: Move QML bindings for KUser to kdeclarative

2014-07-31 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119535/#review63563 --- Ship it! Good to me too. src/qmlcontrols/kcoreaddons/kuserp

Re: Review Request 119535: Move QML bindings for KUser to kdeclarative

2014-07-31 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119535/#review63555 --- Ship it! I kinda liked the singlethon as well, but seems more

Re: Review Request 119522: readlink fails whens the folder does not exist.

2014-07-31 Thread Rohan Garg
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119522/ --- (Updated July 31, 2014, 11:38 a.m.) Status -- This change has been m

Re: Review Request 119552: Kdeclarative: Introduce org.kde.kio component

2014-07-31 Thread Marco Martin
> On July 31, 2014, 11:10 a.m., Aleix Pol Gonzalez wrote: > > src/qmlcontrols/kioplugin/kio.cpp, line 33 > > > > > > Why is it better than Qt.openUrl? > > > > And what does this have to do with KIO? Qt.o

Re: Review Request 119552: Kdeclarative: Introduce org.kde.kio component

2014-07-31 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119552/#review63550 --- src/qmlcontrols/kioplugin/CMakeLists.txt

Re: Review Request 119552: Kdeclarative: Introduce org.kde.kio component

2014-07-31 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119552/#review63551 --- When I call Qt.openUrlExternally("/home/user/somepicture.jpg")

Review Request 119552: Kdeclarative: Introduce org.kde.kio component

2014-07-31 Thread Antonis Tsiapaliokas
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119552/ --- Review request for Plasma. Repository: kdeclarative Description ---

Re: Review Request 119523: port TextField to QtControls

2014-07-31 Thread Marco Martin
On July 28, 2014, 6:54 p.m., Marco Martin wrote: > > Which methods do we need the inner control for? I saw positionAtPos and > > positionToRectangle, any others? > > Marco Martin wrote: > those two and passwordCharacter > > David Edmundson wrote: > and missing properties are: > >

Re: Review Request 119523: port TextField to QtControls

2014-07-31 Thread David Edmundson
On July 28, 2014, 6:54 p.m., Marco Martin wrote: > > Which methods do we need the inner control for? I saw positionAtPos and > > positionToRectangle, any others? > > Marco Martin wrote: > those two and passwordCharacter > > David Edmundson wrote: > and missing properties are: > >