----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119554/#review63579 -----------------------------------------------------------
doesn't overlap a bit with Corona::startupCompleted()? - Marco Martin On July 31, 2014, 4:54 p.m., Aleix Pol Gonzalez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119554/ > ----------------------------------------------------------- > > (Updated July 31, 2014, 4:54 p.m.) > > > Review request for Plasma. > > > Bugs: 335710 > https://bugs.kde.org/show_bug.cgi?id=335710 > > > Repository: plasma-workspace > > > Description > ------- > > So far, when initializing plasma shell some plasmoids would trigger a warning > in ShellCorona::screenForContainment saying that the requested screen was not > found. > > This patch fixes the issue by introducing the screens to the views list > earlier, this way when screenForContainment is called, we already have the > list initialized. Now the problem is that we get some inconsistencies, > because QApp::processEvents is called from within View::setContainment. This > results in requests to the PlasmaShell on half-baked instances and resulted > in problems. That's why I introduced the loading attribute that wraps > setContainment calls. > > > Diffs > ----- > > shell/shellcorona.cpp 09ef711 > > Diff: https://git.reviewboard.kde.org/r/119554/diff/ > > > Testing > ------- > > PlasmaShell seems to run fine on my system. > > > Thanks, > > Aleix Pol Gonzalez > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
