Re: Review Request 118978: [screenlocker/greeter] Disable session management in the greeter

2014-06-27 Thread Martin Gräßlin
> On June 27, 2014, 11:16 p.m., David Edmundson wrote: > > ksmserver/screenlocker/greeter/main.cpp, line 65 > > > > > > why do we need it here too? Honestly: I do not know. But I once went through KApplication co

Re: KFontInst weird problem

2014-06-27 Thread Marco Martin
On Friday 27 June 2014 23:38:08 you wrote: > On Friday 27 June 2014 23:31:12 David Edmundson wrote: > > So it used to install it's own icons and this was being added to the icons > > path. > > > > We are still installing some custom icons though. Now via > > ecm_install_icons, but I can't remember

Re: KFontInst weird problem

2014-06-27 Thread Marco Martin
On Friday 27 June 2014 23:31:12 David Edmundson wrote: > So it used to install it's own icons and this was being added to the icons > path. > > We are still installing some custom icons though. Now via > ecm_install_icons, but I can't remember that that does. > Can you confirm the icons enable/dis

Re: A slightly different bug search

2014-06-27 Thread David Edmundson
Graph form: https://bugs.kde.org/reports.cgi?product=plasmashell&output=show_chart&datasets=RESOLVED ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: KFontInst weird problem

2014-06-27 Thread David Edmundson
Git blame was a fun adventure ; that line has gone through porting from KGlobal::iconLoader -> kApp -> KIconLoader::global It was added here. commit da2ebfc38b6377d63e86cc45c01df468799ee28c Author: Craig Drummond Date: Fri Dec 1 22:22:19 2006 + In this commit we also see added: +kde4_inst

A slightly different bug search

2014-06-27 Thread Marco Martin
Hi all, Just a little feel-good reminder: https://bugs.kde.org/buglist.cgi?bug_status=RESOLVED&bug_status=CLOSED&list_id=1085145&product=frameworks-plasma&product=plasmashell&query_format=advanced&order=bug_id%20DESC&limit=0 yep, we already fixed 503 bugs in plasma 5. Good job everybody :D -- Ma

Re: Review Request 118978: [screenlocker/greeter] Disable session management in the greeter

2014-06-27 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118978/#review61110 --- ksmserver/screenlocker/greeter/main.cpp

KFontInst weird problem

2014-06-27 Thread Marco Martin
Hi all, little happy question for the weekend: i was curious why loading the font installer kcm breaks all the oxygen icons.. looking at the sources, the suspect is right there in the kcm ctor: KCmFontInst.cpp, line 189 KIconLoader::global()->addAppDir(KFI_NAME); KIconLoader::global()->rec

Re: Review Request 118973: Ensure we mark batteries as connected when the charge is full too

2014-06-27 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118973/#review61107 --- Ship it! Ship It! - Kai Uwe Broulik On June 27, 2014, 11:2

Re: Review Request 118977: KSMServer: Do not autostart files

2014-06-27 Thread Vishesh Handa
> On June 27, 2014, 3:10 p.m., Rohan Garg wrote: > > I applied it locally here and krunner still starts up twice. > > Rohan Garg wrote: > So, krunner starting twice is another bug in session management, but > other apps like konsole only startup once after this patch > > Marco Martin wrote

Re: Review Request 118977: KSMServer: Do not autostart files

2014-06-27 Thread Marco Martin
> On June 27, 2014, 3:10 p.m., Rohan Garg wrote: > > I applied it locally here and krunner still starts up twice. > > Rohan Garg wrote: > So, krunner starting twice is another bug in session management, but > other apps like konsole only startup once after this patch is the rest up to date

Re: Review Request 118977: KSMServer: Do not autostart files

2014-06-27 Thread Rohan Garg
> On June 27, 2014, 8:40 p.m., Rohan Garg wrote: > > I applied it locally here and krunner still starts up twice. So, krunner starting twice is another bug in session management, but other apps like konsole only startup once after this patch - Rohan -

Review Request 118978: [screenlocker/greeter] Disable session management in the greeter

2014-06-27 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118978/ --- Review request for Plasma and Harald Sitter. Bugs: 336793 https://bug

Re: Review Request 118977: KSMServer: Do not autostart files

2014-06-27 Thread Rohan Garg
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118977/#review61099 --- I applied it locally here and krunner still starts up twice.

Review Request 118977: KSMServer: Do not autostart files

2014-06-27 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118977/ --- Review request for Plasma. Bugs: 335878 https://bugs.kde.org/show_bug

Re: Review Request 118975: Shell: Show an OSD for the keyboard brightness

2014-06-27 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118975/ --- (Updated June 27, 2014, 2:48 p.m.) Status -- This change has been ma

Re: Review Request 118975: Shell: Show an OSD for the keyboard brightness

2014-06-27 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118975/#review61098 --- This review has been submitted with commit a03b006c8af098d046

Re: Review Request 118975: Shell: Show an OSD for the keyboard brightness

2014-06-27 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118975/#review61095 --- Ship it! mklapetek is probably busy getting married and thing

Review Request 118975: Shell: Show an OSD for the keyboard brightness

2014-06-27 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118975/ --- Review request for Plasma and Martin Klapetek. Repository: plasma-workspa

Re: Runners KCM

2014-06-27 Thread Marco Martin
On Friday 27 June 2014 15:21:23 Vishesh Handa wrote: > Heys guys > > We need a KCM for the runners, and I've had one ready for sometime but it > requires a considerable amount of visual polish. [1] However, it's been > lying in another branch for too long. > > I'll merge it into master on Monday,

Re: Runners KCM

2014-06-27 Thread Aleix Pol
On Fri, Jun 27, 2014 at 3:21 PM, Vishesh Handa wrote: > Heys guys > > We need a KCM for the runners, and I've had one ready for sometime but it > requires a considerable amount of visual polish. [1] However, it's been > lying in another branch for too long. > > I'll merge it into master on Monday

Runners KCM

2014-06-27 Thread Vishesh Handa
Heys guys We need a KCM for the runners, and I've had one ready for sometime but it requires a considerable amount of visual polish. [1] However, it's been lying in another branch for too long. I'll merge it into master on Monday, and work on the visual improvements till then. I've been in touch

Re: Review Request 118972: Don't have all the Thmeme color properties in the public api

2014-06-27 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118972/#review61086 --- This review has been submitted with commit 18b6d854a01c010fd5

Re: Review Request 118972: Don't have all the Thmeme color properties in the public api

2014-06-27 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118972/ --- (Updated June 27, 2014, 1:09 p.m.) Status -- This change has been ma

Re: Review Request 118972: Don't have all the Thmeme color properties in the public api

2014-06-27 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118972/#review61085 --- This review has been submitted with commit 6c54fb596d96e697b6

Re: Review Request 118972: Don't have all the Thmeme color properties in the public api

2014-06-27 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118972/ --- (Updated June 27, 2014, 1:07 p.m.) Review request for KDE Frameworks and

Re: Review Request 118972: Don't have all the Thmeme color properties in the public api

2014-06-27 Thread Marco Martin
> On June 27, 2014, 12:24 p.m., David Edmundson wrote: > > src/declarativeimports/core/quicktheme.h, line 179 > > > > > > Doesn't redeclaring a signal in a subclass cause a massive warning at > > runtime? > >

Re: Review Request 118972: Don't have all the Thmeme color properties in the public api

2014-06-27 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118972/#review61082 --- Ship it! Concept seems fine in general. Check my comment befo

Review Request 118974: UserAccount KCM: Change the name using the AccountManager

2014-06-27 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118974/ --- Review request for Plasma. Repository: kde-baseapps Description ---

Review Request 118973: Ensure we mark batteries as connected when the charge is full too

2014-06-27 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118973/ --- Review request for Plasma, Solid and Kai Uwe Broulik. Repository: plasma-

Review Request 118972: Don't have all the Thmeme color properties in the public api

2014-06-27 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118972/ --- Review request for KDE Frameworks and Plasma. Repository: plasma-framewor

Fwd: [KDE/Mac] Request to MacBook users

2014-06-27 Thread Marko Käning
Hi Martin, > Am Freitag, 13. Juni 2014, 09.02:55 schrieb Martin Gräßlin: >> Dear MacBook users, >> with the new kglobalaccel we can have multiple global shortcuts for the >> same action. Because of that I would like to map all the special keys for >> Expose, Dashboard, etc from a MacBook to our ma