Re: 5.0 known issues

I see "XEmbed-based systemtray not supported anymore" under "bugs" -- is that really considered a bug (which means it will be fixed)? Should there be a special "not coming back"-like section maybe? Cheers -- Martin Klapetek | KDE Developer ___ Plasma-de

Re: Review Request 118906: Fix dialog's check for isTooltip

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118906/#review60912 --- This review has been submitted with commit dc79190b8d1aa52830

Re: Review Request 118906: Fix dialog's check for isTooltip

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118906/ --- (Updated June 24, 2014, 7:17 p.m.) Status -- This change has been ma

Re: Review Request 118906: Fix dialog's check for isTooltip

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118906/#review60910 --- Ship it! Ship It! - Aleix Pol Gonzalez On June 23, 2014, 5

Re: Review Request 118899: Remove unused dependencies.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118899/ --- (Updated June 24, 2014, 2:13 p.m.) Status -- This change has been ma

Re: Review Request 118899: Remove unused dependencies.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118899/#review60905 --- This review has been submitted with commit 79d59289fc68204a94

5.0 known issues

Hey, I've started a wiki page with known issues in the Plasma 5.0 release. On this page, we can collect issues known with 5.0 and provide possible solutions. I've made a nimble start, please add issues that you think should be communicated clearly to users of 5.0. http://community.kde.org/Plas

Re: Review Request 118899: Remove unused dependencies.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118899/#review60899 --- Ship it! Nice cleanup. Could you just delete the commented li

Re: Review Request 118914: [klipper] Fix memory leaks

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118914/#review60896 --- Ship it! klipper/urlgrabber.cpp

Re: Review Request 118914: [klipper] Fix memory leaks

On June 24, 2014, 12:50 p.m., Martin Gräßlin wrote: > > Option 1: > > you make insert have a HistoryItem return value, for duplicates you return > > the original > > > > Option 2: > > We make history item implicitly shared and stop passing pointers all over > > the place both would be a rat

Re: Review Request 118914: [klipper] Fix memory leaks

> On June 24, 2014, 12:50 p.m., David Edmundson wrote: > > klipper/history.cpp, line 45 > > > > > > You have a potential crash here, the caller now has a dangling pointer. > > > > Klipper::applyClipChange

Re: Review Request 118898: KGamma: Apply user setting at login/startup

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118898/#review60890 --- This review has been submitted with commit 82a264a08c2356f68c

Re: Review Request 118898: KGamma: Apply user setting at login/startup

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118898/ --- (Updated June 24, 2014, 10:58 a.m.) Status -- This change has been m

Re: Review Request 118898: KGamma: Apply user setting at login/startup

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118898/#review60889 --- This review has been submitted with commit abb774fa60709102cc

Re: Review Request 118914: [klipper] Fix memory leaks

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118914/#review60888 --- klipper/history.cpp

Re: Review Request 118898: KGamma: Apply user setting at login/startup

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118898/#review60887 --- Ship it! Cool, this looks much less intrusive. - Sebastian K

Review Request 118914: [klipper] Fix memory leaks

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118914/ --- Review request for Plasma. Repository: plasma-workspace Description ---

Re: Review Request 118906: Fix dialog's check for isTooltip

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118906/#review60886 --- Ship it! Ship It! - Marco Martin On June 23, 2014, 5:26 p.

Re: Review Request 118898: KGamma: Apply user setting at login/startup

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118898/ --- (Updated June 24, 2014, 10:04 a.m.) Review request for kde-workspace, KDE

Re: Review Request 118898: KGamma: Apply user setting at login/startup

> On June 24, 2014, 12:41 a.m., Christoph Feck wrote: > > Not sure why you added Marcel to the list of reviewers... > > > > Anyway, if the current patch is all that is needed to restore sanity as in > > KDE 3, the I am all for getting it fixed. > > Christoph Feck wrote: > (And if the same