Re: Background for login, splash, and lockscreen

2014-06-22 Thread Jens Reuterberg
(Im really really tired - please let me rephrase) Ok so you have the default blurred wallpaper for the login, based on the default wallpaper. But then you pick a new wallpaper, and instead of having it get blurred during login (which would make it really heavy and annoying) the wallpaper picker

Re: Background for login, splash, and lockscreen

2014-06-22 Thread Jens Reuterberg
Ok so I have to ask (because my mum once told me as a child, slow people ask a lot of questions - but only complete idiots don't) :) Place be nice. Wouldn't it be possible to have the wallpaper picker pick the login wallpaper as well? I mean say I choose a wallpaper with a photo of a dog or som

Re: Review Request 118637: [klipper] Port from XLib to XCB

2014-06-22 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118637/ --- (Updated June 23, 2014, 6:35 a.m.) Status -- This change has been ma

Re: Review Request 118637: [klipper] Port from XLib to XCB

2014-06-22 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118637/#review60751 --- This review has been submitted with commit 951af7b491d3ad02d6

Re: Review Request 118695: Don't set -DHAVE_X11 through target properties

2014-06-22 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118695/ --- (Updated June 23, 2014, 6:33 a.m.) Status -- This change has been ma

Re: Review Request 118695: Don't set -DHAVE_X11 through target properties

2014-06-22 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118695/#review60750 --- This review has been submitted with commit ca9be41cb8d4f459f9

Re: Review Request 118812: [plasmashell] Show a warning if there are no Shaders and exit

2014-06-22 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118812/#review60745 --- This review has been submitted with commit 0a040bc49837e49f9c

Re: Review Request 118812: [plasmashell] Show a warning if there are no Shaders and exit

2014-06-22 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118812/ --- (Updated June 23, 2014, 6:11 a.m.) Status -- This change has been ma

Re: Review Request 118886: Add paintedWidth and paintedHeight properties to WindowThumbnail

2014-06-22 Thread Martin Gräßlin
> On June 22, 2014, 11:29 p.m., David Edmundson wrote: > > src/declarativeimports/core/windowthumbnail.h, line 93 > > > > > > I would just have the one signal, paintedSizeChanged. > > > > Otherwise we pot

Re: Review Request 118886: Add paintedWidth and paintedHeight properties to WindowThumbnail

2014-06-22 Thread Kai Uwe Broulik
> On June 22, 2014, 9:29 p.m., David Edmundson wrote: > > src/declarativeimports/core/windowthumbnail.h, line 93 > > > > > > I would just have the one signal, paintedSizeChanged. > > > > Otherwise we pote

Re: Review Request 118891: Folder view icon text background

2014-06-22 Thread Andrew Lake
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118891/ --- (Updated June 23, 2014, 12:41 a.m.) Review request for Plasma. Changes

Re: Review Request 118891: Folder view icon text background

2014-06-22 Thread Andrew Lake
> On June 22, 2014, 11:29 p.m., Mark Gaiser wrote: > > Not a +1 or -1. Just my preference for this. > > - No background (aka, fully transparent) when nothing is selected. > > - Selected items should show the background as in your screenshot. > > > > Just my preference though :) This change is f

Re: Review Request 118891: Folder view icon text background

2014-06-22 Thread Mark Gaiser
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118891/#review60739 --- Not a +1 or -1. Just my preference for this. - No background (

Review Request 118891: Folder view icon text background

2014-06-22 Thread Andrew Lake
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118891/ --- Review request for Plasma. Bugs: 335070 https://bugs.kde.org/show_bug

Re: Review Request 118886: Add paintedWidth and paintedHeight properties to WindowThumbnail

2014-06-22 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118886/#review60735 --- (Is it better to store m_paintedWidth and m_paintedHeight sepa

Review Request 118889: Use new Konqui in the about Dialog

2014-06-22 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118889/ --- Review request for KDE Frameworks and Plasma. Repository: kxmlgui Descr

Review Request 118886: Add paintedWidth and paintedHeight properties to WindowThumbnail

2014-06-22 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118886/ --- Review request for Plasma and Martin Gräßlin. Repository: plasma-framewor

Re: Background for login, splash, and lockscreen

2014-06-22 Thread Andrew Lake
This blurred, dimmed version of the default wallpaper has been committed for use by the login, splash and lockscreen. Much respect, Andrew On Sun, Jun 22, 2014 at 12:34 PM, Kai Uwe Broulik wrote: > Well, imho the wallpaper on the lockscreen should be the one the user has > chosen for his/her d

Re: Background for login, splash, and lockscreen

2014-06-22 Thread Kai Uwe Broulik
Well, imho the wallpaper on the lockscreen should be the one the user has chosen for his/her desktop, and there we cannot influence that. Even if the lockscreen wallpaper is configurable we don't have influence on its appearance either. Was just a thought, there may be a dozen of reasons not to

Re: Review Request 118883: Splash minor visual refinement

2014-06-22 Thread Andrew Lake
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118883/ --- (Updated June 22, 2014, 7:32 p.m.) Status -- This change has been ma

Re: Review Request 118883: Splash minor visual refinement

2014-06-22 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118883/#review60726 --- Ship it! Ship It! - Marco Martin On June 22, 2014, 6:47 p.

Re: Review Request 118876: Remove start in systemtray option from the kmenuedit.

2014-06-22 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118876/#review60725 --- I think the suggestion to port ksystemtraycmd to SNI is wrong:

Re: Review Request 118804: Register ksmserver as logind session leader

2014-06-22 Thread Martin Gräßlin
> On June 22, 2014, 4:54 p.m., Àlex Fiestas wrote: > > According to Lennart we should not call TakeControl, so I guess that while > > we wait for kdbus we should discard this review? why? And what does that have to do with kdbus? And how long should we wait for kdbus (my understanding here is

Re: Background for login, splash, and lockscreen

2014-06-22 Thread Martin Graesslin
On Saturday 21 June 2014 16:18:10 Kai Uwe Broulik wrote: > Can't we just use QtGraphicalEffects and just blur (and/or desaturate and/or > darken) whatever picture the user has chosen? > > The overall performance of these is great (at least on Android which is slow > in any other QtQuick respect) b

Review Request 118883: Splash minor visual refinement

2014-06-22 Thread Andrew Lake
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118883/ --- Review request for Plasma. Repository: plasma-workspace Description ---

Re: Review Request 118804: Register ksmserver as logind session leader

2014-06-22 Thread Àlex Fiestas
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118804/#review60716 --- According to Lennart we should not call TakeControl, so I gues

Re: Review Request 118876: Remove start in systemtray option from the kmenuedit.

2014-06-22 Thread Bhushan Shah
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118876/ --- (Updated June 22, 2014, 6:06 p.m.) Status -- This change has been di

Re: Review Request 118876: Remove start in systemtray option from the kmenuedit.

2014-06-22 Thread Eike Hein
> On June 22, 2014, 12:29 p.m., Eike Hein wrote: > > Additionally, note that the "Place in system tray" option is also in > > frameworks/kio/src/widgets/kpropertiesdesktopadvbase.ui for the general > > .desktop app link properties UI (the one that also used to be loaded by the > > config dialo

Re: Review Request 118876: Remove start in systemtray option from the kmenuedit.

2014-06-22 Thread Bhushan Shah
> On June 22, 2014, 5:59 p.m., Eike Hein wrote: > > Additionally, note that the "Place in system tray" option is also in > > frameworks/kio/src/widgets/kpropertiesdesktopadvbase.ui for the general > > .desktop app link properties UI (the one that also used to be loaded by the > > config dialog

Re: Review Request 118876: Remove start in systemtray option from the kmenuedit.

2014-06-22 Thread Eike Hein
> On June 22, 2014, 12:25 p.m., Eike Hein wrote: > > This might make sense as a temp measure, but what about porting ksystraycmd > > to KStatusNotifierItem? The KDE 4 version does see active use. > > Bhushan Shah wrote: > Porting is not possible (removed), one have to write from scratch..

Re: Review Request 118876: Remove start in systemtray option from the kmenuedit.

2014-06-22 Thread Eike Hein
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118876/#review60696 --- Additionally, note that the "Place in system tray" option is a

Re: Review Request 118876: Remove start in systemtray option from the kmenuedit.

2014-06-22 Thread Bhushan Shah
> On June 22, 2014, 5:55 p.m., Eike Hein wrote: > > This might make sense as a temp measure, but what about porting ksystraycmd > > to KStatusNotifierItem? The KDE 4 version does see active use. Porting is not possible (removed), one have to write from scratch.. - Bhushan --

Re: Review Request 118876: Remove start in systemtray option from the kmenuedit.

2014-06-22 Thread Eike Hein
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118876/#review60694 --- This might make sense as a temp measure, but what about portin

Review Request 118876: Remove start in systemtray option from the kmenuedit.

2014-06-22 Thread Bhushan Shah
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118876/ --- Review request for Plasma and Àlex Fiestas. Repository: kmenuedit Descr

Review Request 118869: Use QElapsedTimer for data engines

2014-06-22 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118869/ --- Review request for Plasma and Aaron J. Seigo. Bugs: 336551 http://bug

Jenkins build is back to stable : plasma-workspace_master_qt5 #516

2014-06-22 Thread KDE CI System
See ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel