> On June 22, 2014, 11:29 p.m., David Edmundson wrote: > > src/declarativeimports/core/windowthumbnail.h, line 93 > > <https://git.reviewboard.kde.org/r/118886/diff/1/?file=283725#file283725line93> > > > > I would just have the one signal, paintedSizeChanged. > > > > Otherwise we potentially end up re-evaluating loads of bindings twice. > > (Qt does this for the Text item) > > Kai Uwe Broulik wrote: > I can have the same changed signal for multiple properties?
yes - Martin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118886/#review60735 ----------------------------------------------------------- On June 22, 2014, 9:54 p.m., Kai Uwe Broulik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118886/ > ----------------------------------------------------------- > > (Updated June 22, 2014, 9:54 p.m.) > > > Review request for Plasma and Martin Gräßlin. > > > Repository: plasma-framework > > > Description > ------- > > This adds paintedWidth and paintedHeight properties to > PlasmaCore.WindowThumbnail which tells as how large the thumbnail, which is > scaled keeping aspect ratio, actually is, similar to what QML Image does. > This is will eventually allow the taskmanager to size its tooltips more > appropriately. > > (Is it better to store m_paintedWidth and m_paintedHeight separately, or is > the QSize thing I used ok?) > > > Diffs > ----- > > src/declarativeimports/core/windowthumbnail.h 14fc44a > src/declarativeimports/core/windowthumbnail.cpp b10f030 > > Diff: https://git.reviewboard.kde.org/r/118886/diff/ > > > Testing > ------- > > Works, reports the actual size > > > Thanks, > > Kai Uwe Broulik > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
