Re: Review Request 118716: New Translations KCM

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118716/ --- (Updated June 13, 2014, 2:31 a.m.) Review request for KDE Frameworks, Pla

Review Request 118716: New Translations KCM

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118716/ --- Review request for KDE Frameworks, Plasma, Chusslove Illich, and John Layt.

Re: Review Request 118691: Change currentIndex of playlistModel to -1 when a media is not from playlist

> On June 12, 2014, 5:54 p.m., Mark Gaiser wrote: > > Why would you do it this way? > > I mean, you should have a model in the C++ side and you should have a view > > (probably ListView). Then you can just ask the view the count: > > http://qt-project.org/doc/qt-5/qml-qtquick-listview.html#coun

Re: Review Request 118691: Change currentIndex of playlistModel to -1 when a media is not from playlist

> On June 12, 2014, 11:24 p.m., Mark Gaiser wrote: > > Why would you do it this way? > > I mean, you should have a model in the C++ side and you should have a view > > (probably ListView). Then you can just ask the view the count: > > http://qt-project.org/doc/qt-5/qml-qtquick-listview.html#cou

Re: Review Request 118691: Change currentIndex of playlistModel to -1 when a media is not from playlist

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118691/ --- (Updated June 12, 2014, 5:51 p.m.) Status -- This change has been ma

Re: Review Request 118691: Change currentIndex of playlistModel to -1 when a media is not from playlist

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118691/#review59895 --- Why would you do it this way? I mean, you should have a model

Re: Review Request 118691: Change currentIndex of playlistModel to -1 when a media is not from playlist

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118691/#review59893 --- This review has been submitted with commit 1f6b40ed24fc3ce4a8

Re: Review Request 118691: Change currentIndex of playlistModel to -1 when a media is not from playlist

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118691/#review59891 --- Ship it! Ship It! - Shantanu Tushar On June 12, 2014, 5:22

Re: Review Request 118691: Change currentIndex of playlistModel to -1 when a media is not from playlist

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118691/ --- (Updated June 12, 2014, 10:52 p.m.) Review request for Plasma, Shantanu T

Re: Review Request 115431: Fix the numbers cut off problem in digital clock applet

> On June 11, 2014, 6:18 p.m., Rex Dieter wrote: > > Tested this out a bit today... and it didn't seem to work all that well. > > Did seem to result in too much whitespace at times, and was fairly easy to > > get plasma into a state where it would endlessly try to resize things to > > fit. H

Re: Review Request 118691: Change currentIndex of playlistModel to -1 when a media is not from playlist

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118691/#review59887 --- libs/mediacenter/playlistmodel.h

Review Request 118697: Treat albums with different artists as different albums

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118697/ --- Review request for Plasma. Repository: plasma-mediacenter Description -

StatusNotifier questions

Hello :) Just some tiny (I hope) questions regarding the StatusNotifiers. 1) Is it expected that: qdbus org.kde.StatusNotifierWatcher /StatusNotifierWatcher org.kde.StatusNotifierWatcher.RegisteredStatusNotifierItems returns org.kde.StatusNotifierItem-xx-y/StatusNotifierItem instead of org.kd

Review Request 118696: Remove unused dependencies.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118696/ --- Review request for Plasma. Repository: plasmate Description --- Al

Re: Plasma 5 Beta 2 tars

On Thursday 12 of June 2014 14:53:57 Marco Martin wrote: > On Wednesday 11 June 2014, šumski wrote: > > Unfortunately, we cannot touch the buildhost, only sources which are > > built (and i'm running x86_64 OS). > > You might be right about kde_file, though seems to be a namespace > > clash/mixup.

Re: Review Request 118688: Avoid crash when artist is invalid

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118688/ --- (Updated June 12, 2014, 1:07 p.m.) Status -- This change has been ma

Re: Review Request 118688: Avoid crash when artist is invalid

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118688/#review59883 --- This review has been submitted with commit 198cbb351814dc23f0

Re: Review Request 118688: Avoid crash when artist is invalid

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118688/#review59881 --- Ship it! This change should go to master as well - Sinny Kum

Re: Plasma 5 Beta 2 tars

On Wednesday 11 June 2014, šumski wrote: > Unfortunately, we cannot touch the buildhost, only sources which are built > (and i'm running x86_64 OS). > You might be right about kde_file, though seems to be a namespace > clash/mixup. The attached patch resolves the failure here (basically > renaming

Re: Review Request 118694: X11/XCB becomes a required component

> On June 12, 2014, 11:36 a.m., David Edmundson wrote: > > Ship it from me, but I'd like you to get approval from one of the Windows > > people first. > > Martin Gräßlin wrote: > I think we have that already: > https://mail.kde.org/pipermail/plasma-devel/2014-June/032269.html ship it then

Re: Review Request 118694: X11/XCB becomes a required component

> On June 12, 2014, 1:36 p.m., David Edmundson wrote: > > Ship it from me, but I'd like you to get approval from one of the Windows > > people first. I think we have that already: https://mail.kde.org/pipermail/plasma-devel/2014-June/032269.html - Martin ---

Review Request 118695: Don't set -DHAVE_X11 through target properties

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118695/ --- Review request for Plasma. Repository: plasma-desktop Description -

Re: Review Request 118694: X11/XCB becomes a required component

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118694/#review59873 --- Ship it! Ship it from me, but I'd like you to get approval fr

Re: Review Request 118661: Only find Qt5::X11Extras if X11 is found

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118661/ --- (Updated June 12, 2014, 1:32 p.m.) Status -- This change has been di

Review Request 118694: X11/XCB becomes a required component

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118694/ --- Review request for Plasma. Repository: plasma-desktop Description -

Review Request 118693: [ksmserver/screenlocker] Use ScreenSaver key as shortcut

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118693/ --- Review request for Plasma. Repository: plasma-workspace Description ---

Re: Moving Parts of Baloo into the Workspace

On Thu, Jun 12, 2014 at 12:40 PM, Mario Fux wrote: > Am Donnerstag, 12. Juni 2014, 12.33:21 schrieb Aleix Pol: > > Morning Aleix > > > On Wed, Jun 11, 2014 at 3:43 PM, Vishesh Handa wrote: > > > On Wed, Jun 11, 2014 at 3:30 PM, Aleix Pol wrote: > > >> Doesn't that tie Baloo usage to exclusively

Re: Moving Parts of Baloo into the Workspace

Am Donnerstag, 12. Juni 2014, 12.33:21 schrieb Aleix Pol: Morning Aleix > On Wed, Jun 11, 2014 at 3:43 PM, Vishesh Handa wrote: > > On Wed, Jun 11, 2014 at 3:30 PM, Aleix Pol wrote: > >> Doesn't that tie Baloo usage to exclusively Plasma? If you want it to be > >> a framework, won't framework u

Re: Moving Parts of Baloo into the Workspace

On Wed, Jun 11, 2014 at 3:43 PM, Vishesh Handa wrote: > On Wed, Jun 11, 2014 at 3:30 PM, Aleix Pol wrote: >> >> Doesn't that tie Baloo usage to exclusively Plasma? If you want it to be >> a framework, won't framework users need to configure the things in the KCM? >> >> > Hmm, you have a point. >

Re: Review Request 118512: RFC: Rename CMake configuration files to KFileMetaData5*

> On June 11, 2014, 11 a.m., Vishesh Handa wrote: > > How about we change the cmake file to KF5KFileMetaDataConfig.cmake instead? > > This way there will be no conflicts, and it will be consistent with the > > rest of the frameworks as well? > > Aleix Pol Gonzalez wrote: > I agree it's the

Re: Plasma 5 Beta 2 tars

On Fri, Jun 06, 2014 at 11:24:50PM +0200, šumski wrote: > Other then these issues present in tarball only (not git), there is an > ongoing > problem with plasma-desktop which blocks creating proper 32bit packages: > http://paste.opensuse.org/25338349 I'm afraid I can't recreate this, it compiles

Re: Review Request 118357: Disable the agenda part of the calendar

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118357/#review59861 --- I seem to have missed this change. The rationale behind this

Review Request 118691: Change currentIndex of playlistModel to -1 when a media is not from playlist

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118691/ --- Review request for Plasma, Shantanu Tushar and Sinny Kumari. Repository: