> On June 12, 2014, 1:36 p.m., David Edmundson wrote: > > Ship it from me, but I'd like you to get approval from one of the Windows > > people first.
I think we have that already: https://mail.kde.org/pipermail/plasma-devel/2014-June/032269.html - Martin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118694/#review59873 ----------------------------------------------------------- On June 12, 2014, 1:32 p.m., Martin Gräßlin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118694/ > ----------------------------------------------------------- > > (Updated June 12, 2014, 1:32 p.m.) > > > Review request for Plasma. > > > Repository: plasma-desktop > > > Description > ------- > > X11/XCB becomes a required component > > So far plasma-desktop supported to be built without X11 support (Win32), > but that was completely broken (X11Extras was required). Based on > discussion in [1] X11/XCB becomes a required component. > > This means that we should not have any components in the build system > which are built optionaly depending on whether X11 is available. Ifdefs > in the code should stay, though. > > For the future we will turn X11 in a optional dependency again. But it > will never be that a component won't be built if we are building without > X11. Instead there will be a required Wayland backend and this means all > X11 specific code needs to become platform aware. > > So the way forward is: > 1. X11 required > 2. X11 required, Wayland optional > 3. X11 required, Wayland required > 4. Wayland required, X11 optional > > [1] https://mail.kde.org/pipermail/plasma-devel/2014-June/032259.html > > > Diffs > ----- > > CMakeLists.txt 399de771e17b265c1e5a223ad128ae2d17c00d22 > applets/CMakeLists.txt a5f35f77aead140054696ca4b3122fb177c70f1d > kcms/CMakeLists.txt 8024367f52b4fd3f757d4e5c5c851a204f4fd74b > kcms/componentchooser/CMakeLists.txt > 66f0fece8b786cf277cf41e6bef0cf03b3f619d1 > kcms/componentchooser/componentservices/CMakeLists.txt > 15cca45a12e2e61c721f092b26fa5953701ee958 > kcms/style/CMakeLists.txt 423241b8127491853d8afa75bb8b5d78c9009dca > > Diff: https://git.reviewboard.kde.org/r/118694/diff/ > > > Testing > ------- > > > Thanks, > > Martin Gräßlin > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
