Re: Review Request 118251: Small improvments to FadingNode and IconItem

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118251/#review59743 --- This review has been submitted with commit 0d61746784629cb9f6

Re: Review Request 118251: Small improvments to FadingNode and IconItem

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118251/ --- (Updated June 11, 2014, 5:59 a.m.) Status -- This change has been ma

Re: Re: Activity switcher problems [for Plasma and KWin teams]

On Wednesday 11 June 2014 07:45:36 Ivan Čukić wrote: > I'm abandoning the idea, per previous suggestions, but... > > > why? what would that help? > > ... less code duplication (handling modifier keys and shortcuts), faster > display (no complicated mechanism like the side panel loading), easier >

Review Request 118657: Use move() while moving items in playlist, instead of dataChanged() signals

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118657/ --- Review request for Plasma, Shantanu Tushar and Sinny Kumari. Repository:

Re: Activity switcher problems [for Plasma and KWin teams]

I'm abandoning the idea, per previous suggestions, but... > why? what would that help? ... less code duplication (handling modifier keys and shortcuts), faster display (no complicated mechanism like the side panel loading), easier integration with the present effect. Cheerio, Ivan KDE, ivan.

Re: Activity switcher problems [for Plasma and KWin teams]

On Tuesday 10 June 2014 21:12:16 Ivan Čukić wrote: > 2) Make it a part of kwin (apologies to M.G. for this one). why? what would that help? signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kd

Re: Activity switcher problems [for Plasma and KWin teams]

On Wednesday 11 June 2014 00:01:52 David Edmundson wrote: > > 1) Make opening the activity switcher fast. That would need to throw away > > the lazy loading that we currently have. And I'm not sure that would be a > > sufficient improvement. > > Note that a debug build of Qt makes a humongous diff

Re: Activity switcher problems [for Plasma and KWin teams]

> 1) Make opening the activity switcher fast. That would need to throw away the > lazy loading that we currently have. And I'm not sure that would be a > sufficient improvement. Note that a debug build of Qt makes a humongous difference to the speed of all things QtQuick related, especially parsin

Re: Plasma 5 Beta 2 tars

On Tue, Jun 10, 2014 at 11:14:26PM +0200, Sebastian Kügler wrote: > On Tuesday, June 10, 2014 22:10:19 Jonathan Riddell wrote: > > Last minute update to fix issues in the translation files. Alas I found no > > fix for the reported problem compiling on i386 > > Could you send a log here of the bui

Re: Review Request 118148: KRunner: Add the concept of disabled categories

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118148/#review59727 --- src/runnermanager.cpp

Re: Plasma 5 Beta 2 tars

On Tuesday, June 10, 2014 22:10:19 Jonathan Riddell wrote: > Last minute update to fix issues in the translation files. Alas I found no > fix for the reported problem compiling on i386 Could you send a log here of the build failure on i386? -- sebas http://www.kde.org | http://vizZzion.org | GP

Re: Plasma 5 Beta 2 tars

Last minute update to fix issues in the translation files. Alas I found no fix for the reported problem compiling on i386 http://starsky.19inch.net/~jr/tmp/plasma-4.97.0/plasma-desktop-4.97.0.tar.xz fefbfa73eace6fe85c0f401605bcb9695389b73ac03a9558cff1cbb9d04e8155 plasma-desktop-4.97.0.tar.xz

Re: Review Request 118251: Small improvments to FadingNode and IconItem

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118251/#review59724 --- Ship it! Ship It! - David Edmundson On June 10, 2014, 1:56

Re: Review Request 118423: [klipper] Port KMimeType to QMimeType

> On June 10, 2014, 12:26 p.m., David Edmundson wrote: > > klipper/urlgrabber.cpp, line 152 > > > > > > QLatin1String > > > > (or rather QStringLiteral) > > Martin Klapetek wrote: > For string compa

Re: Activity switcher problems [for Plasma and KWin teams]

On Tuesday 10 June 2014, Ivan Čukić wrote: > So, from what I see here, there are two things needed to fix this. > > 1) Make opening the activity switcher fast. That would need to throw away > the lazy loading that we currently have. And I'm not sure that would be a > sufficient improvement. diffe

Activity switcher problems [for Plasma and KWin teams]

Hi all, Unfortunately, I wasn't able to join the hangout today to discuss this (I'll be mostly away for this week). So, the issue is that: 1) the activity switcher opens up too slow. The user would expect for it to be shown instantaneously. At first, my plan was to add a delay, check whether t

Re: Review Request 118644: Update battery monitor popup to use new icons

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118644/ --- (Updated June 10, 2014, 7:04 p.m.) Status -- This change has been ma

Re: Review Request 118644: Update battery monitor popup to use new icons

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118644/#review59719 --- This review has been submitted with commit 2d97851b8ad9991bff

Re: Review Request 118644: Update battery monitor popup to use new icons

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118644/#review59718 --- Ship it! Thank you very much! - Kai Uwe Broulik On June 10

Re: Review Request 118644: Update battery monitor popup to use new icons

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118644/ --- (Updated June 10, 2014, 5:09 p.m.) Review request for Plasma and Kai Uwe

Review Request 118644: Update battery monitor popup to use new icons

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118644/ --- Review request for Plasma and Kai Uwe Broulik. Repository: plasma-workspa

Re: Review Request 118148: KRunner: Add the concept of disabled categories

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118148/#review59714 --- Ship it! eww, sorry for the delay. ship it! - Marco Martin

Re: Review Request 118469: KRunner: Stop using the dialog class

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118469/ --- (Updated June 10, 2014, 4:38 p.m.) Status -- This change has been di

Re: Review Request 118148: KRunner: Add the concept of disabled categories

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118148/#review59712 --- ping - Vishesh Handa On May 22, 2014, 2:59 p.m., Vishesh Ha

Re: Review Request 118423: [klipper] Port KMimeType to QMimeType

> On June 10, 2014, 10:26 a.m., David Edmundson wrote: > > klipper/urlgrabber.cpp, line 152 > > > > > > QLatin1String > > > > (or rather QStringLiteral) > > Martin Klapetek wrote: > For string compa

Re: Review Request 118630: [KQuickControls] Consider Super_L and Super_R as modifiers

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118630/ --- (Updated June 10, 2014, 2:32 p.m.) Status -- This change has been ma

Re: Review Request 118630: [KQuickControls] Consider Super_L and Super_R as modifiers

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118630/#review59697 --- This review has been submitted with commit 7eaa20924b99e3fa92

Re: Review Request 118636: Reinstate login & logout sounds

> On June 10, 2014, 3:15 p.m., David Edmundson wrote: > > ksmserver/shutdown.cpp, line 468 > > > > > > and if there is no sound the closed signal happens immediately? If you mean no configured sound, then yes. I

Re: Review Request 118251: Small improvments to FadingNode and IconItem

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118251/ --- (Updated June 10, 2014, 3:56 p.m.) Review request for Plasma and David Ed

Review Request 118638: Install bzip2 and LZMA filter and documentation based on available support in KArchive.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118638/ --- Review request for Plasma. Repository: kio-extras Description ---

Review Request 118637: [klipper] Port from XLib to XCB

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118637/ --- Review request for Plasma. Repository: plasma-workspace Description ---

Re: Review Request 118428: Drop configuration options for taskbar and desktop fonts

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118428/ --- (Updated June 10, 2014, 1:38 p.m.) Status -- This change has been ma

Re: Review Request 118428: Drop configuration options for taskbar and desktop fonts

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118428/#review59693 --- This review has been submitted with commit e958dea8964b16457e

Re: Review Request 118636: Reinstate login & logout sounds

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118636/#review59691 --- ksmserver/shutdown.cpp

Re: Review Request 117727: Handle tests and docs if deps are missing

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117727/ --- (Updated June 10, 2014, 1:14 p.m.) Status -- This change has been ma

Review Request 118636: Reinstate login & logout sounds

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118636/ --- Review request for Plasma and Àlex Fiestas. Bugs: 335948 https://bugs

Re: Review Request 118386: Give milou proper version

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118386/ --- (Updated June 10, 2014, 1:03 p.m.) Status -- This change has been ma

Re: Review Request 118386: Give milou proper version

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118386/#review59690 --- This review has been submitted with commit df86d9da03f47b928f

Re: Review Request 118635: [klipper] Drop kdelibs4support dependency

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118635/ --- (Updated June 10, 2014, 12:42 p.m.) Status -- This change has been m

Re: Review Request 118635: [klipper] Drop kdelibs4support dependency

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118635/#review59688 --- This review has been submitted with commit 41d3e1fc54a4aaa036

Re: Review Request 118635: [klipper] Drop kdelibs4support dependency

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118635/#review59687 --- Ship it! Ship It! - Marco Martin On June 10, 2014, 12:36 p

Review Request 118635: [klipper] Drop kdelibs4support dependency

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118635/ --- Review request for Plasma. Repository: plasma-workspace Description ---

Re: Review Request 118512: RFC: Rename CMake configuration files to KFileMetaData5*

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118512/#review59685 --- Unless this is absolutely necessary from an installation point

Re: Review Request 118386: Give milou proper version

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118386/#review59681 --- Ship it! - Vishesh Handa On May 28, 2014, 7:07 p.m., Hrvoje

Re: Review Request 118461: [klipper] Rename desktop file to org.kde.klipper.desktop and set DBUS-ServiceName

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118461/#review59680 --- This review has been submitted with commit 9cced65bcf6e427b03

Re: Review Request 118461: [klipper] Rename desktop file to org.kde.klipper.desktop and set DBUS-ServiceName

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118461/ --- (Updated June 10, 2014, 12:26 p.m.) Status -- This change has been m

Re: Review Request 118630: [KQuickControls] Consider Super_L and Super_R as modifiers

> On June 10, 2014, 10:34 a.m., David Edmundson wrote: > > Wait for the Qt patch if relevant > > Sebastian Kügler wrote: > It doesn't break any more without the Qt patch, so I'd rather ship this, > and have it automatically fixed once Qt is updated. My concern is that the Qt patch doesn't

Re: Review Request 118461: [klipper] Rename desktop file to org.kde.klipper.desktop and set DBUS-ServiceName

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118461/#review59677 --- Ship it! Ship It! - David Edmundson On June 10, 2014, 12:1

Re: Review Request 118461: [klipper] Rename desktop file to org.kde.klipper.desktop and set DBUS-ServiceName

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118461/ --- (Updated June 10, 2014, 2:14 p.m.) Review request for Plasma. Changes -

Re: Review Request 118423: [klipper] Port KMimeType to QMimeType

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118423/#review59671 --- This review has been submitted with commit 027c1723c0bd34dc6c

Re: Review Request 118423: [klipper] Port KMimeType to QMimeType

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118423/ --- (Updated June 10, 2014, 12:12 p.m.) Status -- This change has been m

Re: Minutes Monday Plasma hangout

Ivan: - Keyboard activity switching and UI navigation (as seen in the blog post) On 10 June 2014 12:43, Sebastian Kügler wrote: > Minutes from Monday Plasma Hangout Today! > > Present: AleixAntonis, Jonathan, Marco, Martin G., Martin K., David, > Sebastian, Vishesh > > > Antonis > - Worked on

Re: Review Request 118630: [KQuickControls] Consider Super_L and Super_R as modifiers

> On June 10, 2014, 10:34 a.m., David Edmundson wrote: > > Wait for the Qt patch if relevant It doesn't break any more without the Qt patch, so I'd rather ship this, and have it automatically fixed once Qt is updated. - Sebastian --- T

Minutes Monday Plasma hangout

Minutes from Monday Plasma Hangout Today! Present: AleixAntonis, Jonathan, Marco, Martin G., Martin K., David, Sebastian, Vishesh Antonis - Worked on wallpapers in Plasma Active shell - Created new touch-based UI to replace desktop UI - Added support for creating and editing activities - Exam p

Re: Review Request 118461: [klipper] Rename desktop file to org.kde.klipper.desktop and set DBUS-ServiceName

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118461/#review59661 --- klipper/CMakeLists.txt

Re: Review Request 118630: [KQuickControls] Consider Super_L and Super_R as modifiers

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118630/#review59659 --- Ship it! Wait for the Qt patch if relevant - David Edmundson

Re: Review Request 118423: [klipper] Port KMimeType to QMimeType

> On June 10, 2014, 12:26 p.m., David Edmundson wrote: > > klipper/urlgrabber.cpp, line 152 > > > > > > QLatin1String > > > > (or rather QStringLiteral) For string comparisons QLatin1String is better/fa

Re: Review Request 118423: [klipper] Port KMimeType to QMimeType

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118423/#review59657 --- Ship it! klipper/urlgrabber.cpp

Re: Review Request 118406: Notify the user if the location containing the media is inaccessible.

> On June 5, 2014, 8:36 a.m., Thomas Pfeiffer wrote: > > Usability review: > > Since I lack the skills to picture it from the diff: When exactly is the > > notification shown? Is it shown as soon as the media is supposed to be > > played? If so, I think it could be done in a more subtle way: Gr

Jenkins build is back to normal : plasma-workspace_master_qt5 #384

See ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 118347: [klipper] Port from KIntSpinBox to KPluralHandlingSpinBox

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118347/ --- (Updated June 10, 2014, 7:34 a.m.) Status -- This change has been ma

Re: Review Request 118347: [klipper] Port from KIntSpinBox to KPluralHandlingSpinBox

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118347/#review59643 --- This review has been submitted with commit 51d3cf399949ee2596