> On June 10, 2014, 10:34 a.m., David Edmundson wrote: > > Wait for the Qt patch if relevant
It doesn't break any more without the Qt patch, so I'd rather ship this, and have it automatically fixed once Qt is updated. - Sebastian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118630/#review59659 ----------------------------------------------------------- On June 9, 2014, 10:04 p.m., Sebastian Kügler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118630/ > ----------------------------------------------------------- > > (Updated June 9, 2014, 10:04 p.m.) > > > Review request for KDE Frameworks and Plasma. > > > Repository: kdeclarative > > > Description > ------- > > Consider Super_L and Super_R as modifiers > > Without this patch, I can't use the meta key to assign shortcuts, as > Super_L and Super_R are not considered as modifiers, so when I press > meta (Super_L on my system), the shortcut is immediately accepted, > before I get the chance to press another key. > > This patch requires the fix in > https://bugreports.qt-project.org/browse/QTBUG-38428 > to be applied. With both patches, the QtQuick widgets to assign > shortcuts works for me also with the Meta key. > > Suggested by David Edmundson in review request at > https://git.reviewboard.kde.org/r/118581/ > > CCBUG:335316 > > > Diffs > ----- > > src/qmlcontrols/kquickcontrols/private/keysequencehelper.cpp > 7bf67ecb68c97086c0d858ef7c7f774ae0560983 > > Diff: https://git.reviewboard.kde.org/r/118630/diff/ > > > Testing > ------- > > Tested assigning Meta + L to digital clock plasmoid, works with the patch, > doesn't work without (displays garbage like in the linked bugreport). > > > Thanks, > > Sebastian Kügler > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
