Re: Review Request 118388: rename systemsettings binary to systemsettings5

> On May 29, 2014, 9:10 a.m., Ben Cooksley wrote: > > Code wise, this change looks fine. In terms of renaming the desktop files - > > i'm fine with changing the filenames, but please don't change the name of > > the application itself. Ideally the KF5 based system settings will still be > > ab

Re: [Broken translations] Translation domain names

On 06/06/2014 05:25 PM, Marco Martin wrote: How do we proceed? can we rename the catalogs that need renaming? (an alternative can be adding an optional entry in the desktop file that tells the catalog name, so would use that if defined, and fallback to the plugin name if not defined) Having an

Re: Review Request 118613: Prevent crash when requesting icon with negative size

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118613/ --- (Updated June 8, 2014, 11:42 a.m.) Status -- This change has been ma

Re: Review Request 118613: Prevent crash when requesting icon with negative size

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118613/#review59553 --- This review has been submitted with commit 86c1f46eaa2ffe3849

Re: Review Request 118613: Prevent crash when requesting icon with negative size

> On June 8, 2014, 9:52 a.m., Martin Klapetek wrote: > > src/declarativeimports/core/iconitem.cpp, lines 295-296 > > > > > > Unrelated general question - why is there m_iconPixmap and m_pixmapIcon > > and what's

Re: Review Request 118613: Prevent crash when requesting icon with negative size

> On June 8, 2014, 11:52 a.m., Martin Klapetek wrote: > > src/declarativeimports/core/iconitem.cpp, lines 295-296 > > > > > > Unrelated general question - why is there m_iconPixmap and m_pixmapIcon > > and what'

Re: Review Request 118613: Prevent crash when requesting icon with negative size

> On June 8, 2014, 9:52 a.m., Martin Klapetek wrote: > > src/declarativeimports/core/iconitem.cpp, lines 295-296 > > > > > > Unrelated general question - why is there m_iconPixmap and m_pixmapIcon > > and what's

Re: Review Request 118613: Prevent crash when requesting icon with negative size

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118613/#review59545 --- src/declarativeimports/core/iconitem.cpp

Re: Review Request 118613: Prevent crash when requesting icon with negative size

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118613/#review59544 --- Ship it! Ship It! - David Edmundson On June 8, 2014, 4:45