Re: Review Request 118038: Bring back a KCM for the screen locker

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118038/ --- (Updated June 3, 2014, 8:53 a.m.) Review request for Plasma and Thomas Pf

Re: Review Request 118388: rename systemsettings binary to systemsettings5

> On May 29, 2014, 9:10 a.m., Ben Cooksley wrote: > > Code wise, this change looks fine. In terms of renaming the desktop files - > > i'm fine with changing the filenames, but please don't change the name of > > the application itself. Ideally the KF5 based system settings will still be > > ab

Re: Review Request 118388: rename systemsettings binary to systemsettings5

> On May 29, 2014, 7:10 a.m., Ben Cooksley wrote: > > Code wise, this change looks fine. In terms of renaming the desktop files - > > i'm fine with changing the filenames, but please don't change the name of > > the application itself. Ideally the KF5 based system settings will still be > > ab

Re: Review Request 118038: Bring back a KCM for the screen locker

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118038/#review59029 --- It needs a little bit more work: it doesn't trigger a reload o

Re: Review Request 118347: [klipper] Port from KIntSpinBox to KPluralHandlingSpinBox

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118347/ --- (Updated June 3, 2014, 7:48 a.m.) Review request for Plasma. Summary (u

Re: Review Request 118347: [klipper] Port from KIntSpinBox to KPluralAwareSpinBox

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118347/ --- (Updated June 3, 2014, 7:48 a.m.) Review request for Plasma. Changes --

Re: Review Request 118482: Adjust ksmserver for renamed KWin binary

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118482/#review59027 --- maybe we should make it a define like in kwin's source tree?

Re: Review Request 118487: fix type issue with qreal

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118487/ --- (Updated June 3, 2014, 1:48 a.m.) Review request for Plasma. Changes --

Re: Review Request 118487: fix type issue with qreal

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118487/#review59023 --- src/declarativeimports/core/framesvgitem.cpp

Review Request 118487: fix type issue with qreal

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118487/ --- Review request for Plasma. Repository: plasma-framework Description ---

Review Request 118482: Adjust ksmserver for renamed KWin binary

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118482/ --- Review request for Plasma and Martin Gräßlin. Repository: plasma-workspac

Re: ghns for plasmoids

On Monday 02 June 2014, Jeremy Whiting wrote: > Ok, I'll take a look at bodega-client this week. Does KDE have a > bodega server in place ? Are there plans to create one ? Is there work i don't think there is at the moment > to be done on the server side also or only maintenance is needed > ther

Re: Review Request 118390: Powerdevil KCM Updates

> On June 2, 2014, 4:26 p.m., Andrew Lake wrote: > > The group box HIG has been updated after discussion on the HIG mailing > > list. Using a group box with the 'flat' property set true is now > > recommended; it provides a consistent way to use spacing to group visual > > elements without the

Re: Review Request 118468: Use the spacebar key to play/pause a media from the homescreen.

On Mon, Jun 2, 2014 at 10:35 PM, Shantanu Tushar wrote: >This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118468/ > > Ship it! > > Hmm, looks good to me. > > Can you/anyone commit on my behalf ? Cheers :) Thanking You, R.Harish Navnit The Enig

Re: Review Request 118390: Powerdevil KCM Updates

> On June 2, 2014, 4:26 p.m., Andrew Lake wrote: > > The group box HIG has been updated after discussion on the HIG mailing > > list. Using a group box with the 'flat' property set true is now > > recommended; it provides a consistent way to use spacing to group visual > > elements without the

Re: Review Request 118468: Use the spacebar key to play/pause a media from the homescreen.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118468/#review59005 --- Ship it! Hmm, looks good to me. - Shantanu Tushar On June

Re: ghns for plasmoids

Ok, I'll take a look at bodega-client this week. Does KDE have a bodega server in place ? Are there plans to create one ? Is there work to be done on the server side also or only maintenance is needed there? BR, Jeremy On Mon, Jun 2, 2014 at 10:48 AM, Marco Martin wrote: > On Monday 02 June 201

Re: ghns for plasmoids

On Monday 02 June 2014, Jeremy Whiting wrote: > Marco, > > On Mon, Jun 2, 2014 at 10:19 AM, Marco Martin wrote: > > Hi all, > > now that get hot new stuff for wallpapers is "kindof" fixed (still > > depends from pending patches https://git.reviewboard.kde.org/r/118473/) > > > > there is the old

Review Request 118476: Move kded module to kf5/kded subdirectory

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118476/ --- Review request for KDE Frameworks and Plasma. Repository: plasma-framewor

Re: Review Request 118390: Powerdevil KCM Updates

> On June 2, 2014, 4:26 p.m., Andrew Lake wrote: > > The group box HIG has been updated after discussion on the HIG mailing > > list. Using a group box with the 'flat' property set true is now > > recommended; it provides a consistent way to use spacing to group visual > > elements without the

Re: Review Request 118390: Powerdevil KCM Updates

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118390/#review58996 --- The group box HIG has been updated after discussion on the HIG

Re: ghns for plasmoids

Marco, On Mon, Jun 2, 2014 at 10:19 AM, Marco Martin wrote: > Hi all, > now that get hot new stuff for wallpapers is "kindof" fixed (still depends > from pending patches https://git.reviewboard.kde.org/r/118473/) > > there is the old question of ghns for plasmoids. > I do know that the answer alw

ghns for plasmoids

Hi all, now that get hot new stuff for wallpapers is "kindof" fixed (still depends from pending patches https://git.reviewboard.kde.org/r/118473/) there is the old question of ghns for plasmoids. I do know that the answer always is "there should be an alternative to kdelook". However, that's an

Re: Review Request 118390: Powerdevil KCM Updates

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118390/ --- (Updated June 2, 2014, 4:04 p.m.) Review request for Plasma, Solid and KD

Re: Review Request 118470: Avoid references to QApplication

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118470/#review58988 --- This review has been submitted with commit 23068fb2b0f9aa18f3

Re: Review Request 118470: Avoid references to QApplication

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118470/ --- (Updated June 2, 2014, 3:44 p.m.) Status -- This change has been mar

Re: Review Request 118470: Avoid references to QApplication

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118470/#review58986 --- Ship it! Ship It! - Aleix Pol Gonzalez On June 2, 2014, 3:

Review Request 118470: Avoid references to QApplication

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118470/ --- Review request for Plasma. Repository: plasma-framework Description ---

Re: Review Request 118390: Powerdevil KCM Updates

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118390/#review58985 --- Almost there ;) The only title case labels I didn't see fixed

Re: Review Request 118469: KRunner: Stop using the dialog class

> On June 2, 2014, 2:13 p.m., David Edmundson wrote: > > krunner/view.cpp, line 85 > > > > > > If you really can't fix dialog create a tiny QML file with the contents > > > > import org.kde.plasmacore 2.0

Re: Review Request 118469: KRunner: Stop using the dialog class

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118469/#review58973 --- krunner/view.cpp

Re: Review Request 118390: Powerdevil KCM Updates

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118390/ --- (Updated June 2, 2014, 1:35 p.m.) Review request for Plasma, Solid and KD

Re: Review Request 118469: KRunner: Stop using the dialog class

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118469/#review58967 --- Also, loses the window shadows (would need duplication of othe

Re: Review Request 118469: KRunner: Stop using the dialog class

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118469/ --- (Updated June 2, 2014, 1:15 p.m.) Review request for Plasma. Changes --

Review Request 118469: KRunner: Stop using the dialog class

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118469/ --- Review request for Plasma. Repository: plasma-workspace Description ---

Re: Review Request 118461: [klipper] Rename desktop file to org.kde.klipper.desktop and set DBUS-ServiceName

> On June 2, 2014, noon, Aleix Pol Gonzalez wrote: > > Why do you rename the desktop file? If that's needed, then maybe we should > > rename them all? > > Martin Gräßlin wrote: > I just didn't find the email thread, but IIRC dfaure requested such > changes. It's done in kate which I looked

Re: Review Request 118414: [killer] Use dialog-warning icon as window icon for killer

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118414/ --- (Updated June 2, 2014, 1:02 p.m.) Status -- This change has been mar

Re: Review Request 118414: [killer] Use dialog-warning icon as window icon for killer

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118414/#review58960 --- This review has been submitted with commit dc37805586fdb0f061

Re: Review Request 118357: Disable the agenda part of the calendar

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118357/ --- (Updated June 2, 2014, 12:44 p.m.) Status -- This change has been ma

Re: Review Request 118357: Disable the agenda part of the calendar

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118357/#review58957 --- This review has been submitted with commit bfd62154d8e892d4fd

Review Request 118468: Use the spacebar key to play/pause a media from the homescreen.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118468/ --- Review request for Plasma, Shantanu Tushar and Sinny Kumari. Repository:

Re: Review Request 118461: [klipper] Rename desktop file to org.kde.klipper.desktop and set DBUS-ServiceName

> On June 2, 2014, noon, Aleix Pol Gonzalez wrote: > > Why do you rename the desktop file? If that's needed, then maybe we should > > rename them all? I just didn't find the email thread, but IIRC dfaure requested such changes. It's done in kate which I looked at for the other change. - Mart

Re: Review Request 118038: Bring back a KCM for the screen locker

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118038/#review58942 --- Ship it! Ship It! - Sebastian Kügler On May 8, 2014, 5:17

Re: Review Request 118461: [klipper] Rename desktop file to org.kde.klipper.desktop and set DBUS-ServiceName

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118461/#review58940 --- Why do you rename the desktop file? If that's needed, then may

Re: Review Request 118428: Drop configuration options for taskbar and desktop fonts

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118428/#review58939 --- Ship it! Ship It! - Sebastian Kügler On May 30, 2014, 3:42

Re: Review Request 118417: [klipper] Port from KDebug to QDebug

> On May 30, 2014, 3:39 p.m., Alexander Richardson wrote: > > Shouldn't this rather use qCDebug() so that the output can be disabled? I think it would be nice, but I'd also leave the choice between qDebug and qCDebug up to the maintainer -- Martin. :) We haven't enforced it everywhere yet. -

Re: Review Request 118272: batterymonitor visual cleanups

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118272/#review58934 --- There's been a bug report about inconsistent indicator/slider