-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118469/
-----------------------------------------------------------
Review request for Plasma.
Repository: plasma-workspace
Description
-------
KRunner: Stop using the dialog class
The dialog class provides a number of features such as resizing itself
when the item size changes, vice versa, and has slightly complex logic
to handle to being a tooltip / dialog / etc. We do not really need any
of this logic. We're just a simple window with a item + border.
This removes the duplicated dialog.h header file, but it unfortunately
introduces a copy of framesvgitem.*, units.*, and svgtexturenode.h. This
should be a temporary copy until these files are exported properly.
This patch fixes all the annoying flickering issues with krunner and
makes it much much smoother. It also fixes issues where the top border
is initially present but later disappears.
Diffs
-----
krunner/view.h fe7fa1c
krunner/units.h PRE-CREATION
krunner/units.cpp PRE-CREATION
krunner/svgtexturenode.h PRE-CREATION
krunner/framesvgitem.cpp PRE-CREATION
krunner/view.cpp 8e1b448
krunner/framesvgitem.h PRE-CREATION
krunner/dialog.h 6759a6e
krunner/CMakeLists.txt c7dbd71
Diff: https://git.reviewboard.kde.org/r/118469/diff/
Testing
-------
Is much much smoother, and the number of repaints/resizes are much less. Tested
by comparing frames via apitrace.
Thanks,
Vishesh Handa
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
