Review Request 118414: [killer] Use dialog-warning icon as window icon for killer

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118414/ --- Review request for kwin and Plasma. Repository: kwin Description --

Re: Review Request 118382: [klipper] Fix i18n

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118382/#review58765 --- This review has been submitted with commit 52405190040b6dbf09

Re: Review Request 118381: [klipper] Reintroduce the dependency on prison

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118381/ --- (Updated May 30, 2014, 5:54 a.m.) Status -- This change has been mar

Re: Review Request 118382: [klipper] Fix i18n

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118382/ --- (Updated May 30, 2014, 5:54 a.m.) Status -- This change has been mar

Re: Review Request 118381: [klipper] Reintroduce the dependency on prison

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118381/#review58766 --- This review has been submitted with commit f09e5a67de9b1e5a70

Re: Review Request 118382: [klipper] Fix i18n

> On May 29, 2014, 4:20 p.m., David Edmundson wrote: > > I'm not very happy giving a ship it to something that is ported but > > completely untested. We end up with code we think works, but doesn't work > > properly; which is worse than not touching it at all. > > > > It should be possible to

Review Request 118413: Put the settings views in a ScrollView

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118413/ --- Review request for Plasma. Repository: plasma-desktop Description -

Re: Review Request 118290: Streamline Comment fields of KCMs

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118290/ --- (Updated May 29, 2014, 11:28 p.m.) Status -- This change has been ma

Re: Review Request 118290: Streamline Comment fields of KCMs

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118290/#review58763 --- This review has been submitted with commit 7128a3aca1cbc1397b

Re: Review Request 118357: Disable the agenda part of the calendar

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118357/#review58750 --- Ping? - Martin Klapetek On May 27, 2014, 6 p.m., Martin Kla

Re: Review Request 118406: Notify the user if the location containing the media is inaccessible.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118406/#review58748 --- mediaelements/mediaplayer/MediaPlayer.qml

Re: Review Request 118340: Allow the kactivitymanagerd daemon to be disabled.

> On May 29, 2014, 11:02 a.m., Alex Merry wrote: > > Did you try compiling this? Because that macro doesn't exist any more - > > there is an ecm_optional_add_subdirectory() in ECM if you > > include(ECMOptionalAddSubdirectory), though. > > > > However, I think an explicit option(), with a usef

Re: Review Request 118340: Allow the kactivitymanagerd daemon to be disabled.

> On May 29, 2014, 10:57 a.m., David Edmundson wrote: > > This doesn't look great to me. > > We'd have to release another 4.x. Is this too big for the KDE 4.13.x releases? It doesn't change the default behaviour, and as discussed in: https://git.reviewboard.kde.org/r/115602/ , this is the onl

Review Request 118406: Notify the user if the location containing the media is inaccessible.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118406/ --- Review request for Plasma, Shantanu Tushar and Sinny Kumari. Bugs: 333764

Re: Review Request 118388: rename systemsettings binary to systemsettings5

> On May 29, 2014, 9:10 a.m., Ben Cooksley wrote: > > Code wise, this change looks fine. In terms of renaming the desktop files - > > i'm fine with changing the filenames, but please don't change the name of > > the application itself. Ideally the KF5 based system settings will still be > > ab

Re: Review Request 118390: Powerdevil KCM Updates

> On May 29, 2014, 8:13 a.m., Thomas Pfeiffer wrote: > > Good improvements in general! > > There are two changes which are not HIG-compliant: > > - Control labels which are written next to the controls (checkboxes, spin > > boxes etc.) do not use Title Capitalization. See > > http://techbase.kd

Re: Review Request 118347: [klipper] Port from KIntSpinBox to QSpinBox

> On May 29, 2014, 2:30 p.m., David Edmundson wrote: > > >Unfortunately this way we cannot have a plural aware suffix. > > > > Then why port away? > > Linking against kde4libsupport seems like the lesser of two evils. > > Aleix Pol Gonzalez wrote: > Well then we need to decide how we're goi

Re: Review Request 118382: [klipper] Fix i18n

> On May 29, 2014, 2:20 p.m., David Edmundson wrote: > > I'm not very happy giving a ship it to something that is ported but > > completely untested. We end up with code we think works, but doesn't work > > properly; which is worse than not touching it at all. > > > > It should be possible to

Re: Review Request 118340: Allow the kactivitymanagerd daemon to be disabled.

> On May 29, 2014, 3:02 p.m., Alex Merry wrote: > > Did you try compiling this? Because that macro doesn't exist any more - > > there is an ecm_optional_add_subdirectory() in ECM if you > > include(ECMOptionalAddSubdirectory), though. > > > > However, I think an explicit option(), with a usefu

Re: Review Request 118251: Small improvments to FadingNode and IconItem

> On May 22, 2014, 10:02 a.m., David Edmundson wrote: > > src/declarativeimports/core/fadingnode.cpp, line 87 > > > > > > Now it will animate backwards? > > > > Unless you change the vertex shader too. >

Re: Review Request 118073: Use QHostInfo in kio_nfs

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118073/#review58735 --- Ship it! nfs/kio_nfs.cpp

Re: Review Request 118340: Allow the kactivitymanagerd daemon to be disabled.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118340/#review58733 --- Did you try compiling this? Because that macro doesn't exist a

Re: Review Request 118290: Streamline Comment fields of KCMs

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118290/#review58732 --- Ship it! - David Edmundson On May 27, 2014, 12:03 a.m., Seb

Re: Review Request 118340: Allow the kactivitymanagerd daemon to be disabled.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118340/#review58731 --- This doesn't look great to me. We'd have to release another 4.

Re: Review Request 118347: [klipper] Port from KIntSpinBox to QSpinBox

> On May 29, 2014, 2:30 p.m., David Edmundson wrote: > > >Unfortunately this way we cannot have a plural aware suffix. > > > > Then why port away? > > Linking against kde4libsupport seems like the lesser of two evils. > > Aleix Pol Gonzalez wrote: > Well then we need to decide how we're goi

Re: Review Request 118347: [klipper] Port from KIntSpinBox to QSpinBox

> On May 29, 2014, 2:30 p.m., David Edmundson wrote: > > >Unfortunately this way we cannot have a plural aware suffix. > > > > Then why port away? > > Linking against kde4libsupport seems like the lesser of two evils. Well then we need to decide how we're going to get to the proper fix. We can'

Re: Review Request 118347: [klipper] Port from KIntSpinBox to QSpinBox

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118347/#review58724 --- >Unfortunately this way we cannot have a plural aware suffix.

Re: Review Request 118382: [klipper] Fix i18n

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118382/#review58723 --- Ship it! I'm not very happy giving a ship it to something tha

Re: Ship with Aurorae and Qtcurve or not...

On Thursday 15 May 2014 11:39:00 Jens Reuterberg wrote: > Ok so after the feedback from the Beta Release an issue that we knew was > coming have happened. Visuals being the most easily accessible bit of > anything technical, people have reacted negatively to the lack of change. just to give a shot

Re: Review Request 118155: adapt to ecm_add_tests so that tests can be found

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118155/#review58704 --- Ship it! Builds and tests pass for me on Linux. I think we do

Re: Review Request 118390: Powerdevil KCM Updates

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118390/#review58693 --- Thanks for looking into this! See my issues below, some of the

Re: Review Request 118390: Powerdevil KCM Updates

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118390/#review58692 --- Good improvements in general! There are two changes which are

Re: Review Request 118388: rename systemsettings binary to systemsettings5

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118388/#review58690 --- Code wise, this change looks fine. In terms of renaming the de