> On May 29, 2014, 11:02 a.m., Alex Merry wrote: > > Did you try compiling this? Because that macro doesn't exist any more - > > there is an ecm_optional_add_subdirectory() in ECM if you > > include(ECMOptionalAddSubdirectory), though. > > > > However, I think an explicit option(), with a useful help-text, would be > > better. > > Alex Merry wrote: > Ah, seeing David's comment made me realise I hadn't clocked the branch (I > generally assume anything the kdeframeworks group has been added to is a > frameworks branch). Although my point still stands about using option() to > get a more useful help-text.
Sorry for the confusion, I wasn't sure where exactly to address the RR, so I addressed it to all the places that seemed relevant. If David is ok with this patch, and it has a chance of going in I'll change it to use an explicit option. I originally took the path of least resistance, as most users wouldn't see this or care. But the explicit option would make the option definitely easier to understand. - Matthew ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118340/#review58733 ----------------------------------------------------------- On May 27, 2014, 1:27 a.m., Matthew Dawson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118340/ > ----------------------------------------------------------- > > (Updated May 27, 2014, 1:27 a.m.) > > > Review request for KDE Frameworks, Plasma and Ivan Čukić. > > > Repository: kactivities > > > Description > ------- > > To allow for the library to be co-installed with the frameworks version, > allow the daemon to be disabled. > > I'm not sure if this is the best way to do this. If there is any better way, > I'll update the patch as appropriate. > > > Diffs > ----- > > src/CMakeLists.txt b4733648fd53ebd681694f185cc5b23f51dfd3f9 > > Diff: https://git.reviewboard.kde.org/r/118340/diff/ > > > Testing > ------- > > Visually inspected install directories. Seems to remove only what is > necessary. > > > Thanks, > > Matthew Dawson > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
