Re: Plasma Addons

On Saturday 24 May 2014 00:23:45 David Edmundson wrote: > Hey, > > we've started to get bug reports on plasma-addons. It appears they're > distributed as part of OpenSuse RPMs. > > Can I confirm our position on what we're doing here, based on our > conversation last sprint. > > 1) They will not

Review Request 118290: Streamline Comment fields of KCMs

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118290/ --- Review request for Plasma. Repository: plasma-desktop Description -

Oxygen font, underline looks odd

Hi, I noticed this in a review request from sebas that included a few screenshots [1, 2]. If you look at the "C" in configure and the "D" in defaults you will see that the underline is way to close to the character. It shouldn't touch it. There should be "some" space between the character and the

Re: Notification bloat (4.xx)

On Sat, May 24, 2014 at 12:54 AM, Christoph Feck wrote: > On Friday 23 May 2014 22:58:21 Mark Gaiser wrote: >> On Thu, May 22, 2014 at 8:41 PM, Christoph Feck > wrote: >> > On Thursday 22 May 2014 20:23:00 Mark Gaiser wrote: >> >> Hi, >> >> >> >> First of all, i have no solution for this. I've ju

Re: Notification bloat (4.xx)

There definitely needs to be better logic when it comes to showing certain types of notifications. One of KDE's strengths is that all notifications are channeled through the same system, and so KDE can control the behavior of all notification interruptions. I'm not sure at what level this "behavio

Plasma Next visual polish feedback from VDG core folks

Hello all, I just had a quick question. If I have some feedback on areas to visually polish up for the Plasma Next release, should I file a bug or just share them via the email list? I honestly would rather just pitch in and submit review requests for patches but, unfortunately, I just don't have

Re: Notification bloat (4.xx)

On Friday 23 May 2014 22:58:21 Mark Gaiser wrote: > On Thu, May 22, 2014 at 8:41 PM, Christoph Feck wrote: > > On Thursday 22 May 2014 20:23:00 Mark Gaiser wrote: > >> Hi, > >> > >> First of all, i have no solution for this. I've just observed an > >> issue with the notification system that migh

Plasma Addons

Hey, we've started to get bug reports on plasma-addons. It appears they're distributed as part of OpenSuse RPMs. Can I confirm our position on what we're doing here, based on our conversation last sprint. 1) They will not be released with the plasma release next month I think to do so would unde

Build failed in Jenkins: plasma-desktop_master_qt5 #225

See Changes: [scripty] SVN_SILENT made messages (.desktop file) [notmart] remove the notebook case [notmart] don't auto resize when the panel controller is open -- Started by user Ben Cooks

Re: Notification bloat (4.xx)

On Thu, May 22, 2014 at 8:41 PM, Christoph Feck wrote: > On Thursday 22 May 2014 20:23:00 Mark Gaiser wrote: >> Hi, >> >> First of all, i have no solution for this. I've just observed an >> issue with the notification system that might benefit of >> improvements when we all brainstorm here about h

Build failed in Jenkins: plasma-workspace_master_qt5 #270

See Changes: [sebas] noise-- [sebas] Less chatty systray [sebas] less chatty devicenotifier [sebas] Clean up Battery Monitor [sebas] Align extra info to the slider [sebas] improve spacing and alignment a bit more [sebas] Fix

Re: Review Request 118272: batterymonitor visual cleanups

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118272/ --- (Updated May 23, 2014, 7:21 p.m.) Status -- This change has been mar

Re: Review Request 118272: batterymonitor visual cleanups

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118272/#review58379 --- This review has been submitted with commit 75fe56a6aa79f3730f

Re: Review Request 118277: [1/2] Make sure we update the calendar on date change

> On May 23, 2014, 6:02 p.m., Mark Gaiser wrote: > > Hi Martin, > > > > I would like to suggest a different approach. > > > > 1. You want to know the current day (which the model and calendar component > > don't expose). > > 2. You want the daysModel data to update when the clock ticks over 12

Re: Review Request 118277: [1/2] Make sure we update the calendar on date change

> On May 23, 2014, 4:02 p.m., Mark Gaiser wrote: > > Hi Martin, > > > > I would like to suggest a different approach. > > > > 1. You want to know the current day (which the model and calendar component > > don't expose). > > 2. You want the daysModel data to update when the clock ticks over 12

Build failed in Jenkins: plasma-workspace_master_qt5 #269

See Changes: [notmart] the shell package allows external paths -- Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit Building remotely on LinuxSlave - 3 (PACKAGER LI

Re: Review Request 118277: [1/2] Make sure we update the calendar on date change

> On May 23, 2014, 6:02 p.m., Mark Gaiser wrote: > > Hi Martin, > > > > I would like to suggest a different approach. > > > > 1. You want to know the current day (which the model and calendar component > > don't expose). > > 2. You want the daysModel data to update when the clock ticks over 12

Re: Review Request 118275: Remove duplicated code in showEvent and constructor

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118275/#review58365 --- flags and type might be needed in the show event. I recommend

Re: Review Request 118272: batterymonitor visual cleanups

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118272/#review58364 --- Ship it! I haven't tested but I trust you on this. Any improv

Re: Review Request 118277: [1/2] Make sure we update the calendar on date change

> On May 23, 2014, 4:02 p.m., Mark Gaiser wrote: > > Hi Martin, > > > > I would like to suggest a different approach. > > > > 1. You want to know the current day (which the model and calendar component > > don't expose). > > 2. You want the daysModel data to update when the clock ticks over 12

Re: Review Request 118277: [1/2] Make sure we update the calendar on date change

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118277/#review58362 --- Hi Martin, I would like to suggest a different approach. 1.

Re: Review Request 118277: [1/2] Make sure we update the calendar on date change

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118277/#review58361 --- Ship it! Ship It! - Sebastian Kügler On May 23, 2014, 3:22

Re: Review Request 118278: [2/2] Make sure we update the calendar on date change

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118278/#review58360 --- Ship it! Looks good. Thanks! applets/digital-clock/package/

Re: Review Request 118278: [2/2] Make sure we update the calendar on date change

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118278/#review58359 --- Ship it! Ship It! - David Edmundson On May 23, 2014, 3:25

Build failed in Jenkins: plasma-workspace_master_qt5 #268

See Changes: [mklapetek] [digital-clock] Replace sizing timer with fontSizeMode property -- Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit Building remotely on L

Review Request 118278: [2/2] Make sure we update the calendar on date change

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118278/ --- Review request for Plasma. Repository: plasma-workspace Description ---

Re: Review Request 118274: [digital-clock] Replace sizing timer with fontSizeMode property

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118274/#review58358 --- This review has been submitted with commit 3fec017438b72d9602

Re: Review Request 118274: [digital-clock] Replace sizing timer with fontSizeMode property

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118274/ --- (Updated May 23, 2014, 3:24 p.m.) Status -- This change has been mar

Review Request 118277: [1/2] Make sure we update the calendar on date change

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118277/ --- Review request for Plasma. Repository: plasma-framework Description ---

Re: Review Request 118274: [digital-clock] Replace sizing timer with fontSizeMode property

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118274/#review58357 --- Ship it! Ship It! - Sebastian Kügler On May 23, 2014, 10:3

Re: Review Request 118272: batterymonitor visual cleanups

> On May 22, 2014, 11:08 p.m., Mark Gaiser wrote: > > applets/batterymonitor/contents/ui/PopupDialog.qml, lines 78-81 > > > > > > I don't know this code so i'm not going to comment on how it should or > > should

Re: Review Request 118272: batterymonitor visual cleanups

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118272/ --- (Updated May 23, 2014, 2:05 p.m.) Review request for Plasma and Kai Uwe B

Re: Review Request 118272: batterymonitor visual cleanups

> On May 23, 2014, 8:05 a.m., Martin Klapetek wrote: > > applets/batterymonitor/contents/ui/BatteryItem.qml, line 156 > > > > > > Use .floor/.round here to avoid half-pixels > > > > ...and basically ever

Review Request 118275: Remove duplicated code in showEvent and constructor

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118275/ --- Review request for Plasma. Repository: plasma-workspace Description ---

Build failed in Jenkins: plasma-workspace_master_qt5 #267

See Changes: [kde] Don't change visibility mode on panel when opening config [kde] Remove pointless double config sync -- Started by remote host 2a01:4f8:160:9363::9 with note: Triggered b

Re: Icons for Paste Bin and Paste

Good point... maybe we are overthinking this? On Friday 23 May 2014 13.38.49 Sebastian Kügler wrote: > On Friday, May 23, 2014 13:24:20 Jens wrote: > > I know that the work with global login is appearently rather > > frustrating (as I've heard from you guys) since Google and > > Facebook and Twitt

Re: Icons for Paste Bin and Paste

On Friday, May 23, 2014 13:24:20 Jens wrote: > I know that the work with global login is appearently rather > frustrating (as I've heard from you guys) since Google and > Facebook and Twitter all enjoy to swap stuff around making one > method completely useless after a short while. > > Marco if

Re: Icons for Paste Bin and Paste

I know that the work with global login is appearently rather frustrating (as I've heard from you guys) since Google and Facebook and Twitter all enjoy to swap stuff around making one method completely useless after a short while. Marco if you feel like it lets talk more via G+ about this. I pos

Re: Icons for Paste Bin and Paste

btw, we do have an embyonic framework for sharing stuff since a while, it was never really finished or added by default, or marketed in any way mostly for two reasons, we are still waiting for a "global login" thing to be finished (to be logged in system wide to twitter/social web BS whatever) and

Re: Notification bloat (4.xx)

On Friday 23 May 2014 10:16:03 Martin Klapetek wrote: > Thomas - what's your opinion here? Should notifications about file > operations be persistent or not? I just invited Celeste to this discussion. Given that she wrote her PhD thesis about desktop notifications, she's the expert here ;)

Re: Icons for Paste Bin and Paste

Oh awesome... TBH I've been thinking of talking to Albert Vaca and some other guys about doing some unified "Sharing"/"Cloudbox" thing... and then market the SHIT out of it. (This is wy OT but the Pastebin was one of the things that attracted me directly to KDE in the first place. It's such

Re: Review Request 118274: [digital-clock] Replace sizing timer with fontSizeMode property

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118274/#review58350 --- Ship it! Ship It! - David Edmundson On May 23, 2014, 10:36

Re: Review Request 118274: [digital-clock] Replace sizing timer with fontSizeMode property

> On May 23, 2014, 12:46 p.m., David Edmundson wrote: > > applets/digital-clock/package/contents/ui/DigitalClock.qml, lines 87-88 > > > > > > So I'm thinking these 2 are unused now? No, they still are. The sizehe

Re: Review Request 118274: [digital-clock] Replace sizing timer with fontSizeMode property

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118274/#review58347 --- applets/digital-clock/package/contents/ui/DigitalClock.qml

Build failed in Jenkins: plasma-workspace_master_qt5 #266

See Changes: [mklapetek] Don't check for free disk space right after module load -- Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit Building remotely on LinuxSlav

Re: Review Request 118274: [digital-clock] Replace sizing timer with fontSizeMode property

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118274/ --- (Updated May 23, 2014, 12:36 p.m.) Review request for Plasma. Changes -

Re: Review Request 118274: [digital-clock] Replace sizing timer with fontSizeMode property

> On May 23, 2014, 12:07 p.m., David Edmundson wrote: > > applets/digital-clock/package/contents/ui/DigitalClock.qml, line 84 > > > > > > we should take this size from the sizeHelper I think? > > They might po

Re: [plasma-framework] examples/dataengines: Fix build with examples

On Friday, May 23, 2014 12:18:55 Marco Martin wrote: > I think it's a counter-effect of when i removed KConfigWidgets from > libplasma. there is definitely a problem in the cmake there, qt5::gui > should be in public in libplasma, right? That's how I understand Aleix. -- sebas http://www.kde.org

Re: Icons for Paste Bin and Paste

On Thursday, May 22, 2014 19:33:40 Thomas Pfeiffer wrote: > On Thursday 22 May 2014 19:17:22 Jens wrote: > > Ah the issue that there are TWO pastebin, one good for images (of > > all kinds, including the link above btw) as well as text and one not > > so good that is just for text > > > > > > > >

Re: [plasma-framework] examples/dataengines: Fix build with examples

I think it's a counter-effect of when i removed KConfigWidgets from libplasma. there is definitely a problem in the cmake there, qt5::gui should be in public in libplasma, right? On Friday 23 May 2014, Sebastian Kügler wrote: > CC:ing plasma-devel. Any input on this? (I just fixed the build in th

Re: [plasma-framework] examples/dataengines: Fix build with examples

CC:ing plasma-devel. Any input on this? (I just fixed the build in the most obvious way, perhaps someone knows why Qt5::Gui had been removed from the implicit public targets in the first place? On Friday, May 23, 2014 00:54:17 Aleix Pol wrote: > KF5::Plasma should have Qt5::Gui as public depende

Re: Review Request 118274: [digital-clock] Replace sizing timer with fontSizeMode property

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118274/#review58345 --- Love it. applets/digital-clock/package/contents/ui/DigitalCl

Review Request 118274: [digital-clock] Replace sizing timer with fontSizeMode property

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118274/ --- Review request for Plasma. Bugs: 335147 https://bugs.kde.org/show_bug

Build failed in Jenkins: plasma-workspace_master_qt5 #265

See Changes: [notmart] don't use a lambda -- Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit Building remotely on LinuxSlave - 3 (PACKAGER LINBUILDER) in workspac

Build failed in Jenkins: plasma-workspace_master_qt5 #264

See Changes: [notmart] don't delete the config immediately -- Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit Building remotely on LinuxSlave - 3 (PACKAGER LINBUI

Build failed in Jenkins: plasma-desktop_master_qt5 #224

See Changes: [notmart] don't auto resize when the panel controller is open -- Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit Building remotely on LinuxSlave - 4 (P

Build failed in Jenkins: plasma-desktop_master_qt5 #223

See Changes: [notmart] remove the notebook case -- Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit Building remotely on LinuxSlave - 4 (PACKAGER LINBUILDER) in work

Re: Review Request 118272: batterymonitor visual cleanups

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118272/#review58343 --- Looks great, thanks! I was actually thinking of removing this

Re: Review Request 117954: Port keditfiletype away from kde4support

> On May 20, 2014, 5:08 p.m., Alexander Potashev wrote: > > You probably need to check in CMakeLists.txt that version of > > shared-mime-info is at least 0.40. > > Aurélien Gâteau wrote: > shared-mime-info is only required at run time so I am not sure it makes > sense to check at build tim

Re: Review Request 117954: Port keditfiletype away from kde4support

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117954/ --- (Updated May 23, 2014, 10:45 a.m.) Review request for Plasma and David Fa

Re: Notification bloat (4.xx)

On Fri, May 23, 2014 at 10:23 AM, Kai Uwe Broulik wrote: > > In Plasma Next, the notifications stack/history now contains only and > only persistent notifications, all the rest just flies by and disappears > forever after the timeout. > > Hi, > > I think I already brought this up somewhere but do

Re: Notification bloat (4.xx)

> In Plasma Next, the notifications stack/history now contains only and only > persistent notifications, all the rest just flies by and disappears forever > after the timeout. Hi, I think I already brought this up somewhere but do the notification watch for user interaction? Would be great if

Build failed in Jenkins: plasma-workspace_master_qt5 #263

See Changes: [mgraesslin] [klipper] Show filter widget before sending key events to it [scripty] SVN_SILENT made messages (.desktop file) -- Started by remote host 2a01:4f8:160:9363::9 wit

Build failed in Jenkins: plasma-desktop_master_qt5 #222

See Changes: [scripty] SVN_SILENT made messages (.desktop file) -- Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit Building remotely on LinuxSlave - 4 (PACKAGER LIN

Re: Notification bloat (4.xx)

Hey, On Thu, May 22, 2014 at 8:23 PM, Mark Gaiser wrote: > Hi, > > First of all, i have no solution for this. I've just observed an issue > with the notification system that might benefit of improvements when > we all brainstorm here about how it should behave. This is for KDE > 4.xx, but i'm g

Re: Icons for Paste Bin and Paste

Haha! That was AWESOME! ok okokok I wanna do that! On Thursday 22 May 2014 21.54.33 Marco Martin wrote: > what about the paperclip bended in cloud shape? > (admittely this attempt isn't that great, but maybe can be evolved a bit) > > On Thursday 22 May 2014, Jens wrote: > > I already tried it a

Re: Review Request 118272: batterymonitor visual cleanups

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118272/#review58340 --- applets/batterymonitor/contents/ui/BatteryItem.qml