----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118277/#review58361 -----------------------------------------------------------
Ship it! Ship It! - Sebastian Kügler On May 23, 2014, 3:22 p.m., Martin Klapetek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118277/ > ----------------------------------------------------------- > > (Updated May 23, 2014, 3:22 p.m.) > > > Review request for Plasma. > > > Repository: plasma-framework > > > Description > ------- > > This is the first part of a fix for updating the calendar properly when date > changes (after midnight). > > It introduces new property on MonthView - "today". This property is updated > by dataengine (or can be a timer too, but we already get signals from > dataengine every 30 seconds) and is never updated by the code itself. > Furthermore, the DayDelegate is now bound to it, so when "today" changes, the > selection rectangle in the calendar should also change. And finally, the > selected item in the grid is cleared if MonthView's date property is cleared > (which is second part of this patch, to the applet itself). > > > Diffs > ----- > > src/declarativeimports/calendar/qml/DayDelegate.qml 552769c > src/declarativeimports/calendar/qml/DaysCalendar.qml 6054a9d > src/declarativeimports/calendar/qml/MonthView.qml e064f01 > > Diff: https://git.reviewboard.kde.org/r/118277/diff/ > > > Testing > ------- > > > Thanks, > > Martin Klapetek > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
