Re: Re: Review Request 117450: Add Milou to the default panel layout

2014-04-13 Thread Martin Gräßlin
On Saturday 12 April 2014 20:03:22 you wrote: > On Saturday, April 12, 2014 09:14:38 AM Martin Gräßlin wrote: > > "My concern is more on how the users will see it. Will they understand > > that > > Milou and Kickoff work differently or will they think that we ship > > redundant features by default?

Re: Review Request 117450: Add Milou to the default panel layout

2014-04-13 Thread Hans Chen
I personally don't think that the overlap is too big. The way I see it: a) Kickoff: The application launcher, so its primary purpose is to launch applications. The search bar should be used to filter the "contents" of Kickoff, i.e., find items that you would normally find in Kickoff. (I know that

Re: Review Request 117510: Remove extractAndSaveDurationInfo() and use the more generic setValueForRole()

2014-04-13 Thread Ashish Madeti
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117510/ --- (Updated April 13, 2014, 4:59 p.m.) Status -- This change has been m

Re: Review Request 117510: Remove extractAndSaveDurationInfo() and use the more generic setValueForRole()

2014-04-13 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117510/#review55623 --- This review has been submitted with commit 243502eb86bafde583

Re: Review Request 117510: Remove extractAndSaveDurationInfo() and use the more generic setValueForRole()

2014-04-13 Thread Sinny Kumari
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117510/#review55607 --- Ship it! Ship It! libs/mediacenter/media.cpp

Re: Review Request 117447: Runner - QueryMatch: Allow each match to give a category

2014-04-13 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117447/ --- (Updated April 13, 2014, 2:18 p.m.) Status -- This change has been m

Re: Review Request 117447: Runner - QueryMatch: Allow each match to give a category

2014-04-13 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117447/#review55596 --- This review has been submitted with commit 94ec83ce988c7f1242

Review Request 117542: Improve battery monitor

2014-04-13 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117542/ --- Review request for Plasma. Repository: plasma-workspace Description ---

Re: Review Request 117540: Improve powermanagement dataengine

2014-04-13 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117540/ --- (Updated April 13, 2014, 1:41 p.m.) Review request for Plasma. Changes

Review Request 117540: Improve powermanagement dataengine

2014-04-13 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117540/ --- Review request for Plasma. Repository: plasma-workspace Description ---

Review Request 117533: Fix batterymonitor popup closing when batter full, AC plugged in, and touching brightness slider

2014-04-13 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117533/ --- Review request for Plasma and Christoph Feck. Bugs: 321823 http://bug