-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117533/
-----------------------------------------------------------
Review request for Plasma and Christoph Feck.
Bugs: 321823
http://bugs.kde.org/show_bug.cgi?id=321823
Repository: kde-workspace
Description
-------
This fixes the battery monitor popup closing when the AC is plugged in, all
batteries are full, and any of the brightness sliders were touched.
The issue is that changing the plasmoid.status (to Passive?) while the popup is
open, causes it to close. Even a check if the current status is the same and
not changing it did not help as the plasmoid gets "NeedAttentionStatus" for
some reason when it opens. This patch makes it never ever touch the
plasmoid.status property while the popup is opened. To ensure the status is
still properly set, it will force an update when closing the popup.
It also changes from legacy string-based enums to real enums.
Diffs
-----
plasma/generic/applets/batterymonitor/contents/code/logic.js def21e5
plasma/generic/applets/batterymonitor/contents/ui/batterymonitor.qml e87cf78
Diff: https://git.reviewboard.kde.org/r/117533/diff/
Testing
-------
Changing brightness does not cause the popup to close and status is still
properly updated while the popup is not shown.
Thanks,
Kai Uwe Broulik
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
