Re: Letting users customize the default background on PMC homescreen (Was: Re: Ideas Critical to PMC)

2014-02-26 Thread Sinny Kumari
On Thu, Feb 27, 2014 at 2:04 AM, Thomas Pfeiffer wrote: > On Tuesday 25 February 2014 10:48:47 Shantanu Tushar Jha wrote: > > Hi Harshit, > > > > First of all, just a note, whenever you have a new thing to discuss, it > is > > a bad idea to reply to an existing thread which is not directly related

Re: Review Request 116063: Implementation of the backspace key as an option to go back to the previous window.

2014-02-26 Thread Harshit Agarwal
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116063/ --- (Updated Feb. 27, 2014, 4:52 a.m.) Status -- This change has been ma

Re: Review Request 116063: Implementation of the backspace key as an option to go back to the previous window.

2014-02-26 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116063/#review50997 --- This review has been submitted with commit 125ce5b22dd7f49834

Re: Review Request 116063: Implementation of the backspace key as an option to go back to the previous window.

2014-02-26 Thread Shantanu Tushar
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116063/#review50996 --- Ship it! Just checked again on master instead of my branch. W

Re: Letting users customize the default background on PMC homescreen (Was: Re: Ideas Critical to PMC)

2014-02-26 Thread Thomas Pfeiffer
On Tuesday 25 February 2014 10:48:47 Shantanu Tushar Jha wrote: > Hi Harshit, > > First of all, just a note, whenever you have a new thing to discuss, it is > a bad idea to reply to an existing thread which is not directly related > (this is popularly known as hacking others' threads :P) > > To t

Selecting wallpaper during Activity creation

2014-02-26 Thread Thomas Pfeiffer
Hi everyone, when Ivan posted a screenshot of the Activities sidebar on Google+ recently, I liked it a lot! The only thing I found missing was the selection of a wallpaper right in the Activity creation dialog, like we have in Plasma Active [1]. The big advantage I see in this is that it assures

Re: javascript interactive console

2014-02-26 Thread Kevin Krammer
On Wednesday, 2014-02-26, 20:07:58, Marco Martin wrote: > On Wednesday 26 February 2014 19:51:54 Kevin Krammer wrote: > > > if some kind of api is done to link the whatever bindings are in the > > > application that is using qtscript and the console (just something > > > really > > > easy, like run

Re: javascript interactive console

2014-02-26 Thread Marco Martin
On Wednesday 26 February 2014 19:51:54 Kevin Krammer wrote: > > if some kind of api is done to link the whatever bindings are in the > > application that is using qtscript and the console (just something really > > easy, like run this string with a script) then i guess it would be > > realistic pro

Re: Review Request 116085: welcome back the javascript interactive console

2014-02-26 Thread Marco Martin
> On Feb. 26, 2014, 5:43 p.m., Hrvoje Senjan wrote: > > src/shell/CMakeLists.txt, line 20 > > > > > > This would mean: > > a) propagate KTextEditor to part of the KF5 releases (that was not the > > case with

Re: javascript interactive console

2014-02-26 Thread Kevin Krammer
On Wednesday, 2014-02-26, 19:00:49, Marco Martin wrote: > On Wednesday 26 February 2014 18:51:34 Kevin Krammer wrote: > > On Wednesday, 2014-02-26, 11:27:04, Marco Martin wrote: > > > Hi all, > > > yesterday i was toying with porting the javascript interactive console > > > for > > > plasma-shell.

Re: Review Request 116085: welcome back the javascript interactive console

2014-02-26 Thread Hrvoje Senjan
> On Feb. 26, 2014, 5:43 p.m., Hrvoje Senjan wrote: > > src/shell/CMakeLists.txt, line 20 > > > > > > This would mean: > > a) propagate KTextEditor to part of the KF5 releases (that was not the > > case with

Re: javascript interactive console

2014-02-26 Thread Marco Martin
On Wednesday 26 February 2014 15:00:36 Martin Gräßlin wrote: > > so, opinion poll: > > move plasma-shell to kde-workspace? (btw, is kde-workspace the final > > nameit's going to have? what is the status of the splitting it?) > > Right it could be put together with the other plasma parts when split

Re: javascript interactive console

2014-02-26 Thread Marco Martin
On Wednesday 26 February 2014 18:51:34 Kevin Krammer wrote: > On Wednesday, 2014-02-26, 11:27:04, Marco Martin wrote: > > Hi all, > > yesterday i was toying with porting the javascript interactive console for > > plasma-shell. > > Maybe that is a stupid question, but how Plasma specific is this co

Re: Review Request 116085: welcome back the javascript interactive console

2014-02-26 Thread Marco Martin
> On Feb. 26, 2014, 5:43 p.m., Hrvoje Senjan wrote: > > src/shell/CMakeLists.txt, line 20 > > > > > > This would mean: > > a) propagate KTextEditor to part of the KF5 releases (that was not the > > case with

Re: javascript interactive console

2014-02-26 Thread Kevin Krammer
On Wednesday, 2014-02-26, 11:27:04, Marco Martin wrote: > Hi all, > yesterday i was toying with porting the javascript interactive console for > plasma-shell. Maybe that is a stupid question, but how Plasma specific is this console? Would it be something other QtScript/QJSEngine using applications

Re: Review Request 116085: welcome back the javascript interactive console

2014-02-26 Thread Hrvoje Senjan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116085/#review50965 --- src/shell/CMakeLists.txt

Re: Review Request 116085: welcome back the javascript interactive console

2014-02-26 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116085/ --- (Updated Feb. 26, 2014, 5:37 p.m.) Status -- This change has been ma

Re: Review Request 116085: welcome back the javascript interactive console

2014-02-26 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116085/#review50963 --- This review has been submitted with commit 1fd741b5d30929d183

Re: Review Request 116085: welcome back the javascript interactive console

2014-02-26 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116085/#review50960 --- Ship it! Ship It! - David Edmundson On Feb. 26, 2014, 4:03

Re: Review Request 115764: Make playlist model aware of currently playing media

2014-02-26 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115764/#review50956 --- This review has been submitted with commit 125a9e295a4e1f0b9b

Re: Review Request 115764: Make playlist model aware of currently playing media

2014-02-26 Thread Shantanu Tushar
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115764/ --- (Updated Feb. 26, 2014, 4:07 p.m.) Status -- This change has been ma

Re: Review Request 116085: welcome back the javascript interactive console

2014-02-26 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116085/ --- (Updated Feb. 26, 2014, 4:03 p.m.) Review request for Plasma. Repositor

Re: Review Request 116085: welcome back the javascript interactive console

2014-02-26 Thread Marco Martin
> On Feb. 26, 2014, 3:47 p.m., David Edmundson wrote: > > src/shell/interactiveconsole.cpp, line 57 > > > > > > Are you not doing that on line 130? yeah, comes from the copy of the oold file ;) > On Feb. 26, 20

Re: Review Request 115695: Rework KNotification to work without KNotify daemon

2014-02-26 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115695/ --- (Updated Feb. 26, 2014, 4:53 p.m.) Status -- This change has been di

Re: Review Request 116085: welcome back the javascript interactive console

2014-02-26 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116085/#review50941 --- src/shell/interactiveconsole.h

Re: Review Request 116027: High dpi support for Svg

2014-02-26 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116027/ --- (Updated Feb. 26, 2014, 3:42 p.m.) Status -- This change has been ma

Re: Review Request 116027: High dpi support for Svg

2014-02-26 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116027/#review50951 --- This review has been submitted with commit b2fec905b597e8320c

Re: Review Request 116024: Port IconItem to native QSGTexture

2014-02-26 Thread Marco Martin
> On Feb. 24, 2014, 4:55 p.m., Marco Martin wrote: > > not sure how much will be visible in the end result. > > tough if i understood correctly how it works, it does the animation by > > animating the opacity of the old image from 1 to 0, and the opacity of the > > new one from 0 to 1. > > > >

Re: Review Request 116027: High dpi support for Svg

2014-02-26 Thread David Edmundson
> On Feb. 25, 2014, 11:10 a.m., David Edmundson wrote: > > src/plasma/svg.cpp, line 132 > > > > > > Do we want to have size and devicePixelRatio separate in the cache ID? > > > > It means if I request 20

Re: Review Request 116027: High dpi support for Svg

2014-02-26 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116027/#review50944 --- Ship it! Ship It! - David Edmundson On Feb. 24, 2014, 5:30

Re: Review Request 116063: Implementation of the backspace key as an option to go back to the previous window.

2014-02-26 Thread Shantanu Tushar
> On Feb. 26, 2014, 2:52 p.m., Shantanu Tushar wrote: > > I see a weird behavior with this patch, if you follow these steps- > > 1. Open PMC, select "All Videos" > > 2. Press backspace to go back to home screen > > 3. Press enter to go to "All Videos" again > > > > This leads to a blank browser

Review Request 116085: welcome back the javascript interactive console

2014-02-26 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116085/ --- Review request for Plasma. Repository: plasma-framework Description ---

Re: Review Request 116063: Implementation of the backspace key as an option to go back to the previous window.

2014-02-26 Thread Harshit Agarwal
> On Feb. 26, 2014, 2:52 p.m., Shantanu Tushar wrote: > > I see a weird behavior with this patch, if you follow these steps- > > 1. Open PMC, select "All Videos" > > 2. Press backspace to go back to home screen > > 3. Press enter to go to "All Videos" again > > > > This leads to a blank browser

Re: Review Request 116063: Implementation of the backspace key as an option to go back to the previous window.

2014-02-26 Thread Shantanu Tushar
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116063/#review50939 --- I see a weird behavior with this patch, if you follow these st

Re: Review Request 116024: Port IconItem to native QSGTexture

2014-02-26 Thread David Edmundson
> On Feb. 24, 2014, 4:55 p.m., Marco Martin wrote: > > not sure how much will be visible in the end result. > > tough if i understood correctly how it works, it does the animation by > > animating the opacity of the old image from 1 to 0, and the opacity of the > > new one from 0 to 1. > > > >

Re: Re: javascript interactive console

2014-02-26 Thread Martin Gräßlin
On Wednesday 26 February 2014 12:56:41 Marco Martin wrote: > On Wednesday 26 February 2014 11:36:16 Martin Gräßlin wrote: > > On Wednesday 26 February 2014 11:27:04 Marco Martin wrote: > > > Hi all, > > > yesterday i was toying with porting the javascript interactive console > > > for > > > plasma-

Re: Review Request 116081: Removed unused dependencies

2014-02-26 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116081/#review50928 --- This review has been submitted with commit 3b7bac1e780d0440ef

Re: Review Request 116081: Removed unused dependencies

2014-02-26 Thread Michael Palimaka
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116081/ --- (Updated Feb. 26, 2014, 12:41 p.m.) Status -- This change has been m

Re: Review Request 116081: Removed unused dependencies

2014-02-26 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116081/#review50927 --- Ship it! Ship It! - David Edmundson On Feb. 26, 2014, 12:3

Review Request 116081: Removed unused dependencies

2014-02-26 Thread Michael Palimaka
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116081/ --- Review request for Plasma. Repository: plasma-framework Description ---

Re: javascript interactive console

2014-02-26 Thread Bhushan Shah
Hello, On Wed, Feb 26, 2014 at 5:26 PM, Marco Martin wrote: > move plasma-shell to kde-workspace IMHO No I think.. Lets see if I develop shell "Plasma ABC" I have to pull dep of kde-workspace.. instead I prefer to have separate repo for the shell.. :) Thanks! -- Bhushan Shah http://bhush9.gi

Re: Review Request 115910: Screenedge show support for Clients

2014-02-26 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115910/ --- (Updated Feb. 26, 2014, 11:57 a.m.) Status -- This change has been m

Re: javascript interactive console

2014-02-26 Thread Marco Martin
On Wednesday 26 February 2014 11:36:16 Martin Gräßlin wrote: > On Wednesday 26 February 2014 11:27:04 Marco Martin wrote: > > Hi all, > > yesterday i was toying with porting the javascript interactive console for > > plasma-shell. > > one thing that i stumbled upon is how much dependencies the thin

Re: Review Request 115910: Screenedge show support for Clients

2014-02-26 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115910/#review50924 --- This review has been submitted with commit 74e98695445ad8f9cb

Re: Review Request 115910: Screenedge show support for Clients

2014-02-26 Thread Martin Gräßlin
> On Feb. 26, 2014, 12:18 p.m., Thomas Lübking wrote: > > kwin/screenedge.cpp, line 179 > > > > > > ElectricBorderPushbackPixels is by default "1" (and not configurable by > > UI) > > Not sure if this is eno

Re: Review Request 115910: Screenedge show support for Clients

2014-02-26 Thread Thomas Lübking
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115910/#review50919 --- Ship it! See comment. But should be nice for a wild test =)

Re: javascript interactive console

2014-02-26 Thread Michael Palimaka
On 02/26/2014 09:36 PM, Martin Gräßlin wrote: > On Wednesday 26 February 2014 11:27:04 Marco Martin wrote: >> Hi all, >> yesterday i was toying with porting the javascript interactive console for >> plasma-shell. >> one thing that i stumbled upon is how much dependencies the thing has. >> >> apart

Re: javascript interactive console

2014-02-26 Thread Martin Gräßlin
On Wednesday 26 February 2014 11:27:04 Marco Martin wrote: > Hi all, > yesterday i was toying with porting the javascript interactive console for > plasma-shell. > one thing that i stumbled upon is how much dependencies the thing has. > > apart the usual removal of kde4support, it depends from new

javascript interactive console

2014-02-26 Thread Marco Martin
Hi all, yesterday i was toying with porting the javascript interactive console for plasma-shell. one thing that i stumbled upon is how much dependencies the thing has. apart the usual removal of kde4support, it depends from new things like ktexteditor,ktextbrowser etc. so, it would bump up the

Re: Review Request 116075: Provide an implementation for QPlatformSystemTrayIcon

2014-02-26 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116075/#review50911 --- +1 from me - Marco Martin On Feb. 26, 2014, 8:09 a.m., Mart

Re: Review Request 116075: Provide an implementation for QPlatformSystemTrayIcon

2014-02-26 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116075/#review50910 --- +1 from me - Marco Martin On Feb. 26, 2014, 8:09 a.m., Mart

Re: Review Request 116075: Provide an implementation for QPlatformSystemTrayIcon

2014-02-26 Thread Kevin Krammer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116075/#review50909 --- src/platformtheme/kdeplatformsystemtrayicon.h

Re: Review Request 115910: Screenedge show support for Clients

2014-02-26 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115910/#review50907 --- @Thomas: any further comments on the latest approach? - Marti

Re: Review Request 116075: Provide an implementation for QPlatformSystemTrayIcon

2014-02-26 Thread Thomas Braxton
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116075/#review50904 --- src/platformtheme/kdeplatformsystemtrayicon.cpp

Review Request 116075: Provide an implementation for QPlatformSystemTrayIcon

2014-02-26 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116075/ --- Review request for KDE Frameworks, Plasma and Marco Martin. Repository: f