----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116085/#review50941 -----------------------------------------------------------
src/shell/interactiveconsole.h <https://git.reviewboard.kde.org/r/116085/#comment35763> Is this copied from somewhere then? Update copyright if you need to, otherwise ignore this. src/shell/interactiveconsole.cpp <https://git.reviewboard.kde.org/r/116085/#comment35757> Are you not doing that on line 130? src/shell/interactiveconsole.cpp <https://git.reviewboard.kde.org/r/116085/#comment35758> m_closeWhenCompleted should be initialised to be consistent m_output should be too; but that's at least set in the ctor somewhere. src/shell/interactiveconsole.cpp <https://git.reviewboard.kde.org/r/116085/#comment35761> this isn't a very helpful debug message :) - David Edmundson On Feb. 26, 2014, 3:25 p.m., Marco Martin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/116085/ > ----------------------------------------------------------- > > (Updated Feb. 26, 2014, 3:25 p.m.) > > > Review request for Plasma. > > > Repository: plasma-framework > > > Description > ------- > > this ports the js interactive console from plasma1 and ports it way from > kde4support > > ui-wise it should look the same > > > Diffs > ----- > > src/shell/scripting/scriptengine.cpp 29735a0 > src/shell/shellcorona.cpp e84e0bf > src/shell/shellpluginloader.cpp c57b348 > src/shell/CMakeLists.txt db0e569 > src/shell/interactiveconsole.h PRE-CREATION > src/shell/interactiveconsole.cpp PRE-CREATION > src/shell/packages.h 999b4c9 > src/shell/packages.cpp 0b2aa3f > src/shell/scripting/layouttemplatepackagestructure.h abc5562 > src/shell/scripting/layouttemplatepackagestructure.cpp bc1d0ca > > Diff: https://git.reviewboard.kde.org/r/116085/diff/ > > > Testing > ------- > > tried to add plasmoids from the console > > > Thanks, > > Marco Martin > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
