Review Request 114291: Fix kde-workspace build

2013-12-03 Thread Andrea Scarpino
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114291/ --- Review request for Plasma. Repository: kde-workspace Description ---

Re: Review Request 114271: drawFloatFrame for QtQuick menus

2013-12-03 Thread Martin Gräßlin
> On Dec. 3, 2013, 3:26 p.m., David Edmundson wrote: > > kstyles/oxygen/oxygenstyle.cpp, line 2558 > > > > > > in other cases in this file I've done: > > > > if (option->styleObject->inherits("QQuickStyl

Re: Tokamak 7 Sprint: Pick dates!

2013-12-03 Thread Martin Gräßlin
On Tuesday 03 December 2013 15:57:32 Sebastian Kügler wrote: > Hi all, > > It's time to come together again and discuss Plasma development in person. > We call these meetings Tokamak, and this one will already be the 7th > edition. > > First, we'll have to pick a date, then we can confirm locatio

Re: Review Request 114271: drawFloatFrame for QtQuick menus

2013-12-03 Thread Martin Gräßlin
> On Dec. 3, 2013, 3:39 p.m., David Edmundson wrote: > > > > Yichao Yu wrote: > May I ask if how did you get the rounded corner? > > I have got this[1] kind of white frame for menu with rounded corder and > haven't found a good way to get rid of it (without interfering with other

Re: Oxygen in QtQuickControls

2013-12-03 Thread Yichao Yu
> > The anongit network has now been checked over. One mirror as it turns out > was not updating correctly, which has now been repaired. > Please retry - it should now succeed. Yep it works now. Although I have already got what I want from quickgit. Cheers, Yichao Yu > >> >> >> > >> > Thank you!

Re: Review Request 114283: Use QtQuickControls ScrollView internally in PlasmaExtraComponents.ScrollArea

2013-12-03 Thread Sebastian Kügler
On Tuesday, December 03, 2013 20:55:19 Mark Gaiser wrote: > > On Dec. 3, 2013, 8:49 p.m., Sebastian Kügler wrote: > > > I really like the idea. I think we should keep our Scroll* components in > > > to ease porting, but move away from using it for our own stuff first, > > > and then, before a first

Re: Review Request 114283: Use QtQuickControls ScrollView internally in PlasmaExtraComponents.ScrollArea

2013-12-03 Thread Marco Martin
> On Dec. 3, 2013, 8:49 p.m., Sebastian Kügler wrote: > > I really like the idea. I think we should keep our Scroll* components in to > > ease porting, but move away from using it for our own stuff first, and > > then, before a first API promise, revisit if we can remove our own > > implementa

Re: Review Request 114283: Use QtQuickControls ScrollView internally in PlasmaExtraComponents.ScrollArea

2013-12-03 Thread Marco Martin
> On Dec. 3, 2013, 8:49 p.m., Sebastian Kügler wrote: > > I really like the idea. I think we should keep our Scroll* components in to > > ease porting, but move away from using it for our own stuff first, and > > then, before a first API promise, revisit if we can remove our own > > implementa

Re: Review Request 114283: Use QtQuickControls ScrollView internally in PlasmaExtraComponents.ScrollArea

2013-12-03 Thread Mark Gaiser
> On Dec. 3, 2013, 8:49 p.m., Sebastian Kügler wrote: > > I really like the idea. I think we should keep our Scroll* components in to > > ease porting, but move away from using it for our own stuff first, and > > then, before a first API promise, revisit if we can remove our own > > implementa

Re: Review Request 114283: Use QtQuickControls ScrollView internally in PlasmaExtraComponents.ScrollArea

2013-12-03 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114283/#review45057 --- I really like the idea. I think we should keep our Scroll* comp

Re: Oxygen in QtQuickControls

2013-12-03 Thread Ben Cooksley
On Wed, Dec 4, 2013 at 4:09 AM, Yichao Yu wrote: > On Tue, Dec 3, 2013 at 10:06 AM, Yichao Yu wrote: > > On Tue, Dec 3, 2013 at 3:06 AM, Martin Klapetek > > wrote: > >> On Tue, Dec 3, 2013 at 5:18 AM, Yichao Yu wrote: > >>> > >>> On Mon, Dec 2, 2013 at 10:55 AM, Sebastian Kügler > wrote: > >>

Review Request 114283: Use QtQuickControls ScrollView internally in PlasmaExtraComponents.ScrollArea

2013-12-03 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114283/ --- Review request for Plasma. Repository: plasma-framework Description

Re: Tokamak 7 Sprint: Pick dates!

2013-12-03 Thread Mark Gaiser
On Tue, Dec 3, 2013 at 3:57 PM, Sebastian Kügler wrote: > Hi all, > > It's time to come together again and discuss Plasma development in person. We > call these meetings Tokamak, and this one will already be the 7th edition. > > First, we'll have to pick a date, then we can confirm location and th

Re: Fails to build against Qt 5.3 dev snapshot

2013-12-03 Thread Alan Alpert
On Tue, Dec 3, 2013 at 8:20 AM, Marco Martin wrote: > On Monday 02 December 2013, Alan Alpert wrote: > >> Oh, are you guys planning to release something on 5.2? I thought you >> were still in an early development phase. If you're going to release >> something, we'll have to put QQmlAbstractUrlInte

Re: Review Request 114271: drawFloatFrame for QtQuick menus

2013-12-03 Thread Yichao Yu
> On Dec. 3, 2013, 9:39 a.m., David Edmundson wrote: > > May I ask if how did you get the rounded corner? I have got this[1] kind of white frame for menu with rounded corder and haven't found a good way to get rid of it (without interfering with other things) yet. [1] http://wstaw.org/m/2013/

Re: Fails to build against Qt 5.3 dev snapshot

2013-12-03 Thread Marco Martin
On Monday 02 December 2013, Alan Alpert wrote: > Oh, are you guys planning to release something on 5.2? I thought you > were still in an early development phase. If you're going to release > something, we'll have to put QQmlAbstractUrlInterceptor back in - just > keep in mind it may be deprecated

Re: Oxygen in QtQuickControls

2013-12-03 Thread Yichao Yu
On Tue, Dec 3, 2013 at 10:06 AM, Yichao Yu wrote: > On Tue, Dec 3, 2013 at 3:06 AM, Martin Klapetek > wrote: >> On Tue, Dec 3, 2013 at 5:18 AM, Yichao Yu wrote: >>> >>> On Mon, Dec 2, 2013 at 10:55 AM, Sebastian Kügler wrote: >>> > On Monday, December 02, 2013 15:30:26 David Edmundson wrote: >>

Re: Oxygen in QtQuickControls

2013-12-03 Thread Yichao Yu
On Tue, Dec 3, 2013 at 3:06 AM, Martin Klapetek wrote: > On Tue, Dec 3, 2013 at 5:18 AM, Yichao Yu wrote: >> >> On Mon, Dec 2, 2013 at 10:55 AM, Sebastian Kügler wrote: >> > On Monday, December 02, 2013 15:30:26 David Edmundson wrote: >> >> I'm working to fix using QtQuickControls with Oxygen. >

Tokamak 7 Sprint: Pick dates!

2013-12-03 Thread Sebastian Kügler
Hi all, It's time to come together again and discuss Plasma development in person. We call these meetings Tokamak, and this one will already be the 7th edition. First, we'll have to pick a date, then we can confirm location and think about travel costs. Please fill in this poll with your availa

Re: Review Request 114271: drawFloatFrame for QtQuick menus

2013-12-03 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114271/#review45041 --- Ship it! - David Edmundson On Dec. 3, 2013, 1:57 p.m., Marti

Re: Review Request 114271: drawFloatFrame for QtQuick menus

2013-12-03 Thread Martin Gräßlin
> On Dec. 3, 2013, 3:26 p.m., David Edmundson wrote: > > kstyles/oxygen/oxygenstyle.cpp, line 2558 > > > > > > in other cases in this file I've done: > > > > if (option->styleObject->inherits("QQuickStyl

Re: Review Request 114271: drawFloatFrame for QtQuick menus

2013-12-03 Thread David Edmundson
> On Dec. 3, 2013, 2:26 p.m., David Edmundson wrote: > > kstyles/oxygen/oxygenstyle.cpp, line 2558 > > > > > > in other cases in this file I've done: > > > > if (option->styleObject->inherits("QQuickStyl

Re: Review Request 114271: drawFloatFrame for QtQuick menus

2013-12-03 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114271/#review45037 --- kstyles/oxygen/oxygenstyle.cpp

Review Request 114271: drawFloatFrame for QtQuick menus

2013-12-03 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114271/ --- Review request for Plasma, David Edmundson and Hugo Pereira Da Costa. Repo

Re: Review Request 114263: Port share dataengine to KF5

2013-12-03 Thread Andrea Scarpino
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114263/ --- (Updated Dec. 3, 2013, 10:56 a.m.) Review request for KDE Frameworks and P

Re: Review Request 114253: Port favicons dataengine to KF5

2013-12-03 Thread Andrea Scarpino
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114253/ --- (Updated Dec. 3, 2013, 10:53 a.m.) Review request for KDE Frameworks and P

Re: Review Request 114260: Port mouse dataengine

2013-12-03 Thread Bhushan Shah
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114260/#review45021 --- There is similar review request for it.. https://git.reviewboa

Re: Oxygen in QtQuickControls

2013-12-03 Thread Martin Klapetek
On Tue, Dec 3, 2013 at 5:18 AM, Yichao Yu wrote: > On Mon, Dec 2, 2013 at 10:55 AM, Sebastian Kügler wrote: > > On Monday, December 02, 2013 15:30:26 David Edmundson wrote: > >> I'm working to fix using QtQuickControls with Oxygen. > >> > >> The current state is far from perfect. Some of it is q