----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114283/ -----------------------------------------------------------
Review request for Plasma. Repository: plasma-framework Description ------- Use QtQuickControls ScrollView internally Flickable has a very odd API in which contentHeight can't be trusted. we need to update our ScrollBars/ScrollArea to make use of the new originX and originY in order to fix a lot of bugs that we currently see with scrollbars. Instead of doing that, by porting to use QtQuick Controls we get all these bug fixes as well as _significantly_ reducing our code. Having a separate logic vs UI, makes things (IMHO) easier to read. I don't expect to merge this as-is; I haven't included the plasma feature that creates a SectionScroller if the content is a listview, but that should be viable. As far as I know all other features (keyboard controls / hiding buttons on touch screens) are still kept. Files removed are as indication as to long term changes from making this change, in order to do that we need to port all users from ScrollBars -> ScrollArea. (which is worth doing anyway IMHO) Diffs ----- src/declarativeimports/plasmacomponents/qml/ScrollBar.qml 93d7baf src/declarativeimports/plasmacomponents/qml/private/ScrollBarDelegate.qml 6b5edf0 src/declarativeimports/plasmaextracomponents/qml/ScrollArea.qml 20cd943 Diff: http://git.reviewboard.kde.org/r/114283/diff/ Testing ------- Widget Explorer in plasma-shell looks exactly as before. Thanks, David Edmundson
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
