Re: macro_add_compile_flags under kf5

On Wednesday 28 August 2013 16:35:39 Heena Mahour wrote: > Hi , > I am getting Unknown CMake command "macro_add_compile_flags". in kioclient > cmake under kf5 . > I found out that it is not to be used under kf5 as > macro_optional_find_package is replaced to find_package in a recent commit > Could

Re: Review Request 112208: KMix qml applet

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112208/#review38823 --- Can't we have it in branch or hosted somewhere on git? - Bhush

Re: Review Request 112329: Oxygen Style: Check widget validity in group box drawing

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112329/#review38821 --- This review has been submitted with commit 8fd2e80e0fee4de9596

Re: Review Request 112329: Oxygen Style: Check widget validity in group box drawing

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112329/ --- (Updated Aug. 28, 2013, 9:36 p.m.) Status -- This change has been mar

Re: Review Request 112329: Oxygen Style: Check widget validity in group box drawing

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112329/#review38815 --- This review has been submitted with commit d10c8c77e5b897acdd7

Re: Review Request 112208: KMix qml applet

> On Aug. 28, 2013, 9:10 p.m., Xuetian Weng wrote: > > plasma/kmix-applet-qml/contents/ui/HorizontalControl.qml, line 55 > > > > > > if volume is changed from kmix, not from the applet, this would issue a > > dupl

Re: Review Request 112208: KMix qml applet

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112208/#review38813 --- plasma/kmix-applet-qml/contents/ui/HorizontalControl.qml

Re: Review Request 112208: KMix qml applet

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112208/#review38812 --- File Attachment: Control Icon and Label left aligned

Re: Review Request 112329: Oxygen Style: Check widget validity in group box drawing

> On Aug. 28, 2013, 8:46 p.m., Hugo Pereira Da Costa wrote: > > Ship It! perfectly sane on my side (in fact there must be other places in the long long oxygenstyle code, where similar tests would help) - Hugo --- This is an automatical

Re: Review Request 112329: Oxygen Style: Check widget validity in group box drawing

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112329/#review38810 --- Ship it! Ship It! - Hugo Pereira Da Costa On Aug. 28, 2013,

Re: Review Request 112329: Oxygen Style: Check widget validity in group box drawing

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112329/ --- (Updated Aug. 28, 2013, 5:24 p.m.) Review request for Plasma and Hugo Pere

macro_add_compile_flags under kf5

Hi , I am getting Unknown CMake command "macro_add_compile_flags". in kioclient cmake under kf5 . I found out that it is not to be used under kf5 as macro_optional_find_package is replaced to find_package in a recent commit Could you suggest how could I fix it ? Regards -- -Heena Season of kde'1

Review Request 112329: Oxygen Style: Check widget validity in group box drawing

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112329/ --- Review request for Plasma. Description --- Check widget validity in g

Kinterprocesslock->kioslave/trash error

Hey , While porting kioslave/trash I encountered two errors , one is /kioslave/trash/kinterprocesslock.h:110:15: error: forward declaration of ‘struct KInterProcessLock::Private’ I tried adding class Private; above the class KInterProcessLock {} among many other things but that is not working he

Re: kcmodule under kf5

For questions like this be sure to read the KDE5PORTING.html in kdelibs-frameworks. Should this file be missing anything please let someone in frameworks development know so we can add it. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.k

Re: Review Request 112208: KMix qml applet

> On Aug. 22, 2013, 10:46 p.m., Aaron J. Seigo wrote: > > File Attachment: Applet Config Options > > > > > > Do we even really need horizontal/vertical orientation for the sliders > > as a configuration option? Other than "because we can"