> On Aug. 28, 2013, 8:46 p.m., Hugo Pereira Da Costa wrote: > > Ship It!
perfectly sane on my side (in fact there must be other places in the long long oxygenstyle code, where similar tests would help) - Hugo ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112329/#review38810 ----------------------------------------------------------- On Aug. 28, 2013, 5:24 p.m., David Edmundson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/112329/ > ----------------------------------------------------------- > > (Updated Aug. 28, 2013, 5:24 p.m.) > > > Review request for Plasma and Hugo Pereira Da Costa. > > > Description > ------- > > Check widget validity in group box drawing > > Widget is an optional parameter and may be 0. > This currently causes a crash when GroupBox is used by QtQuickControls > > -- > > Not sure which group to set, please reassign if plasma is wrong. > > > Diffs > ----- > > kstyles/oxygen/oxygenstyle.cpp 801bf2195edf8114c5f0ea9b9d1235711bc5728a > > Diff: http://git.reviewboard.kde.org/r/112329/diff/ > > > Testing > ------- > > Created QML test app to recreate some of OxygenDemo > No longer crashes \o/ > > > Thanks, > > David Edmundson > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
