Re: kcmodule under kf5

2013-08-27 Thread Martin Graesslin
On Tuesday 27 August 2013 19:56:16 Heena Mahour wrote: > but that is also giving following errors : > http://pastebin.com/raw.php?i=C5qePwbt this looks like some includes are missing. KDE_VERSION_STRING is deprecated AFAIK but still available (used in KWin). Just add: #include KAboutData is more

Re: kcmodule under kf5

2013-08-27 Thread Heena Mahour
I am referring to kcmtrash.cpp On Tue, Aug 27, 2013 at 7:56 PM, Heena Mahour wrote: > Hi, > I am getting an error while porting kioslave/trash under kf5 that > ‘componentData’ > is not a member of ‘KCMTrashConfigFactory’ > Also ,so I looked at the kcmodule.h and used KAboutData instead like t

kcmodule under kf5

2013-08-27 Thread Heena Mahour
Hi, I am getting an error while porting kioslave/trash under kf5 that ‘componentData’ is not a member of ‘KCMTrashConfigFactory’ Also ,so I looked at the kcmodule.h and used KAboutData instead like this TrashConfigModule::TrashConfigModule( QWidget* parent, const QVariantList& ) : KCModule( pa

Re: Review Request 112208: KMix qml applet

2013-08-27 Thread Diego Casella
> On Aug. 27, 2013, 10:57 a.m., Martin Klapetek wrote: > > File Attachment: Control Icon and Label left aligned > > > > > > I wonder if we still need the speaker icons. The way I see it they > > represent two things - one is "how loud is

Questions about models in NotificationDelegate.qml

2013-08-27 Thread Christoph Feck
Hi, Looking at the NotificationDelegate.qml file, I see several lines that say "notificationsModel.remove(index)", fired from timers, running animations etc. Do QML models automatically make sure the index is still valid, in other words, when e.g. the timer fires delayed, and another item has

Re: Review Request 112208: KMix qml applet

2013-08-27 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112208/#review38727 --- File Attachment: Control Icon and Label left aligned

Re: Review Request 112208: KMix qml applet

2013-08-27 Thread Diego Casella
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112208/ --- (Updated Aug. 27, 2013, 8:40 a.m.) Review request for Plasma, Aaron J. Sei

Re: Review Request 112208: KMix qml applet

2013-08-27 Thread Diego Casella
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112208/ --- (Updated Aug. 27, 2013, 8:39 a.m.) Review request for Plasma, Aaron J. Sei

Re: Review Request 112208: KMix qml applet

2013-08-27 Thread Diego Casella
> On Aug. 22, 2013, 2:34 p.m., Sebastian Kügler wrote: > > File Attachment: Menu Actions > > > > > > Maybe we could align this in the same way as the batter applet does? > > Diego Casella wrote: > The menu comes from a right-click fro

Re: Review Request 112208: KMix qml applet

2013-08-27 Thread Diego Casella
> On Aug. 26, 2013, 3:38 p.m., Igor Poboiko wrote: > > File Attachment: Vertical Control > > > > > > Do we need it? > > > > (there is volume level percentage under the tooltip) > > > > It isn't consistent with horizontal