> On Aug. 26, 2013, 3:38 p.m., Igor Poboiko wrote: > > File Attachment: Vertical Control > > <http://git.reviewboard.kde.org/r/112208/#fcomment83> > > > > Do we need it? > > > > (there is volume level percentage under the tooltip) > > > > It isn't consistent with horizontal view where there is no such label. > > Also it duplicates the information from slider. And also it reacts pretty > > slow to the changes when user moves the slider (due to slowness of the > > chain plasma->dbus->kmix->backend->kmix->dbus->plasma), which is pretty > > frustrating. > > > > A label (or a tooltip maybe?) with device name would be nice, because > > it is pretty hard to decide what volume am I changing when there are > > multiple cards (or just input and output sliders like in PulseAudio).
tooltpis are gone in rev2, see sebas comment ;) The reason I didn't used a label with this layout is that it would take sooo much space but sure, this is an issue that must be addressed because the user must know which control he/she's going to modify ... I'll try to play with some wrapMode Label properties and see if I can get something usable and good looking. - Diego ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112208/#review38661 ----------------------------------------------------------- On Aug. 24, 2013, 3:11 p.m., Diego Casella wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/112208/ > ----------------------------------------------------------- > > (Updated Aug. 24, 2013, 3:11 p.m.) > > > Review request for Plasma, Aaron J. Seigo, Christian Esken, Marco Martin, and > Igor Poboiko. > > > Description > ------- > > KMix qml applet. > As you can see from the screenshot, the applet is pretty much functional: you > can display all the controls available, change its orientation, and decide to > whether show all of them or just the Master Control, and refresh its status > when new controls are added/removed/updated (such as Amarok current playing > track). See screenshots below :) > Differences from the old kmix tray: > * no media player controls ( I never investigated how to get them, but > honestly opening the audio applet to change/skip/pause audio track makes > little sense to me ... if anyone wants this feature back, don't be shy and > step in); > * the button used to select which Mixers are visible has been changed to open > Phonon kcm page: since visible mixers are already configurable from KMix app, > having a button to show KMix *and* a button to modify Mixers visibilty made > little sense here too, so I preferred to give more visibility to Phonon kcm; > > Known issues: > * there is still no way to get notified of mouse wheel events over the > popupIcon, so it is not possible to scroll over to increase/decrease the > master control volume; > * no scroll events over the sliders too; > * if you want to use the applet you most likely will disable KMix tray icon > but, if you do so, KMix will show its GUI at every login and you have to > close it manually. This requires KMix to be patched. Furthermore, if you > click "KMix Setup" button, KMix window will not restored anymore: this needs > to be pathed as well. > * resize doesn't work properly. > > > Diffs > ----- > > plasma/kmix-applet-qml/contents/config/main.xml PRE-CREATION > plasma/kmix-applet-qml/contents/ui/ButtonBar.qml PRE-CREATION > plasma/kmix-applet-qml/contents/ui/HorizontalControl.qml PRE-CREATION > plasma/kmix-applet-qml/contents/ui/HorizontalMixerListDelegate.qml > PRE-CREATION > plasma/kmix-applet-qml/contents/ui/MixersList.qml PRE-CREATION > plasma/kmix-applet-qml/contents/ui/VerticalControl.qml PRE-CREATION > plasma/kmix-applet-qml/contents/ui/VerticalMixerListDelegate.qml > PRE-CREATION > plasma/kmix-applet-qml/contents/ui/config.ui PRE-CREATION > plasma/kmix-applet-qml/contents/ui/kmixapplet.qml PRE-CREATION > plasma/kmix-applet-qml/metadata.desktop PRE-CREATION > > Diff: http://git.reviewboard.kde.org/r/112208/diff/ > > > Testing > ------- > > Tested against master and works fine. > > > File Attachments > ---------------- > > Default look > > http://git.reviewboard.kde.org/media/uploaded/files/2013/08/22/kmix_applet.png > Menu Actions > > http://git.reviewboard.kde.org/media/uploaded/files/2013/08/22/kmix_applet1.png > Applet Config Options > > http://git.reviewboard.kde.org/media/uploaded/files/2013/08/22/kmix_applet2.png > Vertical Control > > http://git.reviewboard.kde.org/media/uploaded/files/2013/08/22/kmix_applet3.png > ToolButton label and Config page after updates > > http://git.reviewboard.kde.org/media/uploaded/files/2013/08/24/kmix_applet5.png > > > Thanks, > > Diego Casella > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
