Re: Review Request 112241: Fix "Show Launcher when not running" option in taskbar widget

> On Aug. 24, 2013, 3:17 p.m., Eike Hein wrote: > > Hm, on the face of it, this patch doesn't really make sense ... launcher > > items don't have an associated task, so the function should already return > > early and the extra condition should be redundant. Unless there's a race > > condition

Re: Review Request 111849: custom first week for plasmaclock.

> On Aug. 20, 2013, 9:03 a.m., Sebastian Kügler wrote: > > * The patch is not correctly submitted, it's submitted as screenshot, not > > as patch, that makes it impossible to review > > * You didn't attach a screenshot of the UI > > * Checking wether a patch applies is not testing it > > * The c

Re: Review Request 112208: KMix qml applet

> On Aug. 22, 2013, 10:46 p.m., Aaron J. Seigo wrote: > > File Attachment: Applet Config Options > > > > > > Do we even really need horizontal/vertical orientation for the sliders > > as a configuration option? Other than "because we can"

Re: Review Request 112208: KMix qml applet

> On Aug. 22, 2013, 10:46 p.m., Aaron J. Seigo wrote: > > File Attachment: Applet Config Options > > > > > > Do we even really need horizontal/vertical orientation for the sliders > > as a configuration option? Other than "because we can"

Re: Review Request 112208: KMix qml applet

> On Aug. 22, 2013, 2:34 p.m., Sebastian Kügler wrote: > > File Attachment: Menu Actions > > > > > > Maybe we could align this in the same way as the batter applet does? The menu comes from a right-click from within the widget -not the ap

Re: Review Request 112208: KMix qml applet

> On Aug. 22, 2013, 10:46 p.m., Aaron J. Seigo wrote: > > File Attachment: Applet Config Options > > > > > > Do we even really need horizontal/vertical orientation for the sliders > > as a configuration option? Other than "because we can"

Re: Review Request 112241: Fix "Show Launcher when not running" option in taskbar widget

> On Aug. 24, 2013, 3:17 p.m., Eike Hein wrote: > > Hm, on the face of it, this patch doesn't really make sense ... launcher > > items don't have an associated task, so the function should already return > > early and the extra condition should be redundant. Unless there's a race > > condition

Re: Review Request 112241: Fix "Show Launcher when not running" option in taskbar widget

> On Aug. 24, 2013, 3:17 p.m., Eike Hein wrote: > > Hm, on the face of it, this patch doesn't really make sense ... launcher > > items don't have an associated task, so the function should already return > > early and the extra condition should be redundant. Unless there's a race > > condition

Re: Review Request 112241: Fix "Show Launcher when not running" option in taskbar widget

> On Aug. 24, 2013, 3:17 p.m., Eike Hein wrote: > > Hm, on the face of it, this patch doesn't really make sense ... launcher > > items don't have an associated task, so the function should already return > > early and the extra condition should be redundant. Unless there's a race > > condition

Re: Review Request 112241: Fix "Show Launcher when not running" option in taskbar widget

> On Aug. 24, 2013, 3:17 p.m., Eike Hein wrote: > > Hm, on the face of it, this patch doesn't really make sense ... launcher > > items don't have an associated task, so the function should already return > > early and the extra condition should be redundant. Unless there's a race > > condition

Re: Review Request 112241: Fix "Show Launcher when not running" option in taskbar widget

> On Aug. 24, 2013, 3:17 p.m., Eike Hein wrote: > > Hm, on the face of it, this patch doesn't really make sense ... launcher > > items don't have an associated task, so the function should already return > > early and the extra condition should be redundant. Unless there's a race > > condition

Re: Review Request 112241: Fix "Show Launcher when not running" option in taskbar widget

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112241/#review38481 --- Hm, on the face of it, this patch doesn't really make sense ...

Re: Review Request 112208: KMix qml applet

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112208/ --- (Updated Aug. 24, 2013, 3:11 p.m.) Review request for Plasma, Aaron J. Sei

Re: Review Request 112208: KMix qml applet

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112208/ --- (Updated Aug. 24, 2013, 3:07 p.m.) Review request for Plasma, Aaron J. Sei

Review Request 112241: Fix "Show Launcher when not running" option in taskbar widget

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112241/ --- Review request for kde-workspace, Plasma and Eike Hein. Description --

Re: Review Request 112236: krunner: Add the full name of completion matches to history

> On Aug. 24, 2013, 12:08 p.m., Thomas Lübking wrote: > > kwin/clients/aurorae/themes/plastik/package/contents/ui/main.qml, line 274 > > > > > > ... ;-) > > Harald Hvaal wrote: > yeah, not sure what happened

Re: Review Request 112236: krunner: Add the full name of completion matches to history

> On Aug. 24, 2013, 10:08 a.m., Thomas Lübking wrote: > > kwin/clients/aurorae/themes/plastik/package/contents/ui/main.qml, line 274 > > > > > > ... ;-) yeah, not sure what happened with post-review here, but it'

Re: Review Request 112236: krunner: Add the full name of completion matches to history

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112236/#review38466 --- kwin/clients/aurorae/themes/plastik/package/contents/ui/main.q

Review Request 112236: krunner: Add the full name of completion matches to history

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112236/ --- Review request for kde-workspace and Plasma. Description --- Previous

Re: Review Request 111849: custom first week for plasmaclock.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111849/ --- (Updated Aug. 24, 2013, 7:46 a.m.) Review request for Plasma. Changes --

Re: Review Request 111849: custom first week for plasmaclock.

> On Aug. 20, 2013, 9:03 a.m., Sebastian Kügler wrote: > > * The patch is not correctly submitted, it's submitted as screenshot, not > > as patch, that makes it impossible to review > > * You didn't attach a screenshot of the UI > > * Checking wether a patch applies is not testing it > > * The c

Re: Review Request 111849: custom first week for plasmaclock.

> On Aug. 20, 2013, 9 a.m., Martin Tobias Holmedahl Sandsmark wrote: > > isn't this duplicating the functionality in system settings ? locale ? > > country/region & language ? calendar ? first day of the week? No, them are different function! - Hu ---