> On Aug. 24, 2013, 3:17 p.m., Eike Hein wrote: > > Hm, on the face of it, this patch doesn't really make sense ... launcher > > items don't have an associated task, so the function should already return > > early and the extra condition should be redundant. Unless there's a race > > condition in the library somewhere ... but then it still wouldn't crash on > > translating a QPoint. > > > > Thank you for the patch, but I really still have to find a way to reproduce > > this bug before just applying this blindly - it might be treating a symptom > > instead of addressing the root cause. > > Bhushan Shah wrote: > Are you sure that this happens on 32 bit only? > > Eike Hein wrote: > No, I'm not - except I can't reproduce it on any of my 64 bit machines, > and I have to assume if it were a widespread bug, the number of reports we'd > be getting would be much, much higher. Note that we didn't even get any > reports through any of the pre-releases about this, AFAIR. > > I'm typing this from a cellphone right now, but I hope when I get home > tonight I'll finally get around to setting up a 32 bit VM, and I'm hoping > it'll crash there so I can throw all the gdb/valgrind/asan at it we got :). > > Thomas Lübking wrote: > What bug and is "WId" involved?
https://bugs.kde.org/show_bug.cgi?id=322283 - Bhushan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112241/#review38481 ----------------------------------------------------------- On Aug. 24, 2013, 2 p.m., Bhushan Shah wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/112241/ > ----------------------------------------------------------- > > (Updated Aug. 24, 2013, 2 p.m.) > > > Review request for kde-workspace, Plasma and Eike Hein. > > > Description > ------- > > Fix the crash in plasma-desktop caused by newer QML taskbar widget. > > Simple steps to reproduce this crash. > > 1) Pin any task/application to taskbar using "show launcher when not running" > option. > 2) Close application. > 3) Desktop crashes. > > Reason : > > 1) In Tasks::itemGeometryChanged(int,int,int,int,int) line 300 it checks for > three conditions, > > -> pointer to task is not null > -> taskItem itself is not null > -> scene is not null > > 2) This condition gets false when item is LauncherItem. In function later > line 334 when calling iconRect.moveTopLeft(QPoint) function it gets crashed. > > Patch : > > This patch adds check in if condition to check if taskItem is > TaskManager::LauncherItemType and return from function if this is launcher > item. > > > Diffs > ----- > > plasma/desktop/applets/tasks/tasks.cpp c4aef4b > > Diff: http://git.reviewboard.kde.org/r/112241/diff/ > > > Testing > ------- > > Testing > > compilation - check > installation - check > plasmoidviewer - check > in panel - check > independently - check > > > Thanks, > > Bhushan Shah > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
