Re: Review Request 111908: Add KConfigLoader from Plasma Framework to KConfigGui

2013-08-08 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111908/ --- (Updated Aug. 9, 2013, 7:20 a.m.) Review request for KDE Frameworks, Plasm

Re: Review Request 111863: Feature: Folder Preview in Local Pictures Browsing

2013-08-08 Thread Shantanu Tushar
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111863/#review37374 --- Ship it! Works fine, just fix the little issues below and push

Re: Review Request 111908: Add KConfigLoader from Plasma Framework to KConfigGui

2013-08-08 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111908/#review37360 --- Totally makes sense to have that in KConfigGui. Still the issue

Re: Review Request 111863: Feature: Folder Preview in Local Pictures Browsing

2013-08-08 Thread Akshay Ratan
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111863/ --- (Updated Aug. 8, 2013, 2:30 p.m.) Review request for Plasma, Shantanu Tush

Re: Review Request 111863: Feature: Folder Preview in Local Pictures Browsing

2013-08-08 Thread Akshay Ratan
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111863/ --- (Updated Aug. 8, 2013, 2:20 p.m.) Review request for Plasma, Shantanu Tush

Re: Review Request 111908: Add KConfigLoader from Plasma Framework to KConfigGui

2013-08-08 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111908/ --- (Updated Aug. 8, 2013, 2:56 p.m.) Review request for KDE Frameworks, Plasm

Re: Review Request 111908: Add KConfigLoader from Plasma Framework to KConfigGui

2013-08-08 Thread David Faure
> On Aug. 7, 2013, 3:41 p.m., David Faure wrote: > > tier1/kconfig/autotests/kconfigloadertest.cpp, line 56 > > > > > > I have trouble understanding the purpose of this class. How is this > > different from > >