> On Aug. 7, 2013, 3:41 p.m., David Faure wrote: > > tier1/kconfig/autotests/kconfigloadertest.cpp, line 56 > > <http://git.reviewboard.kde.org/r/111908/diff/1/?file=176357#file176357line56> > > > > I have trouble understanding the purpose of this class. How is this > > different from > > > > QCOMPARE(configGroup.readEntry("DefaultBoolItem", true), true); > > > > ? > > > > OK the one difference is that the default value comes from the XML file > > instead of coming from the code, but apart from that? > > > > KConfigXT's entire purpose was to make things statically checked > > (compile-time), on top of the dynamic (string-based) KConfig. And now this > > is another layer on top, which makes things dynamic (string-based) again? > > I'm confused :-) > > > > Ah, is this actually only about introspecting KConfigXT xml files, to > > extract the defaults from it? But what would be the purpose of that? (isn't > > this accessible in the KConfigXT-generated code too?) > > > > Please expand the class documentation to make it clear for dummies like > > me, what is the actual purpose of the class, and in which case it should be > > used. > > > > Martin Gräßlin wrote: > I think it's best explained to think of cases where you don't have any > code in the first place. Examples are plasmoids or KWin scripts which just > ship a kconfigxt file and a ui file and with the help of the KConfigLoader we > are able to provide a working config interface dynamically loaded. > > @Aaron: do you have a suggestion on how to improve the documentation?
Ah, GUI generation, I see. A bit like KConfigDialog then, but you separated the parsing and the UI generation, and you don't need the compile-time generated KCoreConfigSkeleton). So I was wrong, it's not on top of the KConfigXT-generated code, it's instead of that. It just seems to me that KConfigLoader alone isn't really useful, but OK, it's a component in the overall architecture. It definitely needs documentation about what it can be used for, and how. - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111908/#review37284 ----------------------------------------------------------- On Aug. 8, 2013, 4:58 a.m., Martin Gräßlin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/111908/ > ----------------------------------------------------------- > > (Updated Aug. 8, 2013, 4:58 a.m.) > > > Review request for KDE Frameworks, Plasma and Aaron J. Seigo. > > > Description > ------- > > Add KConfigLoader from Plasma Framework to KConfigGui > > The ConfigLoader is way to awesome to not be directly in KConfig. > > > Diffs > ----- > > tier1/kconfig/autotests/CMakeLists.txt PRE-CREATION > tier1/kconfig/autotests/kconfigloadertest.h PRE-CREATION > tier1/kconfig/autotests/kconfigloadertest.cpp PRE-CREATION > tier1/kconfig/autotests/kconfigloadertest.xml PRE-CREATION > tier1/kconfig/src/gui/CMakeLists.txt PRE-CREATION > tier1/kconfig/src/gui/kconfigloader.h PRE-CREATION > tier1/kconfig/src/gui/kconfigloader.cpp PRE-CREATION > tier1/kconfig/src/gui/kconfigloader_p.h PRE-CREATION > tier1/kconfig/src/gui/kconfigloaderhandler_p.h PRE-CREATION > > Diff: http://git.reviewboard.kde.org/r/111908/diff/ > > > Testing > ------- > > > Thanks, > > Martin Gräßlin > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
