Re: [plasma-framework] /: Revert "Enabling C++11 flags for clang and gcc"

2013-06-28 Thread Kevin Ottens
On Friday 28 June 2013 23:58:21 Ivan Čukić wrote: > > OK, then we got a misunderstanding somewhere... > > > > Using those Q_* macros is perfectly fine (and even encouraged, we already > > use Q_DECL_OVERRIDE and I'd like to see more Q_NULLPTR for instance). They > > enable exactly what I was descr

Re: [plasma-framework] /: Revert "Enabling C++11 flags for clang and gcc"

2013-06-28 Thread Ivan Čukić
> OK, then we got a misunderstanding somewhere... > > Using those Q_* macros is perfectly fine (and even encouraged, we already > use Q_DECL_OVERRIDE and I'd like to see more Q_NULLPTR for instance). They > enable exactly what I was describing earlier: works without C++11 support, > you get extra

Re: [plasma-framework] /: Revert "Enabling C++11 flags for clang and gcc"

2013-06-28 Thread Kevin Ottens
On Friday 28 June 2013 23:13:34 Ivan Čukić wrote: > > such a premise VS2012 has a very partial C++11 support, Android NDK uses > > gcc 4.6 by default (apparently you can upgrade that to 4.7 but we can't > > expect third parties to do it by default, means partial support in both > > cases), BB10 cro

Re: [plasma-framework] /: Revert "Enabling C++11 flags for clang and gcc"

2013-06-28 Thread Ivan Čukić
> such a premise VS2012 has a very partial C++11 support, Android NDK uses > gcc 4.6 by default (apparently you can upgrade that to 4.7 but we can't > expect third parties to do it by default, means partial support in both > cases), BB10 cross- compiler doesn't properly support C++11. We're not T

Re: [plasma-framework] /: Revert "Enabling C++11 flags for clang and gcc"

2013-06-28 Thread Kevin Ottens
On Friday 28 June 2013 20:52:59 Aaron J. Seigo wrote: > On Friday, June 28, 2013 13:08:49 Kevin Ottens wrote: > > Just to clarify: It's not a "no-no" to using C++11, it's to make sure > > we're able to build without them. > > We have no interest in trying to maintain a build that does not require

Re: [plasma-framework] /: Revert "Enabling C++11 flags for clang and gcc"

2013-06-28 Thread Shaun Reich
On Fri, Jun 28, 2013 at 2:52 PM, Aaron J. Seigo wrote: > On Friday, June 28, 2013 13:08:49 Kevin Ottens wrote: >> Just to clarify: It's not a "no-no" to using C++11, it's to make sure we're >> able to build without them. > > We have no interest in trying to maintain a build that does not require C

Re: [plasma-framework] /: Revert "Enabling C++11 flags for clang and gcc"

2013-06-28 Thread Aaron J. Seigo
On Friday, June 28, 2013 13:08:49 Kevin Ottens wrote: > Just to clarify: It's not a "no-no" to using C++11, it's to make sure we're > able to build without them. We have no interest in trying to maintain a build that does not require C++11. There are too many useful features that we can take adva

Re: Review Request 111287: Fix of an issue in Escape Key functioning

2013-06-28 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111287/ --- (Updated June 28, 2013, 5:11 p.m.) Status -- This change has been mar

Re: Review Request 111287: Fix of an issue in Escape Key functioning

2013-06-28 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111287/#review35244 --- This review has been submitted with commit 87096cc45639d175275

Re: Review Request 111287: Fix of an issue in Escape Key functioning

2013-06-28 Thread Shantanu Tushar
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111287/#review35241 --- Ship it! Ship It! - Shantanu Tushar On June 28, 2013, 7:51

Re: [plasma-framework] /: Revert "Enabling C++11 flags for clang and gcc"

2013-06-28 Thread Ivan Čukić
> > Isn't the point of a dependency (on C++11) to make it required? > > Well, we have required and optional dependencies. C++11 is not special in > that regard, we can make it either required or optional. So, essentially, the issue is that Plasma keeps both the framework and the shells in the s

Re: [plasma-framework] /: Revert "Enabling C++11 flags for clang and gcc"

2013-06-28 Thread Kevin Ottens
On Friday 28 June 2013 07:33:43 Shaun Reich wrote: > On Fri, Jun 28, 2013 at 7:08 AM, Kevin Ottens wrote: > > On Friday 28 June 2013 11:02:25 Ivan Čukić wrote: > >> On Friday 28 June 2013 08:13:32 Kevin Ottens wrote: > >> > Git commit 597397b41f5450f24ddc784e0faa13133fed6bd5 by Kevin Ottens. > >>

Re: [plasma-framework] /: Revert "Enabling C++11 flags for clang and gcc"

2013-06-28 Thread Shaun Reich
On Fri, Jun 28, 2013 at 7:08 AM, Kevin Ottens wrote: > On Friday 28 June 2013 11:02:25 Ivan Čukić wrote: >> On Friday 28 June 2013 08:13:32 Kevin Ottens wrote: >> > Git commit 597397b41f5450f24ddc784e0faa13133fed6bd5 by Kevin Ottens. >> > Committed on 28/06/2013 at 08:07. >> > Pushed by ervin into

Re: [plasma-framework] /: Revert "Enabling C++11 flags for clang and gcc"

2013-06-28 Thread Kevin Ottens
On Friday 28 June 2013 11:02:25 Ivan Čukić wrote: > On Friday 28 June 2013 08:13:32 Kevin Ottens wrote: > > Git commit 597397b41f5450f24ddc784e0faa13133fed6bd5 by Kevin Ottens. > > Committed on 28/06/2013 at 08:07. > > Pushed by ervin into branch 'master'. > > > > Revert "Enabling C++11 flags for

Re: [plasma-framework] /: Revert "Enabling C++11 flags for clang and gcc"

2013-06-28 Thread Ivan Čukić
On Friday 28 June 2013 08:13:32 Kevin Ottens wrote: > Git commit 597397b41f5450f24ddc784e0faa13133fed6bd5 by Kevin Ottens. > Committed on 28/06/2013 at 08:07. > Pushed by ervin into branch 'master'. > > Revert "Enabling C++11 flags for clang and gcc" This request [1] got a green light by Aaron [2

Review Request 111287: Fix of an issue in Escape Key functioning

2013-06-28 Thread Akshay Ratan
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111287/ --- Review request for Plasma, Shantanu Tushar, Sinny Kumari, and Sujith Haridas