-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111287/#review35244
-----------------------------------------------------------


This review has been submitted with commit 
87096cc45639d17527531efb1fe2b771635de43d by Akshay Ratan to branch master.

- Commit Hook


On June 28, 2013, 7:51 a.m., Akshay Ratan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111287/
> -----------------------------------------------------------
> 
> (Updated June 28, 2013, 7:51 a.m.)
> 
> 
> Review request for Plasma, Shantanu Tushar, Sinny Kumari, and Sujith 
> Haridasan.
> 
> 
> Description
> -------
> 
> Steps to reproduce the earlier error :
> 
> 1) Select the BROWSE PICTURES/MUSIC/VIDEO option from the categories in 
> plasma-mediacenter Homescreen
> 2) Press Escape Key when the "PLACE screen" or initial browsing window having 
> various drives appears. Don't select anything, just press escape intending to 
> go    back to the homescreen.
> 3) Result:: PMC Application crashes 
> 
> However BACK button on the toolbar works fine.
> 
> This patch aims to solve this issue in escape key functioning. 
> 
> Shantanu: However, after applying this patch, as you will notice, escape key 
> in the same scenario mentioned in Step 2 , would take the user back "by one 
> level" and NOT to the homescreen. Please see if this is the behaviour 
> required.
> 
> 
> Diffs
> -----
> 
>   browsingbackends/localfiles/localfilesabstractbackend.cpp 31ada99 
> 
> Diff: http://git.reviewboard.kde.org/r/111287/diff/
> 
> 
> Testing
> -------
> 
> Yes. Application does not crash now in the scenario mentioned :)
> 
> 
> Thanks,
> 
> Akshay Ratan
> 
>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Reply via email to