Re: Review Request 111263: Revamping the filesystem browser in the plasma-mediacenter

2013-06-27 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111263/ --- (Updated June 27, 2013, 6:16 p.m.) Status -- This change has been mar

Re: Review Request 111263: Revamping the filesystem browser in the plasma-mediacenter

2013-06-27 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111263/#review35183 --- This review has been submitted with commit 49a4f4180528fb8cc1e

Re: Review Request 111263: Revamping the filesystem browser in the plasma-mediacenter

2013-06-27 Thread Akshay Ratan
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111263/ --- (Updated June 27, 2013, 5:59 p.m.) Review request for Plasma, Fabian Rieth

Re: Review Request 111263: Revamping the filesystem browser in the plasma-mediacenter

2013-06-27 Thread Sinny Kumari
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111263/#review35180 --- Ship it! Good work! After fixing mentioned minor issues, ship

Re: Review Request 111263: Revamping the filesystem browser in the plasma-mediacenter

2013-06-27 Thread Akshay Ratan
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111263/ --- (Updated June 27, 2013, 5 p.m.) Review request for Plasma, Fabian Riethmay

Re: Review Request 111263: Revamping the filesystem browser in the plasma-mediacenter

2013-06-27 Thread Shantanu Tushar
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111263/#review35174 --- looks good, just fix these issues browsingbackends/localfiles

Re: installing plasmoid

2013-06-27 Thread Marco Martin
On Thursday 27 June 2013 13:26:45 Heena Mahour wrote: > This is my CMakeLists.txt : http://pastebin.com/raw.php?i=ZMTe1H1Q look at showActivityManager and just do the same at the moment you are installing the desktop file (that on filesystem should remain metadata.desktop btw) in ${DATA_INSTALL_

Re: installing plasmoid

2013-06-27 Thread Heena Mahour
I am using Kubuntu 13.04 On Thu, Jun 27, 2013 at 1:26 PM, Heena Mahour wrote: > This is my CMakeLists.txt : http://pastebin.com/raw.php?i=ZMTe1H1Q > tree is : > window-list/ > package/ > package/ contents/ >contents/ ui/

Re: installing plasmoid

2013-06-27 Thread Heena Mahour
This is my CMakeLists.txt : http://pastebin.com/raw.php?i=ZMTe1H1Q tree is : window-list/ package/ package/ contents/ contents/ ui/ ui/ qml files here packqage/