Review Request 110786: Use dialog svg instead of tooltip for popupview

2013-06-02 Thread Hrvoje Senjan
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110786/ --- Review request for Plasma and Marco Martin. Description --- Patch for

Re: Review Request 110776: Bug 317451 Fix : A way to return to media from main screen

2013-06-02 Thread Shantanu Tushar
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110776/#review33589 --- Ship it! Good to go, just make sure of the following when push

Re: Review Request 110776: Bug 317451 Fix : A way to return to media from main screen

2013-06-02 Thread Akshay Ratan
> On June 2, 2013, 1:53 p.m., Sinny Kumari wrote: > > shells/newshell/package/contents/ui/mediacenter.qml, line 227 > > > > > > Instead of checking > > if(mediaImageViewer.visible || mediaPlayer.hasVideo), che

Review Request 110783: Fix non-Air icontasks tooltips

2013-06-02 Thread Hrvoje Senjan
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110783/ --- Review request for Plasma and Aaron J. Seigo. Description --- Basical

Re: Calendar plasmoid

2013-06-02 Thread Kevin Krammer
On Sunday, 2013-06-02, Marco Martin wrote: > On Saturday 01 June 2013, Heena Mahour wrote: > > Hey , > > I am having some problem here :P > > 1. I tried to build framework refering : > > http://community.kde.org/Frameworks/Building but I am getting a few error > > http://pastebin.com/raw.php?i=6p1j

Re: Device capabilities / platform status service

2013-06-02 Thread Aaron J. Seigo
On Sunday, June 2, 2013 10:57:44 Ivan Čukić wrote: > > screen resolution is already handled by other means. the only use case i > > can actually think for any of the things listed is the keyboard: if there > > is a hardware keyboard, don't show the on-screen software keyboard. > > How so? If we

Re: Review Request 110776: Bug 317451 Fix : A way to return to media from main screen

2013-06-02 Thread Sinny Kumari
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110776/#review33583 --- shells/newshell/package/contents/ui/mediacenter.qml

Re: Calendar plasmoid

2013-06-02 Thread Marco Martin
On Saturday 01 June 2013, Heena Mahour wrote: > Hey , > I am having some problem here :P > 1. I tried to build framework refering : > http://community.kde.org/Frameworks/Building but I am getting a few error > http://pastebin.com/raw.php?i=6p1jbxqc > 2.I came to know that calendar is partly ported

Re: Review Request 110776: Bug 317451 Fix : A way to return to media from main screen

2013-06-02 Thread Akshay Ratan
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110776/ --- (Updated June 2, 2013, 12:52 p.m.) Review request for Plasma, Shantanu Tus

Re: Review Request 110776: Bug 317451 Fix : A way to return to media from main screen

2013-06-02 Thread Sinny Kumari
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110776/#review33580 --- One issue I see after applying this patch: When no media is get

Re: Device capabilities / platform status service

2013-06-02 Thread Ivan Čukić
> .. or it could be a library rather than a service? Honestly, a library (khm khm solid) would be imo the right target. First, we can make it as a separate one, and then merge into solid when we are satisfied by it, and when kf5/solid is deemed stable. > screen resolution is already handled by

Re: Review Request 110776: Bug 317451 Fix : A way to return to media from main screen

2013-06-02 Thread Akshay Ratan
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110776/ --- (Updated June 2, 2013, 8:01 a.m.) Review request for Plasma, Shantanu Tush