Re: Review Request 110290: Share data engine - add im9.eu images upload service

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110290/#review31983 --- Ship it! Some small niggles, looks pretty good already. Please

Re: Review Request 110290: Share data engine - add im9.eu images upload service

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110290/ --- (Updated May 3, 2013, 8:48 p.m.) Review request for Plasma, Aaron J. Seigo

Review Request 110290: [Share data engine] Add im9.eu images upload service

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110290/ --- Review request for Plasma, Aaron J. Seigo, Artur Duque de Souza, and Marco

Review Request 110288: Checks if an optional field was instantiated before accessing it

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110288/ --- Review request for Plasma. Description --- The private field m_konsol

Re: Review Request 106110: Make autohide panel do not intercept events in fullscreen app

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106110/#review31964 --- Ship it! Ship It! - Marco Martin On March 22, 2013, 4:53 p.

Re: Review Request 107983: Fix KWindowSystem::compositingChanged signal

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107983/#review31963 --- any news on this? Martin, what do you think about it? - Marco

Re: Review Request 110065: fix notifcation plasmoid about some undefined data when retreive data from data engine

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110065/#review31962 --- Ship it! I think the last version is fine - Marco Martin On

Re: Review Request 110122: Patch to handle notifications with low timeouts masking earlier important notifications.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110122/#review31961 --- just my 2 cents on top of what has already been said, i agree w

Re: Review Request 110122: Patch to handle notifications with low timeouts masking earlier important notifications.

> On April 25, 2013, 2:02 p.m., Aaron J. Seigo wrote: > > plasma/generic/applets/notifications/contents/ui/LastNotificationPopup.qml, > > line 52 > > > > > > no minimum is set here as there was in the prior code.

Re: Review Request 110122: Patch to handle notifications with low timeouts masking earlier important notifications.

> On April 25, 2013, 2:02 p.m., Aaron J. Seigo wrote: > > plasma/generic/applets/notifications/contents/ui/LastNotificationPopup.qml, > > line 188 > > > > > > this tends to lead to accidental timers running when

Re: Plasma Workspaces 4.11: the last feature release in the 4.xseries for kde-workspace

@Kevin: I am only remotely following this issue, but as PackageKit developer, I would of course like to see our project in Plasma Workspaces as soon as possible. But I don't know the exact issues here. Also, having KSecrets merged would be a nice goal too. (The SecretService API is very stable, and

Re: Plasma Workspaces 4.11: the last feature release in the 4.xseries for kde-workspace

On Fri, May 3, 2013 at 1:41 PM, Michael Jansen wrote: > On Friday, May 03, 2013 02:39:31 PM Aaron J. Seigo wrote: > >> hopefully you can put it in a repository that can be used by kdelibs which > would both get around the 4.x kdelibs freeze *and* prepare it for frameworks. > > Just for clarificat

Re: Plasma Workspaces 4.11: the last feature release in the 4.xseries for kde-workspace

On Friday, May 03, 2013 02:39:31 PM Aaron J. Seigo wrote: > hopefully you can put it in a repository that can be used by kdelibs which would both get around the 4.x kdelibs freeze *and* prepare it for frameworks. Just for clarification because i think i misunderstand something. The proposed W

Re: Plasma Workspaces 4.11: the last feature release in the 4.xseries for kde-workspace

On Friday, May 3, 2013 14:11:02 Kevin Kofler wrote: > project works (as a distro patch), KSecrets never got finished after the > kdelibs patch was rejected. a completely workable approach was suggested. the work on ksecrets started and stopped a couple times. at one point it was tested for inclus

Re: Re: Plasma Workspaces 4.11: the last feature release in the 4.xseries for kde-workspace

"Martin Gräßlin" schrieb: > @Kevin: could you please stop this nonesense about your GSoC project. Yes we > all got that you are frustrated two years ago. Enough is enough! I don't want > to ever read about it any more! OK, so let's put aside *my* project and look at a more important one wh

Re: Review Request 109857: Add the "theme" directory to the plasmoid directory structure

> On April 9, 2013, 7:11 p.m., Commit Hook wrote: > > This review has been submitted with commit > > 24c26aefacff274ac52d773e39fbbfa3b458e213 by Alex Merry to branch master. Has this ever been ported to plasma-framework? and, it currently breaks unit tests - Marco -

Re: Review Request 109859: Allow plasmoids to provide fallbacks for themed images

> On April 9, 2013, 7:17 p.m., Commit Hook wrote: > > This review has been submitted with commit > > b32e6a8ebbebb6dfa836712874d942133a0fff71 by Alex Merry to branch master. > > Marco Martin wrote: > Has this ever been ported to plasma-framework? > > and, it currently breaks unit t

Re: Review Request 109859: Allow plasmoids to provide fallbacks for themed images

> On April 9, 2013, 7:17 p.m., Commit Hook wrote: > > This review has been submitted with commit > > b32e6a8ebbebb6dfa836712874d942133a0fff71 by Alex Merry to branch master. Has this ever been ported to plasma-framework? and, it currently breaks unit tests - Marco -

Re: Plasma::Service in plasma2

On Friday 03 May 2013 08:05:33 Aaron J. Seigo wrote: > > otherwise .. i don't see a better solution. > > > * It may require Plasma::DataEngine::Data back to a QVariantMap as in > > Plasma1 (with all performance issues it means), besides this would be > > needed for qml to directly read DataEngine