----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110122/#review31961 -----------------------------------------------------------
just my 2 cents on top of what has already been said, i agree with other reviews, the patch generally looks fine, the timer shouldn't be repeating (using restart() instead of running=true in onTriggered should fix the issue) and i would still make sure there is a not too long maximum timeout after wich the notification is hidden (as paradigm, the data that is sent by applications is a model to be considered "hints" that may or may not be followed by the visualization, that as in any model/view situation, it has the final say on the matter) - Marco Martin On April 25, 2013, 1:58 p.m., James Pike wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/110122/ > ----------------------------------------------------------- > > (Updated April 25, 2013, 1:58 p.m.) > > > Review request for Plasma. > > > Description > ------- > > Currently the timeout of the last notification to arrive is used as a basis > for hiding the notification display. This means that a notification with a > high timeout can get hidden by a new notification arriving with a much lower > timeout. > > This patch simply changes the behaviour to, when expiring a timer, go back > through the stack and display the most recent unexpired timer. If all timers > are expired the notification is closed as before. > > > This addresses bug 318295. > http://bugs.kde.org/show_bug.cgi?id=318295 > > > Diffs > ----- > > plasma/generic/applets/notifications/contents/ui/LastNotificationPopup.qml > 2fa1b11 > > Diff: http://git.reviewboard.kde.org/r/110122/diff/ > > > Testing > ------- > > Test script in https://bugs.kde.org/show_bug.cgi?id=318295 > > > Thanks, > > James Pike > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
