Re: Review Request 110176: Change the visual appearance of the composited outline

2013-04-25 Thread Martin Gräßlin
> On April 25, 2013, 11:10 a.m., Marco Martin wrote: > > seems a nice idea. > > since the shadow for that item is huge, does take it into account when it > > resizes the frame? )you would want the frame border, not the shadow more or > > less aligned with the window size) no the border is not

Re: Review Request 110176: Change the visual appearance of the composited outline

2013-04-25 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110176/ --- (Updated April 26, 2013, 8 a.m.) Review request for kwin and Plasma. Cha

Re: Removing noKephal branch

2013-04-25 Thread Aaron J. Seigo
On Thursday, April 25, 2013 16:31:54 Àlex Fiestas wrote: > So, any argument against removing the branch? none here ... but is there any reason to not merge it? e.g. is it incomplete, or just untested? if untested, we have plenty of time between now and 4.11 to make sure it is tested, and then it

Removing noKephal branch

2013-04-25 Thread Àlex Fiestas
Hey there Long time ago I pushed a branch called noKephal to kde-workspace with the intention of removing the internal library and replace it with QDesktopWidget (which kephal uses underneath). At this point, it makes little sense to continue with the work since for Qt5 we want to use QScreen, an

Re: Review Request 110122: Patch to handle notifications with low timeouts masking earlier important notifications.

2013-04-25 Thread James Pike
> On April 25, 2013, 2:02 p.m., Aaron J. Seigo wrote: > > sorry for the late reply; the people who could review this one were off in > > the last week at a dev sprint and reviews tend to get neglected when that > > happens. but better late than never, right? ;) looks pretty good, a few > > min

Re: Review Request 110122: Patch to handle notifications with low timeouts masking earlier important notifications.

2013-04-25 Thread James Pike
> On April 25, 2013, 2:02 p.m., Aaron J. Seigo wrote: > > plasma/generic/applets/notifications/contents/ui/LastNotificationPopup.qml, > > line 52 > > > > > > no minimum is set here as there was in the prior code.

Re: Review Request 110122: Patch to handle notifications with low timeouts masking earlier important notifications.

2013-04-25 Thread James Pike
> On April 25, 2013, 2:02 p.m., Aaron J. Seigo wrote: > > plasma/generic/applets/notifications/contents/ui/LastNotificationPopup.qml, > > line 188 > > > > > > this tends to lead to accidental timers running when

Re: Review Request 110122: Patch to handle notifications with low timeouts masking earlier important notifications.

2013-04-25 Thread James Pike
> On April 25, 2013, 2:02 p.m., Aaron J. Seigo wrote: > > plasma/generic/applets/notifications/contents/ui/LastNotificationPopup.qml, > > line 52 > > > > > > no minimum is set here as there was in the prior code.

Re: Review Request 110122: Patch to handle notifications with low timeouts masking earlier important notifications.

2013-04-25 Thread James Pike
> On April 25, 2013, 2:02 p.m., Aaron J. Seigo wrote: > > plasma/generic/applets/notifications/contents/ui/LastNotificationPopup.qml, > > line 188 > > > > > > this tends to lead to accidental timers running when

Re: Review Request 110122: Patch to handle notifications with low timeouts masking earlier important notifications.

2013-04-25 Thread James Pike
> On April 25, 2013, 2:02 p.m., Aaron J. Seigo wrote: > > plasma/generic/applets/notifications/contents/ui/LastNotificationPopup.qml, > > line 52 > > > > > > no minimum is set here as there was in the prior code.

Re: Review Request 110176: Change the visual appearance of the composited outline

2013-04-25 Thread Aaron J. Seigo
> On April 25, 2013, 12:29 p.m., Thomas Lübking wrote: > > It's a definitively visual improvement with many themes (including and esp. > > air), but eg. (old) oxygen and several others still get me a black overlay > > that does not much look like a frame or window and with "opaquity" it's > >

Re: Review Request 110122: Patch to handle notifications with low timeouts masking earlier important notifications.

2013-04-25 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110122/#review31563 --- sorry for the late reply; the people who could review this one

Re: Review Request 110122: Patch to handle notifications with low timeouts masking earlier important notifications.

2013-04-25 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110122/ --- (Updated April 25, 2013, 1:58 p.m.) Review request for Plasma. Descripti

Re: Review Request 109965: Refactor assetimporters

2013-04-25 Thread Aaron J. Seigo
> On April 13, 2013, 2:12 a.m., Aaron J. Seigo wrote: > > assetimporters/projectgutenberg/src/gutenbergdatabase.cpp, line 326 > > > > > > this is more partnerId than partnerQuery? > > Giorgos Tsiapaliokas wrote:

Re: Review Request 110176: Change the visual appearance of the composited outline

2013-04-25 Thread Martin Gräßlin
> On April 25, 2013, 2:29 p.m., Thomas Lübking wrote: > > It's a definitively visual improvement with many themes (including and esp. > > air), but eg. (old) oxygen and several others still get me a black overlay > > that does not much look like a frame or window and with "opaquity" it's > > (

Re: Review Request 110176: Change the visual appearance of the composited outline

2013-04-25 Thread Thomas Lübking
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110176/#review31550 --- It's a definitively visual improvement with many themes (includ

Re: Review Request 110176: Change the visual appearance of the composited outline

2013-04-25 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110176/#review31539 --- Ship it! seems a nice idea. since the shadow for that item is

FW: GSOC-2013 Proj- PMC rel. queries

2013-04-25 Thread Saurabh Jain
Dear sir/mam,Please went through the below forwarded mail which is in continuation to what Sinny mam had presented her views on my earlier ideas. In my last email, I have mentioned 2 more improvements so I request you to please give your feedback to me. Also, I apologize for not sending my past